From a3ced1f25c01276560ce935ac7e693d15e67133f Mon Sep 17 00:00:00 2001
From: danielmahal <danielmahal@gmail.com>
Date: Wed, 3 Sep 2014 11:17:25 +0200
Subject: [PATCH] Allow multiple listeners for identical paths
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The current version of ReactFire doesn't cope well with listening to the same path in multiple components. This is because the listener reference from `ref.on('value')` is never stored, and thus all listeners are removed when `ref.off('value')` is called without a listener parameter.

This patch stores each `ref.on('value')` listener and passes it to `ref.off('value', listener)`.
---
 src/ReactFireMixin.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/ReactFireMixin.js b/src/ReactFireMixin.js
index 1e7008d..613fb63 100644
--- a/src/ReactFireMixin.js
+++ b/src/ReactFireMixin.js
@@ -5,6 +5,7 @@ var ReactFireMixin = {
   /* Initializes the Firebase binding refs array */
   componentWillMount: function() {
     this.firebaseRefs = {};
+    this.firebaseListeners = {};
   },
 
   /* Removes any remaining Firebase bindings */
@@ -47,7 +48,7 @@ var ReactFireMixin = {
     }
 
     this.firebaseRefs[bindVar] = firebaseRef.ref();
-    firebaseRef.on("value", function(dataSnapshot) {
+    this.firebaseListeners[bindVar] = firebaseRef.on("value", function(dataSnapshot) {
       var newState = {};
       if (bindAsArray) {
         newState[bindVar] = this._toArray(dataSnapshot.val());
@@ -67,8 +68,9 @@ var ReactFireMixin = {
       throw new Error("unexpected value for bindVar. \"" + bindVar + "\" was either never bound or has already been unbound");
     }
 
-    this.firebaseRefs[bindVar].off("value");
+    this.firebaseRefs[bindVar].off("value", this.firebaseListeners[bindVar]);
     delete this.firebaseRefs[bindVar];
+    delete this.firebaseListeners[bindVar];
   },
 
 
@@ -122,4 +124,4 @@ var ReactFireMixin = {
     }
     return out;
   }
-};
\ No newline at end of file
+};