Brent Vatne
c7fff52408
Delegate to child routers for more than just the top screen in the stack ( #4587 )
...
* Delegate to child routers for more than just the top screen in the stack. Fixes #4185
* Add CHANGELOG entry
2018-06-27 17:37:30 -07:00
Brent Vatne
665736d754
Hoist navigation action creators for router above those for child router
2018-06-25 14:33:01 -07:00
Eric Vicenti
608365266a
@ericvicenti/universe ( #4493 )
...
* Isolate modules for uncontainerized navigators
* Clean up prop-types
* Fix warnings and web import friendlyness
* strip a flow
* Standalone provider/consumer navigation context
* export shallowEqual as module
* address various lint
# Conflicts:
# src/navigators/createStackNavigator.js
* Get tests to pass
2018-06-22 10:20:27 -07:00
Brent Vatne
76da804574
Fixes #4491
2018-06-21 15:24:52 -07:00
Eric Vicenti
aebe8a5c23
Fix isTransitioning on nested navigate ( #4520 )
...
This bug wasnt apparent until we fixed the transitioner to fully respect isTransitioning. The router did not handle this properly until now.
Enhanced a test to verify this in the future
2018-06-20 12:17:14 -07:00
Eric Vicenti
5f64a2a9cb
Refactor redo, child navigation to navigation prop ( #4453 )
2018-06-08 14:20:07 -07:00
Arthur Levoyer
b68c3a755d
Add missing tests about DeepLinking ( #4451 )
...
* Fix #1950 (Deep link not working when nesting have more than two levels.)
* Fix test
2018-06-07 11:37:57 -07:00
Brent Vatne
6a946d6ab7
Revert "Refactor, move child navigation to navigation prop ( #4425 )"
...
This reverts commit ba62509ff4 .
2018-06-06 13:19:08 -07:00
Eric Vicenti
ba62509ff4
Refactor, move child navigation to navigation prop ( #4425 )
...
* Refactor, move child navigation to navigation prop
This fixes our descriptor caching issue, and unblocks explicit nested navigation options.
As a side effect, the following APIs are introduced:
- navigation.getChildNavigation(routeKey) , which is useful for explicitly getting children config info
- navigation.router, access to the static router
- router.childRouters[routeName] , an optional way to access the children routers directly. If childRouters are not provided in a router, we will fall back on getComponentForRouteName(routeName).router, which is the previous external API for this (although it may be slower because it will require the whole screen component).
* supporting tests and top level actions
* cleanup
2018-06-06 12:50:30 -07:00
Brent Vatne
45391db7d9
Move all drawer code into react-navigation-drawer ( #4435 )
...
* Move all drawer code into react-navigation-drawer
* Remove react-native-drawer-layout-polyfill from package.json
2018-06-06 12:11:28 -07:00
Eric Vicenti
6cc86f66e1
Fix stack router state change without isTransitioning change ( #4368 )
2018-06-04 12:47:40 -07:00
Eric Vicenti
f555a9ec9a
Fix drawer router logic to close drawer ( #4394 )
2018-06-03 13:35:30 -07:00
Louis Lagrange
d778479e4a
Fix drawer router initial state ( #4219 )
...
* Fix drawer router initial state
* Add test
* Be concise
2018-05-25 16:01:53 -07:00
Steven Kabbes
931271198b
Remove unused code addNavigationHelpers ( #4179 )
2018-05-09 14:53:06 -07:00
Eric Vicenti
364144d639
Navigation Action Helpers at root ( #4151 )
2018-05-07 12:56:35 -07:00
Eric Vicenti
4e8d8ce12f
Fixes to drawer router handling of child routers ( #4131 )
...
Addresses #4129 , and also lets child routers swallow actions with null. Tests added
2018-05-06 11:59:40 -07:00
Serge Lebedev
f6bd3e4306
Fix setting undefined value to isTransitioning ( #4124 )
2018-05-06 10:04:57 -07:00
Brent Vatne
ab5481a290
Add context around a test in switchrouter
2018-05-03 15:43:37 -07:00
Brent Vatne
df281cfed0
Add router tests to clarify route resolution
2018-05-03 15:42:23 -07:00
Eric Vicenti
e0df3cf74a
Fix issue with nested navigation actions in stack ( #4114 )
2018-05-03 10:13:43 -07:00
Eric Vicenti
f7533a790f
Add tests to confirm setParam behavior ( #4099 )
...
Adding these tests because reports from this issue make me nervous:
https://github.com/react-navigation/react-navigation/issues/1274
2018-04-30 16:37:41 -07:00
Brent Vatne
5fff7ef5c6
Give inactive routes in stack opportunity to handle action ( #4064 )
2018-04-26 00:48:55 +00:00
Yao Hui Chua
7b4dd98255
Shift tests to isolate routers ( #3876 )
2018-04-09 13:00:01 -07:00
Eric Vicenti
f70a25a6a8
drawer router key ( #3925 )
2018-04-06 15:13:55 -07:00
Brent Vatne
0794c0faaa
Fix typo in SwitchRouter
2018-04-06 12:42:42 -07:00
Brent Vatne
ea28e84e5a
Fix stackConfig typo
2018-04-06 12:39:44 -07:00
Eric Vicenti
419ee5318d
custom action creators api ( #3923 )
2018-04-06 12:12:39 -07:00
Brent Vatne
22e09f7186
Prevent double application of navigationOptions function when using RouteName: ScreenName route config
2018-04-05 14:45:41 -07:00
Eric Vicenti
356646cbfa
Enhance replace action creator ( #3906 )
2018-04-05 11:25:04 -07:00
Brent Vatne
2232e394bb
Fix refactoring errors
2018-03-25 19:04:15 -07:00
Eric Vicenti
670d48366b
Actions creators overhaul ( #3619 )
2018-03-25 18:31:59 -07:00
Eric Vicenti
5e4512f3eb
Implement paths on SwitchRouter ( #3806 )
...
* Fix paths overriding in SwitchRouter
2018-03-22 22:41:27 -04:00
Eric Vicenti
577d99c165
StackRouter to return null on idempotent navigation ( #3793 )
...
This new behavior indicates that the action has been handled, but the state has not changed.
2018-03-19 16:46:57 -04:00
Eric Vicenti
4def39c0f7
Improve path matching for SwitchRouter and empty paths ( #3784 )
2018-03-18 22:10:15 -04:00
Brent Vatne
ee984943c7
Fix push action -- regressed when making navigate "less pushy"
2018-03-17 16:27:19 -04:00
Brent Vatne
7a978b1087
Implement "less pushy navigate" RFC
2018-03-12 15:22:51 -07:00
Brent Vatne
0c31bc44ea
Make push, pop, and popToTop bubble like navigate ( #3617 )
2018-03-12 15:06:38 -07:00
Brent Vatne
47f357f332
Fix TabRouter-test
2018-03-09 10:46:05 -08:00
Brent Vatne
bdda6fa5be
Add SwitchNavigator to 2.x
2018-03-07 17:35:15 -08:00
Brent Vatne
ae98089337
Cache event subscribers and clean up after unmounting ( #3648 )
...
* This caches "child event subscribers" by key and removes them when they're not needed anymore. Once a navigator unmounts we also remove upstream subscribers.
* Fix tests
2018-03-05 11:27:57 -08:00
Nicolas Beck
c6301abaed
Add initialRouteKey for StackRouter ( #3540 )
...
* use initialRouteName as key when initializing StackRouter
* fix null headerLeft
* merge back
* fixed tests
* use config flag
* fixed snapshots
* implemented requested changes
2018-03-02 16:06:27 -08:00
Brent Vatne
4569ad49f9
Fix regression in error message for route config validation
2018-03-02 12:18:11 -08:00
Eric Vicenti
2e47cbb3cb
Drawer Router ( #3618 )
2018-02-27 18:34:05 -08:00
Eric Vicenti
e27ad22c57
[BREAKING] New createNavigator API ( #3392 )
...
* New createNavigator and View API
See the RFC here:
https://github.com/react-navigation/rfcs/blob/master/text/0002-navigator-view-api.md
* shattered dreams of flow
* fix export
* Fix tab view issues found by brent
2018-02-27 17:27:58 -08:00
Serhii Palash
8fc8f3b8f7
Fix bug #3279 “Action within RESET doesn't trigger” ( #3593 )
...
https://github.com/react-navigation/react-navigation/issues/3279
2018-02-26 12:14:29 -08:00
Brent Vatne
c8531d0f38
Pop to top on TabNavigator when tapping already focused tab icon ( #3589 )
...
* Pop to top when tapping the tab icon for an already focused tab
* Dispatch popToTop with key to scope the action properly
* Add test for POP_TO_TOP with key
2018-02-25 16:33:20 -08:00
Vojtech Novak
276fb8f7b3
remove support for deprecated navigation actions ( #3595 )
...
* remove support for deprecated navigation actions
* remove deprecated action from flow definitions
2018-02-24 12:08:14 -08:00
Brent Vatne
0b0e9e9df5
Fix TabRouter to support shorthand route config
2018-02-19 18:16:23 -08:00
Marcin Raburski
14ee56a20d
getComponentForState made more generic ( #2498 )
2018-02-19 04:14:13 -08:00
Brent Vatne
fafd0e8702
Cleanup around StackRouter ( #3487 )
...
* Make StackRouter a bit easier to read, update and add some comments, add an explicit test around stack and navigate
* Address feedback for clarity
2018-02-17 11:14:03 -08:00