From ece5b6ef6a51785d7469c68f8e47ff7ff2738b0d Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Thu, 11 Oct 2018 06:44:34 -0400 Subject: [PATCH] Use `commitAllowingStateLoss` instead of `commit` (#24) This fixes a crash I saw in production on Android `java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState`. The fix is based on the comment here https://stackoverflow.com/questions/7575921/illegalstateexception-can-not-perform-this-action-after-onsaveinstancestate-wit. The crash stopped happening since deploying this fix. Fixes #20 --- .../src/main/java/com/swmansion/rnscreens/ScreenContainer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.java b/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.java index 472d1f17..2f1f615d 100644 --- a/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.java +++ b/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.java @@ -96,7 +96,7 @@ public class ScreenContainer extends ViewGroup { private void tryCommitTransaction() { if (mCurrentTransaction != null) { - mCurrentTransaction.commit(); + mCurrentTransaction.commitAllowingStateLoss(); mCurrentTransaction = null; } }