From d4dfdf8315f968bbac2df2e11652e40e95268103 Mon Sep 17 00:00:00 2001
From: Brent Vatne <brentvatne@gmail.com>
Date: Fri, 26 Jan 2018 15:54:46 -0800
Subject: [PATCH] Remove NavigatorTypes (#3331)

---
 .../src/navigators/DrawerNavigator.js         | 49 ++++++++-----------
 .../src/navigators/NavigatorTypes.js          |  9 ----
 .../src/navigators/StackNavigator.js          | 38 +++++++-------
 .../src/navigators/TabNavigator.js            |  9 +---
 .../src/navigators/createNavigator.js         | 11 +----
 5 files changed, 39 insertions(+), 77 deletions(-)
 delete mode 100644 packages/react-navigation/src/navigators/NavigatorTypes.js

diff --git a/packages/react-navigation/src/navigators/DrawerNavigator.js b/packages/react-navigation/src/navigators/DrawerNavigator.js
index c9358015..61eb45c1 100644
--- a/packages/react-navigation/src/navigators/DrawerNavigator.js
+++ b/packages/react-navigation/src/navigators/DrawerNavigator.js
@@ -9,8 +9,6 @@ import DrawerView from '../views/Drawer/DrawerView';
 import DrawerItems from '../views/Drawer/DrawerNavigatorItems';
 import SafeAreaView from '../views/SafeAreaView';
 
-import NavigatorTypes from './NavigatorTypes';
-
 // A stack navigators props are the intersection between
 // the base navigator props (navgiation, screenProps, etc)
 // and the view's props
@@ -66,16 +64,12 @@ const DrawerNavigator = (routeConfigs, config = {}) => {
   } = mergedConfig;
 
   const contentRouter = TabRouter(routeConfigs, tabsConfig);
-
   const drawerRouter = TabRouter(
     {
       [drawerCloseRoute]: {
-        screen: createNavigator(
-          contentRouter,
-          routeConfigs,
-          config,
-          NavigatorTypes.DRAWER
-        )(props => <DrawerScreen {...props} />),
+        screen: createNavigator(contentRouter, routeConfigs, config)(props => (
+          <DrawerScreen {...props} />
+        )),
       },
       [drawerOpenRoute]: {
         screen: () => null,
@@ -89,26 +83,23 @@ const DrawerNavigator = (routeConfigs, config = {}) => {
     }
   );
 
-  const navigator = createNavigator(
-    drawerRouter,
-    routeConfigs,
-    config,
-    NavigatorTypes.DRAWER
-  )(props => (
-    <DrawerView
-      {...props}
-      drawerBackgroundColor={drawerBackgroundColor}
-      drawerLockMode={drawerLockMode}
-      useNativeAnimations={useNativeAnimations}
-      drawerWidth={drawerWidth}
-      contentComponent={contentComponent}
-      contentOptions={contentOptions}
-      drawerPosition={drawerPosition}
-      drawerOpenRoute={drawerOpenRoute}
-      drawerCloseRoute={drawerCloseRoute}
-      drawerToggleRoute={drawerToggleRoute}
-    />
-  ));
+  const navigator = createNavigator(drawerRouter, routeConfigs, config)(
+    props => (
+      <DrawerView
+        {...props}
+        drawerBackgroundColor={drawerBackgroundColor}
+        drawerLockMode={drawerLockMode}
+        useNativeAnimations={useNativeAnimations}
+        drawerWidth={drawerWidth}
+        contentComponent={contentComponent}
+        contentOptions={contentOptions}
+        drawerPosition={drawerPosition}
+        drawerOpenRoute={drawerOpenRoute}
+        drawerCloseRoute={drawerCloseRoute}
+        drawerToggleRoute={drawerToggleRoute}
+      />
+    )
+  );
 
   return createNavigationContainer(navigator);
 };
diff --git a/packages/react-navigation/src/navigators/NavigatorTypes.js b/packages/react-navigation/src/navigators/NavigatorTypes.js
deleted file mode 100644
index 59f297ac..00000000
--- a/packages/react-navigation/src/navigators/NavigatorTypes.js
+++ /dev/null
@@ -1,9 +0,0 @@
-const STACK = 'react-navigation/STACK';
-const TABS = 'react-navigation/TABS';
-const DRAWER = 'react-navigation/DRAWER';
-
-export default {
-  STACK,
-  TABS,
-  DRAWER,
-};
diff --git a/packages/react-navigation/src/navigators/StackNavigator.js b/packages/react-navigation/src/navigators/StackNavigator.js
index 316ffc8c..7f2abb26 100644
--- a/packages/react-navigation/src/navigators/StackNavigator.js
+++ b/packages/react-navigation/src/navigators/StackNavigator.js
@@ -3,7 +3,6 @@ import createNavigationContainer from '../createNavigationContainer';
 import createNavigator from './createNavigator';
 import CardStackTransitioner from '../views/CardStack/CardStackTransitioner';
 import StackRouter from '../routers/StackRouter';
-import NavigatorTypes from './NavigatorTypes';
 import NavigationActions from '../NavigationActions';
 
 // A stack navigators props are the intersection between
@@ -34,26 +33,23 @@ export default (routeConfigMap, stackConfig = {}) => {
   const router = StackRouter(routeConfigMap, stackRouterConfig);
 
   // Create a navigator with CardStackTransitioner as the view
-  const navigator = createNavigator(
-    router,
-    routeConfigMap,
-    stackConfig,
-    NavigatorTypes.STACK
-  )(props => (
-    <CardStackTransitioner
-      {...props}
-      headerMode={headerMode}
-      mode={mode}
-      cardStyle={cardStyle}
-      transitionConfig={transitionConfig}
-      onTransitionStart={onTransitionStart}
-      onTransitionEnd={(lastTransition, transition) => {
-        const { state, dispatch } = props.navigation;
-        dispatch(NavigationActions.completeTransition());
-        onTransitionEnd && onTransitionEnd();
-      }}
-    />
-  ));
+  const navigator = createNavigator(router, routeConfigMap, stackConfig)(
+    props => (
+      <CardStackTransitioner
+        {...props}
+        headerMode={headerMode}
+        mode={mode}
+        cardStyle={cardStyle}
+        transitionConfig={transitionConfig}
+        onTransitionStart={onTransitionStart}
+        onTransitionEnd={(lastTransition, transition) => {
+          const { state, dispatch } = props.navigation;
+          dispatch(NavigationActions.completeTransition());
+          onTransitionEnd && onTransitionEnd();
+        }}
+      />
+    )
+  );
 
   return createNavigationContainer(navigator);
 };
diff --git a/packages/react-navigation/src/navigators/TabNavigator.js b/packages/react-navigation/src/navigators/TabNavigator.js
index 6f9f6921..f8a3ede2 100644
--- a/packages/react-navigation/src/navigators/TabNavigator.js
+++ b/packages/react-navigation/src/navigators/TabNavigator.js
@@ -8,8 +8,6 @@ import TabView from '../views/TabView/TabView';
 import TabBarTop from '../views/TabView/TabBarTop';
 import TabBarBottom from '../views/TabView/TabBarBottom';
 
-import NavigatorTypes from './NavigatorTypes';
-
 // A tab navigators props are the intersection between
 // the base navigator props (navgiation, screenProps, etc)
 // and the view's props
@@ -30,12 +28,7 @@ const TabNavigator = (routeConfigs, config = {}) => {
 
   const router = TabRouter(routeConfigs, tabsConfig);
 
-  const navigator = createNavigator(
-    router,
-    routeConfigs,
-    config,
-    NavigatorTypes.TABS
-  )(props => (
+  const navigator = createNavigator(router, routeConfigs, config)(props => (
     <TabView
       {...props}
       tabBarComponent={tabBarComponent}
diff --git a/packages/react-navigation/src/navigators/createNavigator.js b/packages/react-navigation/src/navigators/createNavigator.js
index ca64a1c6..caac4ecc 100644
--- a/packages/react-navigation/src/navigators/createNavigator.js
+++ b/packages/react-navigation/src/navigators/createNavigator.js
@@ -3,19 +3,10 @@ import React from 'react';
 /**
  * Creates a navigator based on a router and a view that renders the screens.
  */
-export default function createNavigator(
-  router,
-  routeConfigs,
-  navigatorConfig,
-  navigatorType
-) {
+export default function createNavigator(router, routeConfigs, navigatorConfig) {
   return NavigationView => {
     class Navigator extends React.Component {
       static router = router;
-
-      static routeConfigs = routeConfigs;
-      static navigatorConfig = navigatorConfig;
-      static navigatorType = navigatorType;
       static navigationOptions = null;
 
       render() {