From ab20beddea5ca38eec3b7b3a4a14dc3e4e5df5e5 Mon Sep 17 00:00:00 2001 From: Brent Vatne Date: Wed, 31 Oct 2018 19:23:44 -0700 Subject: [PATCH] Fix linting and typo --- .../stack/example/src/HeaderBackgrounds.js | 4 ++-- packages/stack/example/src/HeaderPreset.js | 2 +- packages/stack/example/src/StackWithDrawer.js | 2 +- .../views/Header/HeaderStyleInterpolator.js | 2 -- .../src/views/StackView/StackViewLayout.js | 20 ++++++++----------- 5 files changed, 12 insertions(+), 18 deletions(-) diff --git a/packages/stack/example/src/HeaderBackgrounds.js b/packages/stack/example/src/HeaderBackgrounds.js index 5910d47f..31552084 100644 --- a/packages/stack/example/src/HeaderBackgrounds.js +++ b/packages/stack/example/src/HeaderBackgrounds.js @@ -1,4 +1,4 @@ -import React, { Component } from 'react'; +import React } from 'react'; import { StyleSheet, View, Text } from 'react-native'; import { createStackNavigator } from 'react-navigation-stack'; @@ -71,7 +71,7 @@ function createHeaderBackgroundExample(options = {}) { }, }, News: { - screen: ({ navigation }) => ( + screen: () => ( {}}> News Screen diff --git a/packages/stack/example/src/HeaderPreset.js b/packages/stack/example/src/HeaderPreset.js index e3a6ea66..4884993b 100644 --- a/packages/stack/example/src/HeaderPreset.js +++ b/packages/stack/example/src/HeaderPreset.js @@ -1,5 +1,5 @@ import * as React from 'react'; -import { Button, ScrollView, StatusBar } from 'react-native'; +import { Button, StatusBar } from 'react-native'; import { SafeAreaView } from '@react-navigation/native'; import { createStackNavigator } from 'react-navigation-stack'; diff --git a/packages/stack/example/src/StackWithDrawer.js b/packages/stack/example/src/StackWithDrawer.js index adf881cf..3d0a1b36 100644 --- a/packages/stack/example/src/StackWithDrawer.js +++ b/packages/stack/example/src/StackWithDrawer.js @@ -41,7 +41,7 @@ const Drawer = createDrawerNavigator( }, { contentComponent: props => , - navigationOptions: { title: 'Example' } + navigationOptions: { title: 'Example' }, } ); diff --git a/packages/stack/src/views/Header/HeaderStyleInterpolator.js b/packages/stack/src/views/Header/HeaderStyleInterpolator.js index cb80380a..ae4ed1ea 100644 --- a/packages/stack/src/views/Header/HeaderStyleInterpolator.js +++ b/packages/stack/src/views/Header/HeaderStyleInterpolator.js @@ -1,8 +1,6 @@ import { Dimensions, I18nManager } from 'react-native'; import getSceneIndicesForInterpolationInputRange from '../../utils/getSceneIndicesForInterpolationInputRange'; -const EPS = 1e-5; - function hasHeader(scene) { if (!scene) { return true; diff --git a/packages/stack/src/views/StackView/StackViewLayout.js b/packages/stack/src/views/StackView/StackViewLayout.js index b1f774fb..fbc7760a 100644 --- a/packages/stack/src/views/StackView/StackViewLayout.js +++ b/packages/stack/src/views/StackView/StackViewLayout.js @@ -43,13 +43,9 @@ const EaseInOut = Easing.inOut(Easing.ease); /** * Enumerate possible values for validation */ -const HEADER_LAYOUT_PRESET_VALUES = ['center', 'left']; -const HEADER_TRANSITION_PRESET_VALUES = ['fade-in-place', 'uikit']; -const HEADER_BACKGROUND_TRANSITION_PRESET_VALUES = [ - 'toggle', - 'fade', - 'translate', -]; +const HEADER_LAYOUT_PRESET = ['center', 'left']; +const HEADER_TRANSITION_PRESET = ['fade-in-place', 'uikit']; +const HEADER_BACKGROUND_TRANSITION_PRESET = ['toggle', 'fade', 'translate']; /** * The max duration of the card animation in milliseconds after released gesture. @@ -655,7 +651,7 @@ class StackViewLayout extends React.Component { const { headerBackgroundTransitionPreset } = this.props; if (headerBackgroundTransitionPreset) { if ( - HEADER_BACKGROUND_TRANSITION_PRESET_VALUES.includes( + HEADER_BACKGROUND_TRANSITION_PRESET.includes( headerBackgroundTransitionPreset ) ) { @@ -694,13 +690,13 @@ class StackViewLayout extends React.Component { ); } } - if (HEADER_LAYOUT_PRESET_VALUES.includes(headerLayoutPreset)) { + if (HEADER_LAYOUT_PRESET.includes(headerLayoutPreset)) { return headerLayoutPreset; } if (__DEV__) { console.error( - `Invalid configuration applied for headerLayoutPreset - expected one of ${HEADER_LAYOUT_PRESET_VALUES.join( + `Invalid configuration applied for headerLayoutPreset - expected one of ${HEADER_LAYOUT_PRESET.join( ', ' )} but received ${JSON.stringify(headerLayoutPreset)}` ); @@ -723,13 +719,13 @@ class StackViewLayout extends React.Component { const { headerTransitionPreset } = this.props; if (headerTransitionPreset) { - if (HEADER_TRANSITION_PRESET_VALUES.includes(headerTransitionPreset)) { + if (HEADER_TRANSITION_PRESET.includes(headerTransitionPreset)) { return headerTransitionPreset; } if (__DEV__) { console.error( - `Invalid configuration applied for headerTransitionPreset - expected one of ${HEADER_TRANSITION_PRESET_VALUES.join( + `Invalid configuration applied for headerTransitionPreset - expected one of ${HEADER_TRANSITION_PRESET.join( ', ' )} but received ${JSON.stringify(headerTransitionPreset)}` );