kylefang/react-navigation
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-navigation.git synced 2026-04-28 12:25:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent state change being emitted unnecessarily

Browse Source
This commit is contained in:
Satyajit Sahoo
2020-06-01 21:32:08 +02:00
parent 9305bfa939
commit ab1f79c096
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/src/BaseNavigationContainer.tsx
View File

@@ -237,6 +237,12 @@ const BaseNavigationContainer = React.forwardRef(
[getKey, getState, setKey, setState, state, addOptionsGetter]
);
const onStateChangeRef = React.useRef(onStateChange);
React.useEffect(() => {
onStateChangeRef.current = onStateChange;
});
React.useEffect(() => {
if (process.env.NODE_ENV !== 'production') {
if (
@@ -263,12 +269,12 @@ const BaseNavigationContainer = React.forwardRef(
trackState(getRootState);
}
if (!isFirstMountRef.current && onStateChange) {
onStateChange(getRootState());
if (!isFirstMountRef.current && onStateChangeRef.current) {
onStateChangeRef.current(getRootState());
}
isFirstMountRef.current = false;
}, [onStateChange, trackState, getRootState, emitter, state]);
}, [trackState, getRootState, emitter, state]);
return (
<ScheduleUpdateContext.Provider value={scheduleContext}>