From 6b2079735b1566c48d80e17e2d5a306ca493542f Mon Sep 17 00:00:00 2001 From: "satyajit.happy" Date: Sat, 8 Jun 2019 01:18:48 +0200 Subject: [PATCH] refactor: keep transition states locally and implement animated replace --- packages/stack/example/package.json | 9 +- packages/stack/example/src/SimpleStack.js | 4 + packages/stack/example/yarn.lock | 355 +-------- packages/stack/package.json | 5 +- .../@react-navigation+core+3.4.1.patch | 688 ------------------ .../NestedNavigator.test.tsx.snap | 66 +- .../StackNavigator.test.tsx.snap | 4 +- packages/stack/src/types.tsx | 2 + packages/stack/src/views/Header/Header.tsx | 16 +- .../src/views/Header/HeaderContainer.tsx | 18 +- packages/stack/src/views/Stack/Stack.tsx | 23 +- packages/stack/src/views/Stack/StackView.tsx | 247 +++++-- packages/stack/yarn.lock | 55 +- 13 files changed, 304 insertions(+), 1188 deletions(-) delete mode 100644 packages/stack/patches/@react-navigation+core+3.4.1.patch diff --git a/packages/stack/example/package.json b/packages/stack/example/package.json index 5948436a..44ea3251 100644 --- a/packages/stack/example/package.json +++ b/packages/stack/example/package.json @@ -6,8 +6,7 @@ "scripts": { "start": "expo start", "android": "expo start --android", - "ios": "expo start --ios", - "postinstall": "patch-package --patch-dir ../patches" + "ios": "expo start --ios" }, "dependencies": { "@react-navigation/core": "3.4.1", @@ -16,8 +15,6 @@ "expo-asset": "^5.0.1", "expo-constants": "~5.0.1", "hoist-non-react-statics": "^3.3.0", - "patch-package": "^6.1.2", - "postinstall-postinstall": "^2.0.0", "react": "16.8.3", "react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz", "react-native-paper": "^2.15.2", @@ -25,9 +22,7 @@ "react-navigation-tabs": "*" }, "devDependencies": { - "babel-plugin-module-resolver": "^3.2.0", - "patch-package": "^6.1.2", - "postinstall-postinstall": "^2.0.0" + "babel-plugin-module-resolver": "^3.2.0" }, "resolutions": { "react-native-safe-area-view": "0.14.5" diff --git a/packages/stack/example/src/SimpleStack.js b/packages/stack/example/src/SimpleStack.js index c2a2501a..59f21301 100644 --- a/packages/stack/example/src/SimpleStack.js +++ b/packages/stack/example/src/SimpleStack.js @@ -9,6 +9,10 @@ const Buttons = withNavigation(props => ( title="Go to Details" onPress={() => props.navigation.navigate('Details')} /> +