From 167056ba91c828798d0d21c1fcad84cc2cb954e3 Mon Sep 17 00:00:00 2001 From: "satyajit.happy" Date: Mon, 15 Jul 2019 17:35:21 +0200 Subject: [PATCH] refactor: rename gesturesEnabled to gestureEnabled for consistency --- packages/stack/src/types.tsx | 2 +- packages/stack/src/views/Stack/Card.tsx | 8 ++++---- packages/stack/src/views/Stack/Stack.tsx | 2 +- packages/stack/src/views/Stack/StackItem.tsx | 6 +++--- packages/stack/src/views/Stack/StackView.tsx | 6 +++--- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/stack/src/types.tsx b/packages/stack/src/types.tsx index 907fac71..5d016eb8 100644 --- a/packages/stack/src/types.tsx +++ b/packages/stack/src/types.tsx @@ -102,7 +102,7 @@ export type NavigationStackOptions = HeaderOptions & cardTransparent?: boolean; cardStyle?: StyleProp; animationEnabled?: boolean; - gesturesEnabled?: boolean; + gestureEnabled?: boolean; gestureResponseDistance?: { vertical?: number; horizontal?: number; diff --git a/packages/stack/src/views/Stack/Card.tsx b/packages/stack/src/views/Stack/Card.tsx index 69673e95..cebefd9b 100755 --- a/packages/stack/src/views/Stack/Card.tsx +++ b/packages/stack/src/views/Stack/Card.tsx @@ -36,7 +36,7 @@ type Props = ViewProps & { children: React.ReactNode; overlayEnabled: boolean; shadowEnabled: boolean; - gesturesEnabled: boolean; + gestureEnabled: boolean; gestureResponseDistance?: { vertical?: number; horizontal?: number; @@ -98,7 +98,7 @@ export default class Card extends React.Component { static defaultProps = { overlayEnabled: Platform.OS !== 'ios', shadowEnabled: true, - gesturesEnabled: true, + gestureEnabled: true, }; componentDidUpdate(prevProps: Props) { @@ -473,7 +473,7 @@ export default class Card extends React.Component { next, overlayEnabled, shadowEnabled, - gesturesEnabled, + gestureEnabled, gestureDirection, children, styleInterpolator, @@ -516,7 +516,7 @@ export default class Card extends React.Component { > { cardOverlayEnabled={cardOverlayEnabled} cardShadowEnabled={cardShadowEnabled} cardStyle={cardStyle} - gesturesEnabled={index !== 0 && getGesturesEnabled({ route })} + gestureEnabled={index !== 0 && getGesturesEnabled({ route })} onPageChangeStart={onPageChangeStart} onPageChangeConfirm={onPageChangeConfirm} onPageChangeCancel={onPageChangeCancel} diff --git a/packages/stack/src/views/Stack/StackItem.tsx b/packages/stack/src/views/Stack/StackItem.tsx index 7a2cec83..758ddcfa 100644 --- a/packages/stack/src/views/Stack/StackItem.tsx +++ b/packages/stack/src/views/Stack/StackItem.tsx @@ -26,7 +26,7 @@ type Props = TransitionPreset & { cardOverlayEnabled?: boolean; cardShadowEnabled?: boolean; cardStyle?: StyleProp; - gesturesEnabled?: boolean; + gestureEnabled?: boolean; getPreviousRoute: (props: { route: Route }) => Route | undefined; renderHeader: (props: HeaderContainerProps) => React.ReactNode; renderScene: (props: { route: Route }) => React.ReactNode; @@ -97,7 +97,7 @@ export default class StackItem extends React.PureComponent { cardOverlayEnabled, cardShadowEnabled, cardStyle, - gesturesEnabled, + gestureEnabled, onPageChangeStart, onPageChangeCancel, gestureResponseDistance, @@ -128,7 +128,7 @@ export default class StackItem extends React.PureComponent { onClose={this.handleClose} overlayEnabled={cardOverlayEnabled} shadowEnabled={cardShadowEnabled} - gesturesEnabled={gesturesEnabled} + gestureEnabled={gestureEnabled} onTransitionStart={this.handleTransitionStart} onGestureBegin={onPageChangeStart} onGestureCanceled={onPageChangeCancel} diff --git a/packages/stack/src/views/Stack/StackView.tsx b/packages/stack/src/views/Stack/StackView.tsx index 393e85c6..05793b77 100644 --- a/packages/stack/src/views/Stack/StackView.tsx +++ b/packages/stack/src/views/Stack/StackView.tsx @@ -179,7 +179,7 @@ class StackView extends React.Component { const descriptor = this.state.descriptors[route.key]; if (descriptor) { - const { gesturesEnabled, animationEnabled } = descriptor.options; + const { gestureEnabled, animationEnabled } = descriptor.options; if (animationEnabled === false) { // When animation is disabled, also disable gestures @@ -187,8 +187,8 @@ class StackView extends React.Component { return false; } - return gesturesEnabled !== undefined - ? gesturesEnabled + return gestureEnabled !== undefined + ? gestureEnabled : Platform.OS !== 'android'; }