From 023b0990a91d31d4e4c80c48d7e0fddbbf3dbd90 Mon Sep 17 00:00:00 2001 From: Freddy Harris Date: Thu, 26 Oct 2017 15:59:34 +0200 Subject: [PATCH] Fix impossible to renderTitle in full width on ios (#2641) * Fix impossible to renderTitle in full width on ios * Fix test and add a test --- .../__tests__/StackNavigator-test.js | 14 ++ .../__snapshots__/StackNavigator-test.js.snap | 226 +++++++++++++++++- .../src/views/Header/Header.js | 7 + 3 files changed, 245 insertions(+), 2 deletions(-) diff --git a/packages/react-navigation/src/navigators/__tests__/StackNavigator-test.js b/packages/react-navigation/src/navigators/__tests__/StackNavigator-test.js index ca3775e1..aacfef83 100644 --- a/packages/react-navigation/src/navigators/__tests__/StackNavigator-test.js +++ b/packages/react-navigation/src/navigators/__tests__/StackNavigator-test.js @@ -30,4 +30,18 @@ describe('StackNavigator', () => { expect(rendered).toMatchSnapshot(); }); + + it('applies correct values when headerRight is present', () => { + const MyStackNavigator = StackNavigator({ + Home: { + screen: HomeScreen, + navigationOptions: { + headerRight: , + }, + }, + }); + const rendered = renderer.create().toJSON(); + + expect(rendered).toMatchSnapshot(); + }); }); diff --git a/packages/react-navigation/src/navigators/__tests__/__snapshots__/StackNavigator-test.js.snap b/packages/react-navigation/src/navigators/__tests__/__snapshots__/StackNavigator-test.js.snap index ee5782fe..7375570d 100644 --- a/packages/react-navigation/src/navigators/__tests__/__snapshots__/StackNavigator-test.js.snap +++ b/packages/react-navigation/src/navigators/__tests__/__snapshots__/StackNavigator-test.js.snap @@ -1,5 +1,227 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP +exports[`StackNavigator applies correct values when headerRight is present 1`] = ` + + + + + + + + + + + Welcome anonymous + + + + + + + + + + +`; + exports[`StackNavigator renders successfully 1`] = ` { if (!options.hasRightComponent) { style.right = 0; } + } else if ( + Platform.OS === 'ios' && + !options.hasLeftComponent && + !options.hasRightComponent + ) { + style.left = 0; + style.right = 0; } return this._renderSubView(