react-native

mirror of https://github.com/zhigang1992/react-native.git synced 2026-06-17 06:00:02 +08:00

Files

Albert Martin bca85101cd fix: prevent exception when imageName is null (#20120 )

Summary:
When an image source is parsed via `RCTImageFromLocalAssetURL` there seem to be certain situations in which `imageName` is empty from `RCTBundlePathForURL`. Any call to `UIImage imageNamed` with a an empty parameter will throw an exception:

```
CUICatalog: Invalid asset name supplied: '(null)'
```

In my case, the asset URL was pointing to an image in the application sandbox rather than the `NSBundle`. In this case `UIImage imageNamed` was throwing before the call to `NSData dataWithContentsOfURL` below could correctly resolve the image.

This change simply skips the call to `UIImage imageNamed` if no `imageName` value is set.
Pull Request resolved: https://github.com/facebook/react-native/pull/20120

Differential Revision: D14163101

Pulled By: cpojer

fbshipit-source-id: ceec95c02bf21b739962ef5618947a5726ba0473

2019-02-20 22:57:40 -08:00

Base

fix: prevent exception when imageName is null (#20120 )

2019-02-20 22:57:40 -08:00

CxxBridge

Allow compiler optimization (#23536 )

2019-02-20 17:29:35 -08:00

CxxModule

iOS downgrade invalid bridge warning (#23557 )

2019-02-20 19:07:36 -08:00

CxxUtils

Update copyright headers to yearless format