mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-01-12 22:50:10 +08:00
937c79e2f2
Summary: This PR expands the code analysis script to allow for customizing the GitHub Review left by analysis-bot whenever it finds code-level issues. Some, but not all, `eslint` errors are fixable by running `yarn lint --fix`. When the `eslint` converter finds warnings or errors, the bot will suggest running the command as part of the review. The script could be adjusted to only suggest this when `eslint` returns a non-zero `fixableErrorCount` or `fixableWarningCount`, but I think this is a good first step to get people to unblock themselves when they see this type of review from the bot. I've also excluded `bots/` and `scripts/` from eslint as these have several `eslint` errors that need to be addressed. These directories do not contain core RN code, so they can be excluded for now. [GENERAL] [Changed] - analysis-bot will suggest fixing eslint warnings on code reviews Pull Request resolved: https://github.com/facebook/react-native/pull/23413 Differential Revision: D14065757 Pulled By: cpojer fbshipit-source-id: cc588643f7ddb3c4631d89c26b799f7a7244e616