kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-08 18:23:13 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
9aa37e8fb2e58a987927356c3562497e4b2b02b6
react-native/Libraries/Components/RefreshControl
History
Janic Duplessis 9aa37e8fb2 Make RefreshControl properly controlled by JS 
Summary:
There was an issue with the way we made `RefreshControl` a controlled component when react doesn't render synchronously. This fixes the issue by using the same technique used in the commit 0cd2904b23 for`PickerAndroid`

**Test plan (required)**

Tested normal behaviour and tested that if not setting the `refreshing` prop to `true` during the `onRefresh` callback that the `RefreshControl` stops refreshing immediately. Also made sure that `setNativeProps` is only called if needed when the native refreshing state is not in sync with JS.

Fix #7414
Closes https://github.com/facebook/react-native/pull/7445

Differential Revision: D3274981

fb-gh-sync-id: a1b9d46329f552984e33d11fa0e29ad6da689511
fbshipit-source-id: a1b9d46329f552984e33d11fa0e29ad6da689511
2016-05-08 17:03:18 -07:00
..
RefreshControl.js
Make RefreshControl properly controlled by JS
2016-05-08 17:03:18 -07:00