mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-01-12 22:50:10 +08:00
Summary: Accidentally I noticed that the signature of Folly's hash_combine is different from boost's one. The Folly's one is: `size_t hash_combine(const T& t, const Ts&... ts)`, so the first argument is immutable and the method returns the result normally. It means that all hashes that we compute in Fabric using `hash_combine` were `0`. So I fixed it. I have no idea why this difference exists, but some modern papers suggest that folly's variant has good chances to be standardized. E.g.: http://open-std.org/JTC1/SC22/WG21/docs/papers/2017/p0814r0.pdf Technically, it should improve performance, but I doubt that it can be more than 1-2 ms per screen TTI. Reviewed By: JoshuaGross Differential Revision: D14430380 fbshipit-source-id: 97da999ee5780b940bb789bc3eb5bf9f89c194ca