mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-05 22:38:59 +08:00

Files

Denis Koroskin 88ebce0512 Fix RCTImageView always clipping to bounds even if overflow is visible

Summary: Previously, RCTImageView/DrawCommand would always clip for specific scale types (such as CENTER_CROP), but this is incorrect if we want to allow overflow: visible on RCTImageView (which iOS allows). This patch tweaks the clipping condition from paddingLeft/paddingTop < 0 (i.e. image wants to draw outside of its bounds) to actual image rect being outside of clip rect. Previously, that would mean exact same thing, but now that clip rect is aware of overflow: visible, it matters, allowing RCTImage to not clip when we want it to draw outside of the boundaries.

Reviewed By: ahmedre

Differential Revision: D2873350

2016-12-19 13:40:20 -08:00