react-native

mirror of https://github.com/zhigang1992/react-native.git synced 2026-06-17 04:39:16 +08:00

Files

Changnam Hong 5dd6908b25 Fix RCTJavaScriptLoader loadBundleAtURL error case (#23837 )

Summary:
Change the function called when an error is returned from the completionHandler of the `RCTJavaScriptLoader(loadBundleAtURL:onProgress:onComplete:)`.

* AS-IS
    - `RCTLogError()`
    - This error method does not post any notification for users. So users cannot receive notification when `RCTJavaScriptLoader(loadBundleAtURL:onProgress:onComplete:)` complete with error.(i.e. bundleURL is is invalid but not nil, `http://1`, `http://localho:8081/index.bundle`)

* TO-BE
    - `handleError(error:)`
    -  Call this method will post notification for users when `completionHandler` fails with error.

[iOS] [Fixed] - Change the function called when an error is returned from the completionHandler of the `RCTJavaScriptLoader(loadBundleAtURL:onProgress:onComplete:)`.
Pull Request resolved: https://github.com/facebook/react-native/pull/23837

Differential Revision: D14538790

Pulled By: cpojer

fbshipit-source-id: da3306904c0d8113d204edfaa0f9e2a23793981a

2019-03-20 04:53:24 -07:00

Base

Remove explicitly add png file extension when load local image (#23864 )

2019-03-18 23:03:32 -07:00

CxxBridge

Fix RCTJavaScriptLoader loadBundleAtURL error case (#23837 )

2019-03-20 04:53:24 -07:00

CxxModule

Silence Xcode warning (#23880 )

2019-03-12 22:08:21 -07:00

CxxUtils

Update copyright headers to yearless format