mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-06-13 00:58:02 +08:00
4dfdec9b28
Summary: Motivation: -------------- PR #20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` resulting in a warning message beeing displayed during an app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`. Pull Request resolved: https://github.com/facebook/react-native/pull/20853 Differential Revision: D9733888 Pulled By: hramos fbshipit-source-id: 22853480d7ba7be65e3387effda2fd6c72b6906a
53 lines
1.6 KiB
JavaScript
53 lines
1.6 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @emails oncall+javascript_foundation
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const makeBuildPatch = require('../../android/patches/makeBuildPatch');
|
|
const normalizeProjectName = require('../../android/patches/normalizeProjectName');
|
|
|
|
const name = 'test';
|
|
const scopedName = '@scoped/test';
|
|
const normalizedScopedName = normalizeProjectName('@scoped/test');
|
|
|
|
describe('makeBuildPatch', () => {
|
|
it('should build a patch function', () => {
|
|
expect(Object.prototype.toString(makeBuildPatch(name))).toBe(
|
|
'[object Object]',
|
|
);
|
|
});
|
|
|
|
it('should make a correct patch', () => {
|
|
const {patch} = makeBuildPatch(name);
|
|
expect(patch).toBe(` implementation project(':${name}')\n`);
|
|
});
|
|
|
|
it('should make a correct install check pattern', () => {
|
|
const {installPattern} = makeBuildPatch(name);
|
|
const match = `/\\s{4}(implementation)(\\(|\\s)(project)\\(\\':${name}\\'\\)(\\)|\\s)/`;
|
|
expect(installPattern.toString()).toBe(match);
|
|
});
|
|
});
|
|
|
|
describe('makeBuildPatchWithScopedPackage', () => {
|
|
it('should make a correct patch', () => {
|
|
const {patch} = makeBuildPatch(scopedName);
|
|
expect(patch).toBe(
|
|
` implementation project(':${normalizedScopedName}')\n`,
|
|
);
|
|
});
|
|
|
|
it('should make a correct install check pattern', () => {
|
|
const {installPattern} = makeBuildPatch(scopedName);
|
|
const match = `/\\s{4}(implementation)(\\(|\\s)(project)\\(\\':${normalizedScopedName}\\'\\)(\\)|\\s)/`;
|
|
expect(installPattern.toString()).toBe(match);
|
|
});
|
|
});
|