mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-04-08 17:46:35 +08:00
Summary:
I met the error `Native module xyz tried to override xyz for module name xyzModuleName. If this was your intention...` after something went wrong during `react-native link` - one module somehow ended up being included twice in the `getPackages` method, as in:
```java
Override
protected List<ReactPackage> getPackages() {
return Arrays.<ReactPackage>asList(
new MainReactPackage(),
new WowPackage(),
new WowPackage(),
```
Since I have > 20 native modules it took me a little while to find out what the problem was. The improved error message should make the problem clearer to anybody who may encounter it. I did try to refactor the code a little more, by extracting the whole part of:
```java
String name = moduleHolder.getName();
if (namesToType.containsKey(name)) {
Class<? extends NativeModule> existingNativeModule = namesToType.get(name);
if (!moduleHolder.getCanOverrideExistingModule()) {
throw new IllegalStateException(getModuleOverridingExceptionMessage(
type.getSimpleName(),
existingNativeModule.getSimpleName(),
name
));
}
mModules.remove(existingNativeModule);
}
namesToType.put(name, type);
mModules.put(type, moduleHolder);
```
out into a separate method since there were two places where nearly identical code was written.
I have built RN from source and used it in a very simple app with RN vector icons (the package creates a native module as can be seen [here](https://github.com/oblador/react-native-vector-icons/blob/master/android/src/main/java/com/oblador/vectoricons/VectorIconsPackage.java#L19)).
After including the module twice, ie.
```java
Override
protected List<ReactPackage> getPackages() {
return Arrays.<ReactPackage>asList(
new MainReactPackage(),
new VectorIconsPackage(),
new VectorIconsPackage()
);
}
```
I get the improved error description, as seen in the screenshot.
<img src="https://user-images.githubusercontent.com/1566403/36340960-3289d9d0-13e7-11e8-8d17-e1651da17841.png" height="500">
[ANDROID] [MINOR] [NativeModuleRegistryBuilder] - Improve error message and refactor putting native modules to module maps
Closes https://github.com/facebook/react-native/pull/16402
Differential Revision: D8421392
Pulled By: hramos
fbshipit-source-id: 719bd37b4681933d35858621b402ae73dd460a5b
144 lines
5.8 KiB
Java
144 lines
5.8 KiB
Java
// Copyright (c) 2004-present, Facebook, Inc.
|
|
|
|
// This source code is licensed under the MIT license found in the
|
|
// LICENSE file in the root directory of this source tree.
|
|
|
|
package com.facebook.react;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.HashMap;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
|
|
import com.facebook.common.logging.FLog;
|
|
import com.facebook.react.bridge.BaseJavaModule;
|
|
import com.facebook.react.bridge.ModuleSpec;
|
|
import com.facebook.react.bridge.ModuleHolder;
|
|
import com.facebook.react.bridge.NativeModule;
|
|
import com.facebook.react.bridge.NativeModuleRegistry;
|
|
import com.facebook.react.bridge.OnBatchCompleteListener;
|
|
import com.facebook.react.bridge.ReactApplicationContext;
|
|
import com.facebook.react.bridge.ReactMarker;
|
|
import com.facebook.react.bridge.ReactMarkerConstants;
|
|
import com.facebook.react.common.ReactConstants;
|
|
import com.facebook.react.module.model.ReactModuleInfo;
|
|
|
|
/**
|
|
* Helper class to build NativeModuleRegistry.
|
|
*/
|
|
public class NativeModuleRegistryBuilder {
|
|
|
|
private final ReactApplicationContext mReactApplicationContext;
|
|
private final ReactInstanceManager mReactInstanceManager;
|
|
private final boolean mLazyNativeModulesEnabled;
|
|
|
|
private final Map<Class<? extends NativeModule>, ModuleHolder> mModules = new HashMap<>();
|
|
private final Map<String, Class<? extends NativeModule>> namesToType = new HashMap<>();
|
|
|
|
public NativeModuleRegistryBuilder(
|
|
ReactApplicationContext reactApplicationContext,
|
|
ReactInstanceManager reactInstanceManager,
|
|
boolean lazyNativeModulesEnabled) {
|
|
mReactApplicationContext = reactApplicationContext;
|
|
mReactInstanceManager = reactInstanceManager;
|
|
mLazyNativeModulesEnabled = lazyNativeModulesEnabled;
|
|
}
|
|
|
|
public void processPackage(ReactPackage reactPackage) {
|
|
if (mLazyNativeModulesEnabled) {
|
|
if (!(reactPackage instanceof LazyReactPackage)) {
|
|
throw new IllegalStateException("Lazy native modules requires all ReactPackage to " +
|
|
"inherit from LazyReactPackage");
|
|
}
|
|
|
|
LazyReactPackage lazyReactPackage = (LazyReactPackage) reactPackage;
|
|
List<ModuleSpec> moduleSpecs = lazyReactPackage.getNativeModules(mReactApplicationContext);
|
|
Map<Class, ReactModuleInfo> reactModuleInfoMap = lazyReactPackage.getReactModuleInfoProvider()
|
|
.getReactModuleInfos();
|
|
|
|
for (ModuleSpec moduleSpec : moduleSpecs) {
|
|
Class<? extends NativeModule> type = moduleSpec.getType();
|
|
ReactModuleInfo reactModuleInfo = reactModuleInfoMap.get(type);
|
|
ModuleHolder moduleHolder;
|
|
if (reactModuleInfo == null) {
|
|
if (BaseJavaModule.class.isAssignableFrom(type)) {
|
|
throw new IllegalStateException("Native Java module " + type.getSimpleName() +
|
|
" should be annotated with @ReactModule and added to a @ReactModuleList.");
|
|
}
|
|
NativeModule module;
|
|
ReactMarker.logMarker(
|
|
ReactMarkerConstants.CREATE_MODULE_START,
|
|
moduleSpec.getType().getName());
|
|
try {
|
|
module = moduleSpec.getProvider().get();
|
|
} finally {
|
|
ReactMarker.logMarker(ReactMarkerConstants.CREATE_MODULE_END);
|
|
}
|
|
moduleHolder = new ModuleHolder(module);
|
|
} else {
|
|
moduleHolder = new ModuleHolder(reactModuleInfo, moduleSpec.getProvider());
|
|
}
|
|
|
|
String name = moduleHolder.getName();
|
|
putModuleTypeAndHolderToModuleMaps(type, name, moduleHolder);
|
|
}
|
|
} else {
|
|
FLog.d(
|
|
ReactConstants.TAG,
|
|
reactPackage.getClass().getSimpleName() +
|
|
" is not a LazyReactPackage, falling back to old version.");
|
|
List<NativeModule> nativeModules;
|
|
if (reactPackage instanceof ReactInstancePackage) {
|
|
ReactInstancePackage reactInstancePackage = (ReactInstancePackage) reactPackage;
|
|
nativeModules = reactInstancePackage.createNativeModules(
|
|
mReactApplicationContext,
|
|
mReactInstanceManager);
|
|
} else {
|
|
nativeModules = reactPackage.createNativeModules(mReactApplicationContext);
|
|
}
|
|
for (NativeModule nativeModule : nativeModules) {
|
|
addNativeModule(nativeModule);
|
|
}
|
|
}
|
|
}
|
|
|
|
public void addNativeModule(NativeModule nativeModule) {
|
|
String name = nativeModule.getName();
|
|
Class<? extends NativeModule> type = nativeModule.getClass();
|
|
putModuleTypeAndHolderToModuleMaps(type, name, new ModuleHolder(nativeModule));
|
|
}
|
|
|
|
private void putModuleTypeAndHolderToModuleMaps(Class<? extends NativeModule> type, String underName,
|
|
ModuleHolder moduleHolder) throws IllegalStateException {
|
|
if (namesToType.containsKey(underName)) {
|
|
Class<? extends NativeModule> existingNativeModule = namesToType.get(underName);
|
|
if (!moduleHolder.getCanOverrideExistingModule()) {
|
|
throw new IllegalStateException("Native module " + type.getSimpleName() +
|
|
" tried to override " + existingNativeModule.getSimpleName() + " for module name " +
|
|
underName + ". Check the getPackages() method in MainApplication.java, it might be " +
|
|
"that module is being created twice. " +
|
|
"If this was your intention, set canOverrideExistingModule=true");
|
|
}
|
|
|
|
mModules.remove(existingNativeModule);
|
|
}
|
|
|
|
namesToType.put(underName, type);
|
|
mModules.put(type, moduleHolder);
|
|
}
|
|
|
|
public NativeModuleRegistry build() {
|
|
ArrayList<ModuleHolder> batchCompleteListenerModules = new ArrayList<>();
|
|
for (Map.Entry<Class<? extends NativeModule>, ModuleHolder> entry : mModules.entrySet()) {
|
|
if (OnBatchCompleteListener.class.isAssignableFrom(entry.getKey())) {
|
|
batchCompleteListenerModules.add(entry.getValue());
|
|
}
|
|
}
|
|
|
|
return new NativeModuleRegistry(
|
|
mReactApplicationContext,
|
|
mModules,
|
|
batchCompleteListenerModules);
|
|
}
|
|
}
|