mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-04-03 22:48:25 +08:00
Summary: Some nodes have a value of NaN initially so if we assign the value of the input in the constructor it is possible we get NaN as a value and then it will break when trying to update the value. Initializing at 0 is actually fine with this node since it will get updated properly in the `update` method. **Test plan** Tested in an app that uses native animated diffclamp where I noticed the issue. Made sure this change fixed it. Closes https://github.com/facebook/react-native/pull/12279 Differential Revision: D4527866 fbshipit-source-id: add3fc0d86ffcf4ddcd01ff3251f2373eeaa2cf5
54 lines
1.6 KiB
Java
54 lines
1.6 KiB
Java
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
package com.facebook.react.animated;
|
|
|
|
import com.facebook.react.bridge.JSApplicationCausedNativeException;
|
|
import com.facebook.react.bridge.ReadableMap;
|
|
|
|
/*package*/ class DiffClampAnimatedNode extends ValueAnimatedNode {
|
|
private final NativeAnimatedNodesManager mNativeAnimatedNodesManager;
|
|
private final int mInputNodeTag;
|
|
private final double mMin;
|
|
private final double mMax;
|
|
|
|
private double mLastValue;
|
|
|
|
public DiffClampAnimatedNode(
|
|
ReadableMap config,
|
|
NativeAnimatedNodesManager nativeAnimatedNodesManager) {
|
|
mNativeAnimatedNodesManager = nativeAnimatedNodesManager;
|
|
mInputNodeTag = config.getInt("input");
|
|
mMin = config.getDouble("min");
|
|
mMax = config.getDouble("max");
|
|
|
|
mValue = mLastValue = 0;
|
|
}
|
|
|
|
@Override
|
|
public void update() {
|
|
double value = getInputNodeValue();
|
|
|
|
double diff = value - mLastValue;
|
|
mLastValue = value;
|
|
mValue = Math.min(Math.max(mValue + diff, mMin), mMax);
|
|
}
|
|
|
|
private double getInputNodeValue() {
|
|
AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNodeTag);
|
|
if (animatedNode == null || !(animatedNode instanceof ValueAnimatedNode)) {
|
|
throw new JSApplicationCausedNativeException("Illegal node ID set as an input for " +
|
|
"Animated.DiffClamp node");
|
|
|
|
}
|
|
|
|
return ((ValueAnimatedNode) animatedNode).getValue();
|
|
}
|
|
}
|