2 Commits

Author	SHA1	Message	Date
zhongwuzw	12d58d431a	Update rncore podspec to exclude codegen test files (#24513) ... Summary: Related bddd9c7d59. Exclude these tests files from podspec. cc. cpojer [iOS] [Fixed] - Update rncore podspec to exclude codegen test files Pull Request resolved: https://github.com/facebook/react-native/pull/24513 Differential Revision: D14996897 Pulled By: rickhanlonii fbshipit-source-id: 28b29f24f482ed678f15c44c5c579ced97ea651f	2019-04-18 09:30:51 -07:00
ericlewis	97e6ea1371	Fabric: working podspecs & works in RNTester (#23803) ... Summary: This is the couple of hacks I used after I finished #23802 in order to get fabric working on RNTester. This is inspired from prior work by kmagiera. The goal of this PR is to show others what I’m struggling with, and to eventually merge it sans hacks. - Yarn Install - Uncomment the commented out pods in RNTester's pod file - Open RNTesterPods workspace - Run App - this is only for pods, the non-pod RNTester will no longer work until updated with fabric too. - `SurfaceHostingView` & `SurfaceHostingProxyRootView` both try to start the surface immediately, this leads to a race condition due to the javascript not having loaded yet, the hack here is: 1. Swizzle the `start` method on `RCTFabricSurface` to no-op when called. 2. Add observer for `RCTJavaScriptDidLoadNotification` 3. Call private method `_startAllSurfaces` on `_surfacePresenter` in AppDelegate when we receive `RCTJavaScriptDidLoadNotification`. [General] [Added] - Use Fabric in RNTester Pull Request resolved: https://github.com/facebook/react-native/pull/23803 Reviewed By: shergin, mdvacca Differential Revision: D14450726 Pulled By: fkgozali fbshipit-source-id: 8ae2d48634fecb60db539aaf0a2c89ba1f572c27	2019-03-15 23:59:22 -07:00