Dmitry Zakharov
a5550a56ea
Introduce getConstants generation for Native Modules codegen.
...
Reviewed By: fkgozali
Differential Revision: D6125394
fbshipit-source-id: 13b48c75056868f45394f277d75fb05d167f1c9f
2017-10-30 08:16:48 -07:00
Alexey Lang
9742bcb4ba
Remove quicklog
...
Reviewed By: AaaChiuuu
Differential Revision: D6172832
fbshipit-source-id: d239ce8bef0918d3e90662258b6eabe3502f4897
2017-10-30 08:12:34 -07:00
David Vacca
c278020633
Fixing RTL HorizontalScrolling in Android
...
Reviewed By: astreet
Differential Revision: D6170631
fbshipit-source-id: 254e6ed9a4d6e42b6d1215de1ff63aedb2c07a0a
2017-10-27 12:34:10 -07:00
Jonathan Keljo
dd016f334c
Automated fixups for Instagram
...
Reviewed By: dreiss
Differential Revision: D6168048
fbshipit-source-id: 0e51319d93fd697db01ea3933f48cd06a6ffac12
2017-10-27 00:52:40 -07:00
Andrew Chen (Eng)
9b6f160c04
Revert D5638458: Fixing RTL HorizontalScrolling in Android
...
Differential Revision: D5638458
fbshipit-source-id: f4474a12821cd2c20f57ce3bac5996c327ceaa33
2017-10-26 15:33:10 -07:00
David Vacca
36c951d24f
Fixing RTL HorizontalScrolling in Android
...
Reviewed By: astreet
Differential Revision: D5638458
fbshipit-source-id: 08a5070a362eb43e12140cc204172d0950a1b720
2017-10-26 11:25:22 -07:00
Charles Dick
1c104310fb
RN catalyst instance destroy markers
...
Reviewed By: alexeylang
Differential Revision: D6109891
fbshipit-source-id: 2cd1491381220a80f71f9ab205a2c6a309ed35ae
2017-10-26 10:28:41 -07:00
Dmitry Zakharov
f0fb720eaa
Introduce mobile config flag to load classes for View Managers
...
Reviewed By: kathryngray
Differential Revision: D6148468
fbshipit-source-id: d0f919f63922dae4b0720f22fa70ab4a7f67b48a
2017-10-26 08:51:11 -07:00
Ramanpreet Nara
efa4d3c222
Rename I18nManager Left/Right swap methods
...
Reviewed By: fkgozali
Differential Revision: D6140072
fbshipit-source-id: 282dc614c036de8f217a729f21a1bbe92b8afd7d
2017-10-24 20:45:59 -07:00
Andrew Chen (Eng)
90a42396b9
React native shadow tree sonar plugin
...
Reviewed By: emilsjolander
Differential Revision: D6050845
fbshipit-source-id: 8c041b26ed4eb701830f1aced73d996c71cb3326
2017-10-24 18:34:40 -07:00
Rafael Magalhães
ce967c6fbe
Requesting permission results into ArrayIndexOutOfBoundsException
...
Summary:
Reported in Issue #15928
Fixing bug when permission showing dialog and user go to home and re-open minimized app.
1. Ask for permission
2. Minimize app (Press HomeButton)
3. Open app again via shortcut
[ANDROID] [BUGFIX] [PermissionsModule.java] - Fixed bug when asked for permission Cause: java.lang.ArrayIndexOutOfBoundsException · length=0; index=0
Closes https://github.com/facebook/react-native/pull/16507
Differential Revision: D6133708
Pulled By: shergin
fbshipit-source-id: 9c05d1d5d16fedf718ad5113df69a4df3af62013
2017-10-23 23:30:08 -07:00
Jonathan Keljo
18364e95b7
Export deps to be source-ABI friendly
...
Reviewed By: dreiss
Differential Revision: D6124559
fbshipit-source-id: f831196724f8e171b86c58af5d2ed7944ecf6b6b
2017-10-23 12:22:53 -07:00
Alexey Lang
95073f8589
Use ReactMarker for all perf logging in the bridge
...
Reviewed By: AaaChiuuu
Differential Revision: D6030270
fbshipit-source-id: c9fa04d4f2816e4e0a4a14caf41795d0f547a7a0
2017-10-22 04:04:42 -07:00
Tao Huang
7e0b7ef8d0
Fix wrong error code when location service is turned off on Android device
...
Reviewed By: achen1
Differential Revision: D6106890
fbshipit-source-id: ab6ccdc2625745e4bbcdb0d7fe284de504d09641
2017-10-19 19:52:57 -07:00
Ramanpreet Nara
99d294bf3d
Consider negative border radii and widths invalid
...
Reviewed By: achen1
Differential Revision: D5998369
fbshipit-source-id: d54302777f4eeb13f4521800130c17ac07f1b354
2017-10-19 18:08:25 -07:00
Ramanpreet Nara
00c9c1ad74
Implement direction-aware border clipping
...
Reviewed By: achen1
Differential Revision: D6015812
fbshipit-source-id: 406ddb12884a1c490cee784c6ef42322bd497b24
2017-10-18 19:33:33 -07:00
Ramanpreet Nara
875f273dba
Implement border(Start|End)Color for rounded borders
...
Reviewed By: achen1
Differential Revision: D6014637
fbshipit-source-id: 33c10ec1f84075e0bb1c1f529aa7231497028380
2017-10-18 19:33:33 -07:00
Ramanpreet Nara
38c2c26d90
Implement rounded border(Start|End)Width
...
Reviewed By: achen1
Differential Revision: D6013412
fbshipit-source-id: e7aa7a3cd9e3ed72b25664efee59e42792098fbd
2017-10-18 19:33:33 -07:00
Ramanpreet Nara
1a7abcf526
Android: Implement border(Top|Bottom)(Start|End)Radius for RN
...
Reviewed By: achen1
Differential Revision: D5924734
fbshipit-source-id: 24759326064c11d2cd8948c7a710376ca9f41c63
2017-10-18 19:33:32 -07:00
Ramanpreet Nara
0f467a25ed
Android: Implement border(Start|End)Color for RN non-rounded borders
...
Reviewed By: achen1
Differential Revision: D5921865
fbshipit-source-id: ed964291cba0c701de677c24c54f885cda78e7cc
2017-10-18 19:33:32 -07:00
Ramanpreet Nara
7ed7593b2b
Android: Implement border(Start|End)Width for non-rounded borders
...
Reviewed By: achen1
Differential Revision: D5917755
fbshipit-source-id: 3ec0ab1a1e191f5f6fd956691995e95937a513cc
2017-10-18 19:33:32 -07:00
Ramanpreet Nara
04a8c62313
Android: Implement margin(Start|End) styles for RN
...
Reviewed By: achen1
Differential Revision: D5907651
fbshipit-source-id: 4df7583483e6f10b5433b9fa9d9345e00ccedd20
2017-10-18 19:33:32 -07:00
Ramanpreet Nara
1ed08d3c01
Android: Implement padding(Start|End) styles for RN
...
Reviewed By: AaaChiuuu
Differential Revision: D5907207
fbshipit-source-id: c9bb322f94d701463be35fb1ca92aab80f47d8ab
2017-10-18 19:33:31 -07:00
Ramanpreet Nara
dc92e69867
Android: Forward RN start/end styles to Yoga
...
Reviewed By: AaaChiuuu
Differential Revision: D5906097
fbshipit-source-id: 79bd43ea54572eb612e781628551bccf5a4f948d
2017-10-18 19:33:31 -07:00
Ramanpreet Nara
98547d4bcf
Implement gating support for direction-aware API changes
...
Reviewed By: achen1
Differential Revision: D6045083
fbshipit-source-id: 857a43029ad88d2324ec77145a1e30d92b5e8fae
2017-10-18 19:33:31 -07:00
Ramanpreet Nara
f7888310d4
Implement border(Left|Right|Top|Bottom)Color for rounded borders
...
Reviewed By: achen1
Differential Revision: D6009609
fbshipit-source-id: 6a247a14aa48ac2edc637bf064216407a3a9a81f
2017-10-18 19:33:30 -07:00
Ramanpreet Nara
4994d6a389
Implement partial rounded borders
...
Reviewed By: achen1
Differential Revision: D5982241
fbshipit-source-id: 2f694daca7e1b16b5ff65f07c7d15dd558a4b7e8
2017-10-18 19:33:30 -07:00
Ramanpreet Nara
de313f6fdd
Fix border clipping
...
Reviewed By: achen1
Differential Revision: D5992045
fbshipit-source-id: fccd864dbc24592c3cd4df7300aca5096537e1d8
2017-10-18 19:33:30 -07:00
Alexey Lang
52a67db629
Fix Systrace section for Lazy View Managers
...
Differential Revision: D6088310
fbshipit-source-id: cf14c9cc91068cfabf4e7c1bbae5df7f25e0ced3
2017-10-18 12:18:12 -07:00
Andrew Chen (Eng)
91372e8f9a
Add callback for UIImplementation layout updates
...
Differential Revision: D6063839
fbshipit-source-id: ae08fd2fc6c6365813b8077efe14990a0355a5c7
2017-10-17 07:47:12 -07:00
Andrew Chen (Eng)
dc16150bae
Expose ReactInstanceManager from ReactRootView
...
Reviewed By: AaaChiuuu
Differential Revision: D6051991
fbshipit-source-id: f175fc273895d7e9fedec73428d61395ae00649f
2017-10-17 04:31:03 -07:00
Max Sherman
f3b117abd0
Un-revert logMarker for hermes diff
...
Reviewed By: mhorowitz
Differential Revision: D6051880
fbshipit-source-id: 0ce4bbed9ba8579033ee5397ff6c0975b6886fb1
2017-10-13 14:01:43 -07:00
Max Sherman
e60a2d0a53
Revert D5939688: [hermes][rn] Share logPerfMarker with hermes
...
Differential Revision: D5939688
fbshipit-source-id: 37daeeaa01144472c26383106c88dd49bb99a37b
2017-10-12 19:21:42 -07:00
Max Sherman
fe62da34a6
Share logPerfMarker with hermes
...
Reviewed By: mhorowitz
Differential Revision: D5939688
fbshipit-source-id: ab6a86eb66a3d9501b9b5a55b562b277b5ab0620
2017-10-12 15:33:04 -07:00
Janic Duplessis
2b4ff6ea19
Native Animated - Restore default values when removing props on Android
...
Summary:
Rebased version of #12842 that was reverted because of failing fb internal tests.
Closes https://github.com/facebook/react-native/pull/15919
Differential Revision: D5823956
Pulled By: hramos
fbshipit-source-id: 4ece19a403f5ebbe4829c4c26696ea0575ab1d0e
2017-10-12 13:11:00 -07:00
Valentin Shergin
f2c6877b91
Fixed crash on attempt to update local data of deallocated shadow node
...
Summary:
Trivial.
That's okay that sometimes shadowNodes and views hierarchies have lack of synchonization.
Reviewed By: sahrens
Differential Revision: D6040022
fbshipit-source-id: 6b49a82317b620b66a87441719fddcafb1f27934
2017-10-12 09:46:29 -07:00
Michael Lee
7997a2b749
Fix platform flags to also check for linux
...
Reviewed By: danzimm
Differential Revision: D6036995
fbshipit-source-id: 98d7f19eb80b72090b26252864a6bd41a3295462
2017-10-12 09:16:40 -07:00
Peter Ruibal
752b68857c
Add visible-password for TextInput.keyboardType on Android
...
Summary:
`visible-password` represents a very basic keyboard, typically only
letters and numbers. Backed by InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD,
it is useful for things like password and code entry fields. It can also be more
effective than autoCorrect={false} for disabling autocompletion on some keyboards
(like Gboard).
Note `secureTextEntry` also affects `TYPE_TEXT_VARIATION_*` flags internally, so there
may be some undefined behavior when combining `secureTextEntry` with
`keyboardType="visible-password"`
Also, while here, improve the documentation on TextInput to explicitly enumerate
which keyboardType applies to Android vs. iOS (since this is the first android-specific)
Reviewed By: shergin
Differential Revision: D6005353
fbshipit-source-id: 13af90c96353f714c0e106dd0fde90184a476533
2017-10-10 18:18:34 -07:00
Dmitry Zakharov
ca834f96af
Fix scrolling events for RN.
...
Reviewed By: bvaughn
Differential Revision: D6020664
fbshipit-source-id: c9fb9069e9dcde298901ba2c03bacc8b646844d0
2017-10-10 11:08:40 -07:00
Nivetha Singara Vadivelu
9424cd7e8f
Handling exceptions in video player
...
Reviewed By: furdei
Differential Revision: D5958119
fbshipit-source-id: 79b431a8422d60134890d44e99c358a07a5adc5b
2017-10-09 22:45:48 -07:00
Janis Peisenieks
7a7bdeec3e
Omit all line terminators for ImageStore.getBase64ForTag
...
Summary:
FIX #11142
This fixes #11142 and supersedes #11155 as I was unsure how to add/change commits in that PR.
Wrote up a bunch of unit tests for the ImageStore module. The added tests showed that there was indeed a problem with the flags used for the Base64OutputStream, and they also show that that has been fixed now.
Closes https://github.com/facebook/react-native/pull/13856
Differential Revision: D6017764
Pulled By: shergin
fbshipit-source-id: adf667dc722ddfe31449afd8cd20a0a192eacff6
2017-10-09 22:16:20 -07:00
Janic Duplessis
0cd69e8a02
Run eslint --fix
...
Summary:
CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable.
**Test plan**
Quick manual test, cosmetic changes only.
Closes https://github.com/facebook/react-native/pull/16229
Differential Revision: D6009748
Pulled By: TheSavior
fbshipit-source-id: cabd44fed99dd90bd0b35626492719c139c89f34
2017-10-09 17:46:44 -07:00
Yann Pringault
1c24440644
Add TimePicker modes
...
Summary:
In the spirit of #10932 , I added the `mode` option to the `TimePicker` Android API.
There is only one mode available for **Android < 5**, the `spinner` one.
If we are on **Android >= 5** we can choose between `spinner` or `clock`. If we specify `default` it will use the default of the current Android version.
On **Android < 5**, whatever we choose it will be this:

On **Android >= 5**, with the `spinner` mode:

And with the `clock` mode, the default:

Closes https://github.com/facebook/react-native/pull/12384
Differential Revision: D6006689
Pulled By: hramos
fbshipit-source-id: fcd37c867c4061b9982b1687f2c10211e54df7cf
2017-10-08 12:38:45 -07:00
Max Sherman
790eabcdff
Replace getInt with asInt in native collections
...
Reviewed By: mhorowitz
Differential Revision: D5904751
fbshipit-source-id: 995412196fd76ea60a65253719e49852322be6e6
2017-10-05 10:07:24 -07:00
Alex Dvornikov
9e01d72103
Unify supplimentary bundle path creation logic between Android and iOS
...
Differential Revision: D5941546
fbshipit-source-id: c9b8fab887f480faa373c26a1d5ba310e8acde78
2017-10-04 15:16:27 -07:00
Alexey Lang
adde2ed5e9
Fix the debug logging regression
...
Reviewed By: AaaChiuuu
Differential Revision: D5975880
fbshipit-source-id: 39c632ddf84e57c814b54fac465651120e4127da
2017-10-04 15:04:53 -07:00
Ram N
0c234c90a2
Add error customizer for React Native Android
...
Reviewed By: achen1
Differential Revision: D5954205
fbshipit-source-id: 8b92bf1484a037b333a6f0f4aeddd39ffee25361
2017-10-04 14:06:35 -07:00
Andrew Chen (Eng)
7677af1d10
Litho UIImplementation
...
Reviewed By: marco-cova
Differential Revision: D5880274
fbshipit-source-id: e6741579d3de6090dea8d26cd07241d57adba84d
2017-10-04 08:31:04 -07:00
Paco Estevez Garcia
ef2e29f54c
Move URL escaping to Inspector layer
...
Reviewed By: Hypuk
Differential Revision: D5967544
fbshipit-source-id: d741e6324aff7583778cb13c862505b61ca02a3d
2017-10-04 03:51:33 -07:00
Karl Tarvas
59d9f8ca5e
Fix Android 4.1-4.3 WebView source baseUrl bug
...
Summary:
Resolves https://github.com/facebook/react-native/issues/11753 and https://github.com/facebook/react-native/issues/9835 .
Android versions 4.1-4.3 don't understand the MIME type `text/html; charset=utf-8` and default to `text/plain` instead, rendering the content as an unparsed HTML string. Since the encoding is already set and passed separately, removing it from the MIME type has no negative effects.
The same fix has already been discussed, successfully tested and incorporated in https://github.com/NativeScript/NativeScript/issues/1038 .
Closes https://github.com/facebook/react-native/pull/13789
Differential Revision: D5971910
Pulled By: shergin
fbshipit-source-id: 07795bdf0f13ddb1e8eec779d1cad59244f3687e
2017-10-03 18:51:57 -07:00