Héctor Ramos
c8efa32c6a
Fix GitHub path
2016-08-02 14:25:54 -07:00
Héctor Ramos
3876b0cd53
Review feedback. Restore View on GitHub headers for each example in the Components autodocs.
2016-08-02 14:23:59 -07:00
Héctor Ramos
0acbc2f4b9
Rename Edit on GitHub to View on GitHub
2016-08-01 14:30:27 -07:00
Milan Pavlik
0fab691e6f
Remove default argument syntax on getVersionedGithubPath()
...
Summary:
Removes ES6 syntax of default arguments to fix website building as per #7434 . [More info](https://github.com/facebook/react-native/pull/7434 ).
Closes https://github.com/facebook/react-native/pull/7439
Differential Revision: D3274206
fb-gh-sync-id: 3a8f5950ead91cf59c27fd384e97bf9587005398
fbshipit-source-id: 3a8f5950ead91cf59c27fd384e97bf9587005398
2016-05-07 14:10:33 -07:00
Milan Pavlik
1d101f4236
Add versions to GitHub source links in documentation. #7428
...
Summary:
Documentation references to source code on GitHub should point to their respective versions in order to avoid confusion and prevent broken links when the master branch differs from the currently viewed version. [More details](https://github.com/facebook/react-native/issues/7428 )
Originally links pointed to a hardcoded master branch on GitHub. The change augments the GitHub url to point to a respective branch of the code. The new urls are as follows:
next: `https://github.com/facebook/react-native/blob/master/ <path>`
stable: `https://github.com/facebook/react-native/blob/0.25-stable/ <path>`
The website module currently does not have a unit test setup. As a result, I performed the following tests:
1. Start the server with `RN_VERSION=next` and verified all links point to _master_
<img width="945" alt="screen shot 2016-05-07 at 14 10 58" src="https://cloud.githubusercontent.com/assets/1419286/15092307/ee66fb32-145d-11e6-92a0-d03169e517c2.png ">
2. Start the server
Closes https://github.com/facebook/react-native/pull/7434
Differential Revision: D3274000
Pulled By: vjeux
fb-gh-sync-id: 70d766984d6b0835f0a18928d6831fd2c82b6c7b
fbshipit-source-id: 70d766984d6b0835f0a18928d6831fd2c82b6c7b
2016-05-07 08:36:21 -07:00
Christopher Chedeau
3fbd46c6d9
Cleanup Edit with GitHub
...
Summary:
- Now using a table layout. While having the link inside of the header worked well in the browser, the search API would put "Edit in GitHub" as part of the title -_-
- Instead of putting the link inside of every section like Props, put it on the page header. This makes it less repetetitive and also works on API pages where the link was absent before
- Remove "Run this example" link as there's a giant Run this example sidebar already.
Closes https://github.com/facebook/react-native/pull/5643
Reviewed By: svcscm
Differential Revision: D2883989
Pulled By: vjeux
fb-gh-sync-id: e810e1677d5130692997dd301d6d59cfe04b948f
2016-01-30 23:02:36 -08:00
