From fff43614aa5185e9815a0b42ab2c1d8299ce1fc7 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Thu, 5 Jul 2018 13:59:44 -0700 Subject: [PATCH] android: disable `setClipChildren(false)` until RN ART issue is resolved Summary: It looks like for some reason when ReactViewGroup uses setClipChildren(false), the ReactNativeARTSurface no longer redraws when its width is expanded. Disable this new overflow behavior until the underlying issue is fixed. Reviewed By: achen1 Differential Revision: D8739003 fbshipit-source-id: ffae0e3eb0cd8ce385eae33a87b5ba0325cae3c4 --- .../java/com/facebook/react/views/view/ReactViewGroup.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java index e8afaa935..f3942754e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java @@ -51,8 +51,9 @@ public class ReactViewGroup extends ViewGroup implements /** * Kill switch to make overflow hidden by default. This flag will eventually be removed. + * TODO (T31096050): Sets this back to `false` until ReactNativeARTSurface issue is resolved. */ - public static boolean sDefaultOverflowHidden; + public static boolean sDefaultOverflowHidden = true; private static final int ARRAY_CAPACITY_INCREMENT = 12; private static final int DEFAULT_BACKGROUND_COLOR = Color.TRANSPARENT;