From ff588b5087986de5d073ec3c7e85eb702f7481e7 Mon Sep 17 00:00:00 2001 From: empyrical Date: Wed, 20 Feb 2019 10:09:10 -0800 Subject: [PATCH] JSI: Minor tweaks for building on MSVC (#23492) Summary: This is a re-submit of #23367, which was accidentally over-written in this commit: https://github.com/facebook/react-native/commit/0d7faf6f73b942126e1f45016cde8fd480fd0164 This pull request makes this change to `jsi.h`: * Tweak the call to constructor `Pointer(Runtime::PointerValue* ptr)` in the constructor for `PropNameID`. I am not sure why MSVC wasn't working with the original version, but it compiles after I tweak that. [General] [Fixed] - Tweaked `jsi.h` to build on MSVC Pull Request resolved: https://github.com/facebook/react-native/pull/23492 Differential Revision: D14151511 Pulled By: hramos fbshipit-source-id: 52d726d7b978d321a0343566ee527f2ec25e93f8 --- ReactCommon/jsi/jsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactCommon/jsi/jsi.h b/ReactCommon/jsi/jsi.h index bb2759f03..daa401ff1 100644 --- a/ReactCommon/jsi/jsi.h +++ b/ReactCommon/jsi/jsi.h @@ -336,7 +336,7 @@ class PropNameID : public Pointer { using Pointer::Pointer; PropNameID(Runtime& runtime, const PropNameID& other) - : PropNameID(runtime.clonePropNameID(other.ptr_)) {} + : Pointer(runtime.clonePropNameID(other.ptr_)) {} PropNameID(PropNameID&& other) = default; PropNameID& operator=(PropNameID&& other) = default;