From fedc002c21fc4d01b3698e9390d968661ccc7801 Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Wed, 16 Aug 2017 00:45:26 -0700 Subject: [PATCH] Use offset adjusted value in ModulusAnimatedNode Summary: Modulus animation computation should use the value adjusted for offset, not the raw value. See the JS implementation here: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/AnimatedImplementation.js#L1338 cc ryangomba Closes https://github.com/facebook/react-native/pull/15502 Differential Revision: D5638901 Pulled By: shergin fbshipit-source-id: cbf47bd4082897a969e2e561ec090366884a8349 --- .../java/com/facebook/react/animated/ModulusAnimatedNode.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java index 102ff1200..11fa7fc27 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java @@ -31,7 +31,7 @@ import com.facebook.react.bridge.ReadableMap; public void update() { AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNode); if (animatedNode != null && animatedNode instanceof ValueAnimatedNode) { - mValue = ((ValueAnimatedNode) animatedNode).mValue % mModulus; + mValue = ((ValueAnimatedNode) animatedNode).getValue() % mModulus; } else { throw new JSApplicationCausedNativeException("Illegal node ID set as an input for " + "Animated.modulus node");