From f59140eb210b6f79f567a0151cc2c21e8abe2f0b Mon Sep 17 00:00:00 2001 From: Greg McGary Date: Thu, 7 Dec 2017 13:18:16 -0800 Subject: [PATCH] Use clang-5.0 -Oz Reviewed By: mzlee Differential Revision: D6155682 fbshipit-source-id: 2f64e742f4dc44be171274c2ad0a41fb1e7079d7 --- ReactCommon/yoga/yoga/Yoga.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ReactCommon/yoga/yoga/Yoga.cpp b/ReactCommon/yoga/yoga/Yoga.cpp index fb0388d25..5bb0df89d 100644 --- a/ReactCommon/yoga/yoga/Yoga.cpp +++ b/ReactCommon/yoga/yoga/Yoga.cpp @@ -133,6 +133,12 @@ static int YGDefaultLog(const YGConfigRef config, #endif bool YGFloatIsUndefined(const float value) { +// TODO(gkm): Ugh! Some Android builds (r13b & clang-3.8) fail +// with the kludge below, so we must tailor it specifically for +// NDK r15c which has clang-5.0. NDK r16 will make it all better. +#if __ANDROID__ && __clang_major__ == 5 // TODO(gkm): remove for NDK >= 16 + using std::isnan; +#endif return isnan(value); }