BREAKING: Android: Refactor so uimanager can depend on modules/core

Summary:
cc astreet

The goal of this PR is to enable the buck module `uimanager` to depend on `modules/core` without introducing any dependency cycles.

PR #11008 relies on this PR. PR #11008 needs `uimanager` to depend on `modules/core` so that `uimanager` can fire events using `RCTDeviceEventEmitter` which is in `modules/core`.

This PR moved a number of classes and interfaces:
  - `com.facebook.react.modules.debug.DeveloperSettings` -> `com.facebook.react.modules.debug.interfaces.DeveloperSettings`
  - `com.facebook.react.devsupport.DevOptionHandler` -> `com.facebook.react.devsupport.interfaces.DevOptionHandler `
  - `com.facebook.react.devsupport.DevSupportManager` -> `com.facebook.react.devsupport.interfaces.DevSupportManager`
  - `com.facebook.react.devsupport.DevServerHelper.PackagerStatusCallback` -> `com.facebook.react.devsupport.interfaces.PackagerStatusCallback`
  - The class `com.facebook.react.devsupport.StackTraceHelper.StackFrame` was renamed to `StackFram
Closes https://github.com/facebook/react-native/pull/12329

Differential Revision: D4551160

Pulled By: astreet

fbshipit-source-id: 3a78443c4f30469b13ddfbdcc9bbef6af9e8381a
This commit is contained in:
Adam Comella
2017-02-13 11:01:30 -08:00
committed by Facebook Github Bot
parent 4161bada4a
commit ea6845ca22
37 changed files with 158 additions and 51 deletions

View File

@@ -24,6 +24,7 @@ import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.common.ReactConstants;
import com.facebook.react.module.annotations.ReactModule;
import com.facebook.react.modules.debug.interfaces.DeveloperSettings;
/**
* Module that records debug information during transitions (animated navigation events such as

View File

@@ -2,7 +2,7 @@ include_defs('//ReactAndroid/DEFS')
android_library(
name = 'debug',
srcs = glob(['**/*.java']),
srcs = glob(['*.java']),
deps = [
react_native_dep('libraries/fbcore/src/main/java/com/facebook/common/logging:logging'),
react_native_dep('third-party/java/infer-annotations:infer-annotations'),
@@ -10,6 +10,7 @@ android_library(
react_native_target('java/com/facebook/react/bridge:bridge'),
react_native_target('java/com/facebook/react/common:common'),
react_native_target('java/com/facebook/react/module/annotations:annotations'),
react_native_target('java/com/facebook/react/modules/debug:interfaces'),
react_native_target('java/com/facebook/react/uimanager:uimanager'),
],
visibility = [
@@ -17,3 +18,12 @@ android_library(
],
)
android_library(
name = 'interfaces',
srcs = glob(['interfaces/*.java']),
deps = [
],
visibility = [
'PUBLIC',
],
)

View File

@@ -7,7 +7,7 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
package com.facebook.react.modules.debug;
package com.facebook.react.modules.debug.interfaces;
/**
* Provides access to React Native developers settings.