From e512a4ae300ff1057f98e2e6375a432efa8c0241 Mon Sep 17 00:00:00 2001 From: Naris Siamwalla Date: Fri, 20 Apr 2018 09:40:06 -0700 Subject: [PATCH] Fix dtor declaration for clang-6 Reviewed By: smeenai Differential Revision: D7690428 fbshipit-source-id: 4b02a6f6cbccda3446f0a19b1b35c266a33560bd --- ReactCommon/fabric/uimanager/Scheduler.h | 2 +- ReactCommon/fabric/uimanager/SchedulerDelegate.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ReactCommon/fabric/uimanager/Scheduler.h b/ReactCommon/fabric/uimanager/Scheduler.h index 4f4ff203b..b48d6e848 100644 --- a/ReactCommon/fabric/uimanager/Scheduler.h +++ b/ReactCommon/fabric/uimanager/Scheduler.h @@ -29,7 +29,7 @@ class Scheduler: public: Scheduler(); - ~Scheduler(); + virtual ~Scheduler(); #pragma mark - Root Nodes Managerment diff --git a/ReactCommon/fabric/uimanager/SchedulerDelegate.h b/ReactCommon/fabric/uimanager/SchedulerDelegate.h index 2fe3da02a..3f2d9bf5f 100644 --- a/ReactCommon/fabric/uimanager/SchedulerDelegate.h +++ b/ReactCommon/fabric/uimanager/SchedulerDelegate.h @@ -16,6 +16,9 @@ namespace react { */ class SchedulerDelegate { public: + + virtual ~SchedulerDelegate() = default; + /* * Called right after Scheduler computed (and laid out) a new updated version * of the tree and calculated a set of mutation instructions which are