From e4d5dcb15b224a678b863ccb6f7a84f13eb1ecbb Mon Sep 17 00:00:00 2001 From: Alexander Blom Date: Fri, 19 Aug 2016 07:09:32 -0700 Subject: [PATCH] Always log exception in DevSupportManager Reviewed By: andreicoman11 Differential Revision: D3741763 fbshipit-source-id: b4cc32e4d237955ec4a67af323024acd0d19106a --- .../com/facebook/react/devsupport/DevSupportManagerImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java index 7f6f3f7df..68eeec8bd 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java @@ -234,8 +234,8 @@ public class DevSupportManagerImpl implements DevSupportManager { @Override public void handleException(Exception e) { if (mIsDevSupportEnabled) { - FLog.e(ReactConstants.TAG, "Exception in native call from JS", e); if (e instanceof JSException) { + FLog.e(ReactConstants.TAG, "Exception in native call from JS", e); // TODO #11638796: convert the stack into something useful showNewError(e.getMessage() + "\n\n" + ((JSException) e).getStack(), new StackFrame[] {}, JSEXCEPTION_ERROR_COOKIE, ErrorType.JS); @@ -249,6 +249,7 @@ public class DevSupportManagerImpl implements DevSupportManager { @Override public void showNewJavaError(String message, Throwable e) { + FLog.e(ReactConstants.TAG, "Exception in native call", e); showNewError(message, StackTraceHelper.convertJavaStackTrace(e), JAVA_ERROR_COOKIE, ErrorType.NATIVE); }