From e3ff3cf6cbc137e315eff6ac8aed43954b3668eb Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 29 Jan 2018 10:39:27 -0800 Subject: [PATCH] Removed outdated assertion in RCTShadowView related to breaking change in Yoga Summary: It's been more than two years; I think everyone already migrated and learned the new behavior. Reviewed By: emilsjolander Differential Revision: D6829885 fbshipit-source-id: a86d56fb7235a137e9ce6e360d7ae2224b047313 --- React/Views/RCTShadowView.m | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/React/Views/RCTShadowView.m b/React/Views/RCTShadowView.m index e0a2c7706..26db521e4 100644 --- a/React/Views/RCTShadowView.m +++ b/React/Views/RCTShadowView.m @@ -203,16 +203,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT], return; } -#if RCT_DEBUG - // This works around a breaking change in Yoga layout where setting flexBasis needs to be set explicitly, instead of relying on flex to propagate. - // We check for it by seeing if a width/height is provided along with a flexBasis of 0 and the width/height is laid out as 0. - if (YGNodeStyleGetFlexBasis(node).unit == YGUnitPoint && YGNodeStyleGetFlexBasis(node).value == 0 && - ((YGNodeStyleGetWidth(node).unit == YGUnitPoint && YGNodeStyleGetWidth(node).value > 0 && YGNodeLayoutGetWidth(node) == 0) || - (YGNodeStyleGetHeight(node).unit == YGUnitPoint && YGNodeStyleGetHeight(node).value > 0 && YGNodeLayoutGetHeight(node) == 0))) { - RCTLogError(@"View was rendered with explicitly set width/height but with a 0 flexBasis. (This might be fixed by changing flex: to flexGrow:) View: %@", self); - } -#endif - CGRect frame = CGRectMake(YGNodeLayoutGetLeft(node), YGNodeLayoutGetTop(node), YGNodeLayoutGetWidth(node), YGNodeLayoutGetHeight(node)); // Even if `YGNodeLayoutGetDirection` can return `YGDirectionInherit` here, it actually means