kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-12 19:48:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Making jsi::Runtime a part of EventBeat and EventPipe

Browse Source 
Summary:
We double down on JSI in Fabric. So, practically, JSI is now a hard dependency for Fabric. I hope it's for good.
Now `jsi::Runtime` is coupled with scheduling via `EventExecuter`, so we have to make `jsi::Runtime` a part of `EventBeat` to proxy runtime reference to bindgings.

Reviewed By: sahrens

Differential Revision: D12837225

fbshipit-source-id: 98edc33d6a3358e6c2905f2f03ce0004a9ca0503
This commit is contained in:
Valentin Shergin
2018-11-06 10:58:49 -08:00
committed by Facebook Github Bot
parent 3110a67047
commit df4521e6c4
11 changed files with 27 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ReactCommon/fabric/events/EventQueue.cpp
View File

@@ -16,7 +16,8 @@ EventQueue::EventQueue(
EventPipe eventPipe,
std::unique_ptr<EventBeat> eventBeat)
: eventPipe_(std::move(eventPipe)), eventBeat_(std::move(eventBeat)) {
eventBeat_->setBeatCallback(std::bind(&EventQueue::onBeat, this));
eventBeat_->setBeatCallback(
std::bind(&EventQueue::onBeat, this, std::placeholders::_1));
}
void EventQueue::enqueueEvent(const RawEvent &rawEvent) const {
@@ -24,7 +25,7 @@ void EventQueue::enqueueEvent(const RawEvent &rawEvent) const {
queue_.push_back(rawEvent);
}
void EventQueue::onBeat() const {
void EventQueue::onBeat(jsi::Runtime &runtime) const {
std::vector<RawEvent> queue;
{
@@ -42,7 +43,8 @@ void EventQueue::onBeat() const {
std::lock_guard<std::recursive_mutex> lock(EventEmitter::DispatchMutex());
for (const auto &event : queue) {
eventPipe_(event.eventTarget.lock().get(), event.type, event.payload);
eventPipe_(
runtime, event.eventTarget.lock().get(), event.type, event.payload);
}
}
}