From de09fd53bd41716142364e769e72b363bb3d3405 Mon Sep 17 00:00:00 2001 From: "Andrew Chen (Eng)" Date: Fri, 6 Jul 2018 12:31:09 -0700 Subject: [PATCH] Remove setJSEntryPoint from ReactRootView Summary: Doesn't look like it was ever used according to diffgrep https://our.intern.facebook.com/intern/diffgrep/?author=&expand_all=false&filepath=&matcher=strmatch&query=setJSEntryPoint&repo=fbsource&rev_type=all&result_size=3&search_order=2&source&target=added%20or%20removed axe is this okay? Differential Revision: D8730783 fbshipit-source-id: 1e6b9e8fbd50c108a24b592793060a5344f1d0b1 --- .../facebook/react/ReactInstanceManager.java | 2 +- .../com/facebook/react/ReactRootView.java | 38 +++---------------- 2 files changed, 6 insertions(+), 34 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index e5b3bae44..075ba03ea 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -1016,7 +1016,7 @@ public class ReactInstanceManager { UIManager uiManagerModule = UIManagerHelper.getUIManager(mCurrentReactContext, rootView.getUIManagerType()); final int rootTag = uiManagerModule.addRootView(rootView); rootView.setRootViewTag(rootTag); - rootView.invokeJSEntryPoint(); + rootView.runApplication(); Systrace.beginAsyncSection( TRACE_TAG_REACT_JAVA_BRIDGE, "pre_rootView.onAttachedToReactInstance", diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java index 5f8ff1699..6e8a92f60 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java @@ -7,9 +7,9 @@ package com.facebook.react; -import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE; -import static com.facebook.react.uimanager.common.UIManagerType.FABRIC; import static com.facebook.react.uimanager.common.UIManagerType.DEFAULT; +import static com.facebook.react.uimanager.common.UIManagerType.FABRIC; +import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE; import android.content.Context; import android.graphics.Canvas; @@ -50,9 +50,9 @@ import com.facebook.react.uimanager.UIManagerHelper; import com.facebook.react.uimanager.UIManagerModule; import com.facebook.react.uimanager.common.MeasureSpecProvider; import com.facebook.react.uimanager.common.SizeMonitoringFrameLayout; +import com.facebook.react.uimanager.common.UIManagerType; import com.facebook.react.uimanager.events.EventDispatcher; import com.facebook.systrace.Systrace; -import com.facebook.react.uimanager.common.UIManagerType; import javax.annotation.Nullable; /** @@ -93,7 +93,6 @@ public class ReactRootView extends SizeMonitoringFrameLayout private boolean mWasMeasured = false; private int mWidthMeasureSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED); private int mHeightMeasureSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED); - private @Nullable Runnable mJSEntryPoint; private @UIManagerType int mUIManagerType = DEFAULT; public ReactRootView(Context context) { @@ -454,7 +453,7 @@ public class ReactRootView extends SizeMonitoringFrameLayout UiThreadUtil.assertOnUiThread(); mAppProperties = appProperties; if (getRootViewTag() != 0) { - invokeJSEntryPoint(); + runApplication(); } } @@ -462,34 +461,7 @@ public class ReactRootView extends SizeMonitoringFrameLayout * Calls into JS to start the React application. Can be called multiple times with the * same rootTag, which will re-render the application from the root. */ - /*package */ void invokeJSEntryPoint() { - if (mJSEntryPoint == null) { - defaultJSEntryPoint(); - } else { - mJSEntryPoint.run(); - } - } - - /** - * Set a custom entry point for invoking JS. By default, this is AppRegistry.runApplication - * @param jsEntryPoint - */ - public void setJSEntryPoint(Runnable jsEntryPoint) { - mJSEntryPoint = jsEntryPoint; - } - - public void invokeDefaultJSEntryPoint(@Nullable Bundle appProperties) { - UiThreadUtil.assertOnUiThread(); - if (appProperties != null) { - mAppProperties = appProperties; - } - defaultJSEntryPoint(); - } - - /** - * Calls the default entry point into JS which is AppRegistry.runApplication() - */ - private void defaultJSEntryPoint() { + /* package */ void runApplication() { Systrace.beginSection(TRACE_TAG_REACT_JAVA_BRIDGE, "ReactRootView.runApplication"); try { if (mReactInstanceManager == null || !mIsAttachedToInstance) {