From dcd4e90d9ab5699a5e1827ec377021ccbf0afc1e Mon Sep 17 00:00:00 2001 From: Peter van der Zee Date: Thu, 14 Mar 2019 06:55:56 -0700 Subject: [PATCH] Bump Prettier to 1.16.4 Summary: @public This bumps Prettier to v1.16.4 Only format source files were updated. Reviewed By: mjesun Differential Revision: D14454893 fbshipit-source-id: 72f9872fe764a79dbf0d9fab9bebb1456b039f2f --- IntegrationTests/AsyncStorageTest.js | 4 +- .../IntegrationTestHarnessTest.js | 4 +- IntegrationTests/IntegrationTestsApp.js | 4 +- Libraries/Blob/__tests__/URL-test.js | 70 +++++++++---------- .../ActivityIndicator/ActivityIndicator.js | 2 +- .../DatePicker/DatePickerIOS.ios.js | 4 +- Libraries/Components/TextInput/TextInput.js | 4 +- Libraries/Components/Touchable/Touchable.js | 4 +- Libraries/Image/Image.android.js | 4 +- Libraries/Image/Image.ios.js | 4 +- Libraries/Interaction/TouchHistoryMath.js | 8 +-- Libraries/Linking/Linking.js | 12 ++-- Libraries/Lists/VirtualizedList.js | 4 +- Libraries/ReactNative/ReactFabricInternals.js | 4 +- .../Utilities/PerformanceLoggerContext.js | 6 +- Libraries/WebSocket/WebSocket.js | 7 +- .../YellowBox/UI/YellowBoxImageSource.js | 20 +++--- RNTester/js/AsyncStorageExample.js | 4 +- RNTester/js/InputAccessoryViewExample.js | 4 +- RNTester/js/LayoutExample.js | 4 +- RNTester/js/NetInfoExample.js | 4 +- RNTester/js/PointerEventsExample.js | 4 +- .../js/ProgressBarAndroidExample.android.js | 4 +- RNTester/js/StatusBarExample.js | 6 +- RNTester/js/TextExample.android.js | 6 +- RNTester/js/TextExample.ios.js | 5 +- RNTester/js/TextInputExample.android.js | 6 +- RNTester/js/TouchableExample.js | 8 ++- RNTester/js/XHRExampleDownload.js | 4 +- RNTester/js/XHRExampleFormData.js | 49 +++++++------ .../js/MultitouchHandlingTestAppModule.js | 4 +- .../src/androidTest/js/UIManagerTestModule.js | 8 +-- jest/hasteImpl.js | 4 +- package.json | 2 +- .../package.json | 2 +- .../yarn.lock | 8 +-- scripts/circleci/code-analysis-bot.js | 36 +++++----- yarn.lock | 8 +-- 38 files changed, 169 insertions(+), 176 deletions(-) diff --git a/IntegrationTests/AsyncStorageTest.js b/IntegrationTests/AsyncStorageTest.js index bcd0abe07..c4d2fb3e1 100644 --- a/IntegrationTests/AsyncStorageTest.js +++ b/IntegrationTests/AsyncStorageTest.js @@ -194,8 +194,8 @@ class AsyncStorageTest extends React.Component<{}, $FlowFixMeState> { {/* $FlowFixMe(>=0.54.0 site=react_native_fb,react_native_oss) This - * comment suppresses an error found when Flow v0.54 was deployed. - * To see the error delete this comment and run Flow. */ + * comment suppresses an error found when Flow v0.54 was deployed. + * To see the error delete this comment and run Flow. */ this.constructor.displayName + ': '} {this.state.done ? 'Done' : 'Testing...'} {'\n\n' + this.state.messages} diff --git a/IntegrationTests/IntegrationTestHarnessTest.js b/IntegrationTests/IntegrationTestHarnessTest.js index efe6cd4cd..ea5e4f3a4 100644 --- a/IntegrationTests/IntegrationTestHarnessTest.js +++ b/IntegrationTests/IntegrationTestHarnessTest.js @@ -57,8 +57,8 @@ class IntegrationTestHarnessTest extends React.Component { {/* $FlowFixMe(>=0.54.0 site=react_native_fb,react_native_oss) This - * comment suppresses an error found when Flow v0.54 was deployed. - * To see the error delete this comment and run Flow. */ + * comment suppresses an error found when Flow v0.54 was deployed. + * To see the error delete this comment and run Flow. */ this.constructor.displayName + ': '} {this.state.done ? 'Done' : 'Testing...'} diff --git a/IntegrationTests/IntegrationTestsApp.js b/IntegrationTests/IntegrationTestsApp.js index de88f1d60..283669488 100644 --- a/IntegrationTests/IntegrationTestsApp.js +++ b/IntegrationTests/IntegrationTestsApp.js @@ -61,8 +61,8 @@ class IntegrationTestsApp extends React.Component<{}, $FlowFixMeState> { return ( {/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This - * comment suppresses an error when upgrading Flow's support for - * React. To see the error delete this comment and run Flow. */} + * comment suppresses an error when upgrading Flow's support for + * React. To see the error delete this comment and run Flow. */} ); diff --git a/Libraries/Blob/__tests__/URL-test.js b/Libraries/Blob/__tests__/URL-test.js index 051ec9a72..b39302bbd 100644 --- a/Libraries/Blob/__tests__/URL-test.js +++ b/Libraries/Blob/__tests__/URL-test.js @@ -1,35 +1,35 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @format - * @emails oncall+react_native - */ -'use strict'; - -const URL = require('URL').URL; - -describe('URL', function() { - it('should pass Mozilla Dev Network examples', () => { - const a = new URL('/', 'https://developer.mozilla.org'); - expect(a.href).toBe('https://developer.mozilla.org/'); - const b = new URL('https://developer.mozilla.org'); - expect(b.href).toBe('https://developer.mozilla.org/'); - const c = new URL('en-US/docs', b); - expect(c.href).toBe('https://developer.mozilla.org/en-US/docs'); - const d = new URL('/en-US/docs', b); - expect(d.href).toBe('https://developer.mozilla.org/en-US/docs'); - const f = new URL('/en-US/docs', d); - expect(f.href).toBe('https://developer.mozilla.org/en-US/docs'); - // from original test suite, but requires complex implementation - // const g = new URL( - // '/en-US/docs', - // 'https://developer.mozilla.org/fr-FR/toto', - // ); - // expect(g.href).toBe('https://developer.mozilla.org/en-US/docs'); - const h = new URL('/en-US/docs', a); - expect(h.href).toBe('https://developer.mozilla.org/en-US/docs'); - }); -}); +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @format + * @emails oncall+react_native + */ +'use strict'; + +const URL = require('URL').URL; + +describe('URL', function() { + it('should pass Mozilla Dev Network examples', () => { + const a = new URL('/', 'https://developer.mozilla.org'); + expect(a.href).toBe('https://developer.mozilla.org/'); + const b = new URL('https://developer.mozilla.org'); + expect(b.href).toBe('https://developer.mozilla.org/'); + const c = new URL('en-US/docs', b); + expect(c.href).toBe('https://developer.mozilla.org/en-US/docs'); + const d = new URL('/en-US/docs', b); + expect(d.href).toBe('https://developer.mozilla.org/en-US/docs'); + const f = new URL('/en-US/docs', d); + expect(f.href).toBe('https://developer.mozilla.org/en-US/docs'); + // from original test suite, but requires complex implementation + // const g = new URL( + // '/en-US/docs', + // 'https://developer.mozilla.org/fr-FR/toto', + // ); + // expect(g.href).toBe('https://developer.mozilla.org/en-US/docs'); + const h = new URL('/en-US/docs', a); + expect(h.href).toBe('https://developer.mozilla.org/en-US/docs'); + }); +}); diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.js b/Libraries/Components/ActivityIndicator/ActivityIndicator.js index 67d5b8a5d..6a220d08d 100644 --- a/Libraries/Components/ActivityIndicator/ActivityIndicator.js +++ b/Libraries/Components/ActivityIndicator/ActivityIndicator.js @@ -105,7 +105,7 @@ const ActivityIndicator = (props: Props, forwardedRef?: any) => { style, )}> {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} ); diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js index a93516c9a..bef65cf22 100644 --- a/Libraries/Components/DatePicker/DatePickerIOS.ios.js +++ b/Libraries/Components/DatePicker/DatePickerIOS.ios.js @@ -155,8 +155,8 @@ class DatePickerIOS extends React.Component { props.date ? props.date.getTime() : props.initialDate - ? props.initialDate.getTime() - : undefined + ? props.initialDate.getTime() + : undefined } locale={ props.locale != null && props.locale !== '' diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js index 34af8db6d..d21758bf7 100644 --- a/Libraries/Components/TextInput/TextInput.js +++ b/Libraries/Components/TextInput/TextInput.js @@ -1007,8 +1007,8 @@ const TextInput = createReactClass({ return typeof this.props.value === 'string' ? this.props.value : typeof this.props.defaultValue === 'string' - ? this.props.defaultValue - : ''; + ? this.props.defaultValue + : ''; }, _setNativeRef: function(ref: any) { diff --git a/Libraries/Components/Touchable/Touchable.js b/Libraries/Components/Touchable/Touchable.js index 65a82b1c4..72f7e4c35 100644 --- a/Libraries/Components/Touchable/Touchable.js +++ b/Libraries/Components/Touchable/Touchable.js @@ -35,8 +35,8 @@ const extractSingleTouch = nativeEvent => { return !hasTouches && hasChangedTouches ? changedTouches[0] : hasTouches - ? touches[0] - : nativeEvent; + ? touches[0] + : nativeEvent; }; /** diff --git a/Libraries/Image/Image.android.js b/Libraries/Image/Image.android.js index dcfd770b0..002aba8f6 100644 --- a/Libraries/Image/Image.android.js +++ b/Libraries/Image/Image.android.js @@ -190,9 +190,7 @@ async function queryCache( return await ImageLoader.queryCache(urls); } -declare class ImageComponentType extends ReactNative.NativeComponent< - ImagePropsType, -> { +declare class ImageComponentType extends ReactNative.NativeComponent { static getSize: typeof getSize; static getSizeWithHeaders: typeof getSizeWithHeaders; static prefetch: typeof prefetch; diff --git a/Libraries/Image/Image.ios.js b/Libraries/Image/Image.ios.js index 72c5d31fd..301e28ef3 100644 --- a/Libraries/Image/Image.ios.js +++ b/Libraries/Image/Image.ios.js @@ -70,9 +70,7 @@ async function queryCache( return await ImageViewManager.queryCache(urls); } -declare class ImageComponentType extends ReactNative.NativeComponent< - ImagePropsType, -> { +declare class ImageComponentType extends ReactNative.NativeComponent { static getSize: typeof getSize; static getSizeWithHeaders: typeof getSizeWithHeaders; static prefetch: typeof prefetch; diff --git a/Libraries/Interaction/TouchHistoryMath.js b/Libraries/Interaction/TouchHistoryMath.js index 92d3c5d83..19cf76a9f 100644 --- a/Libraries/Interaction/TouchHistoryMath.js +++ b/Libraries/Interaction/TouchHistoryMath.js @@ -48,10 +48,10 @@ const TouchHistoryMath = { ofCurrent && isXAxis ? oneTouchData.currentPageX : ofCurrent && !isXAxis - ? oneTouchData.currentPageY - : !ofCurrent && isXAxis - ? oneTouchData.previousPageX - : oneTouchData.previousPageY; + ? oneTouchData.currentPageY + : !ofCurrent && isXAxis + ? oneTouchData.previousPageX + : oneTouchData.previousPageY; count = 1; } } else { diff --git a/Libraries/Linking/Linking.js b/Libraries/Linking/Linking.js index 66dde5537..a1d0b2ae3 100644 --- a/Libraries/Linking/Linking.js +++ b/Libraries/Linking/Linking.js @@ -82,12 +82,12 @@ class Linking extends NativeEventEmitter { } /* - * Launch an Android intent with extras (optional) - * - * @platform android - * - * See https://facebook.github.io/react-native/docs/linking.html#sendintent - */ + * Launch an Android intent with extras (optional) + * + * @platform android + * + * See https://facebook.github.io/react-native/docs/linking.html#sendintent + */ sendIntent( action: String, extras?: [{key: string, value: string | number | boolean}], diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js index 9e9dbe16b..dc0c508dc 100644 --- a/Libraries/Lists/VirtualizedList.js +++ b/Libraries/Lists/VirtualizedList.js @@ -1719,8 +1719,8 @@ class CellRenderer extends React.Component< ? [{flexDirection: 'row-reverse'}, inversionStyle] : [{flexDirection: 'column-reverse'}, inversionStyle] : horizontal - ? [{flexDirection: 'row'}, inversionStyle] - : inversionStyle; + ? [{flexDirection: 'row'}, inversionStyle] + : inversionStyle; if (!CellRendererComponent) { return ( /* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an diff --git a/Libraries/ReactNative/ReactFabricInternals.js b/Libraries/ReactNative/ReactFabricInternals.js index e78e5dbee..dacabe62c 100644 --- a/Libraries/ReactNative/ReactFabricInternals.js +++ b/Libraries/ReactNative/ReactFabricInternals.js @@ -20,8 +20,6 @@ import type {NativeMethodsMixinType} from 'ReactNativeTypes'; const {NativeMethodsMixin} = __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED; module.exports = { - NativeMethodsMixin: ((NativeMethodsMixin: any): $Exact< - NativeMethodsMixinType, - >), + NativeMethodsMixin: ((NativeMethodsMixin: any): $Exact), createReactNativeComponentClass, }; diff --git a/Libraries/Utilities/PerformanceLoggerContext.js b/Libraries/Utilities/PerformanceLoggerContext.js index e00b61a74..79e62d5c3 100644 --- a/Libraries/Utilities/PerformanceLoggerContext.js +++ b/Libraries/Utilities/PerformanceLoggerContext.js @@ -14,7 +14,7 @@ import * as React from 'react'; import GlobalPerformanceLogger from 'GlobalPerformanceLogger'; import type {IPerformanceLogger} from 'createPerformanceLogger'; -const PerformanceLoggerContext: React.Context< - IPerformanceLogger, -> = React.createContext(GlobalPerformanceLogger); +const PerformanceLoggerContext: React.Context = React.createContext( + GlobalPerformanceLogger, +); export default PerformanceLoggerContext; diff --git a/Libraries/WebSocket/WebSocket.js b/Libraries/WebSocket/WebSocket.js index 8dcfef3f8..8ec13bedc 100644 --- a/Libraries/WebSocket/WebSocket.js +++ b/Libraries/WebSocket/WebSocket.js @@ -142,12 +142,7 @@ class WebSocket extends EventTarget(...WEBSOCKET_EVENTS) { this._eventEmitter = new NativeEventEmitter(WebSocketModule); this._socketId = nextWebSocketId++; this._registerEvents(); - WebSocketModule.connect( - url, - protocols, - {headers}, - this._socketId, - ); + WebSocketModule.connect(url, protocols, {headers}, this._socketId); } get binaryType(): ?BinaryType { diff --git a/Libraries/YellowBox/UI/YellowBoxImageSource.js b/Libraries/YellowBox/UI/YellowBoxImageSource.js index b4258d8c4..05a9f46b3 100644 --- a/Libraries/YellowBox/UI/YellowBoxImageSource.js +++ b/Libraries/YellowBox/UI/YellowBoxImageSource.js @@ -33,32 +33,32 @@ const YellowBoxImageSource = { scale > 2 ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAB60lEQVRoge2Z3W3DIBSFj9oFPAIjZARGyAiMkBHuJh4hI2QEj5AR3Me+tQ91JALHmD8bKvmTkCr5Auc6/kzUACcnRXzuvL4GoAB8Afjeea9qXADcAfw4475c65orgBl++NeYl5ouUQiHt5tQTRJuwB6b5zLY49QVGn7I0bo+kuv60IQbuHf5CWCIqOkCgX93maia1MkRAUMo+OI+AvUPp7a50EzcUCBF6psJrUkYiZgnZJ7eId8mMeIyhpW5hyLw72LKCXsl86VqwgAKceKapW5e/nZpJnSsuHaTM7muyDq7C63JprJS69YxhNTpSlkpKeLGNHCo0EJChcSNaQA4SGiFtBMXJFSI3YVOPXFB6kMoUl9NaE0Wl4h5KQ0AOwqde+KmNrCL0EKCxJ64qQ0AlYVWSBfXZusgW6Oa0Dni2hiEv0qsoci+yUJrsoikLlKAkP11ygK54taiSOgb/O5b/DMqS+gBZeLWJlnoEX7XwQkBDPIktlEkz7hWrEmxZG4M5L9GXYTk0qxwcopKxa3VABN6cosM/C5LxTUof4ReMKHf1nRlaSnuGsGM7kfU4w8RF5Bz4aNlokLe/HQ/ngl9/Qih4L9k3h4hA1+S3odxu3Q77Hl4r1Hg75n6D01M2Difbp02Mi3ZTk5OLH4BUyEtOlDYuK0AAAAASUVORK5CYII=' : scale > 1 - ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAABVklEQVRYheWX4U3DMBBGH4gBMoJHyAgeoSNkAxjBG5QNOkJHCGzQDcoGZQP4gY3Oqe1cEscS4pNOqs9Jvqvv6ZrCf9fDhnutD4A3H810Br4mcW5l7hLmIdze5mZi+OJD5syeBYzC6CjyR5Ef9zI/CJMb0Im9zufC/qG2eQdchcGQuGYQ+9dJgZvl0B2xbJGrZW6IIevFXp9YVwcyB540syJfFcgSeJb0cVcDcg68XAFQCUhH+ShLBcBGIA158LQFqIB8zBRwEp9fgctcxQld/L2pZxZVAk/KkucjaDGQmoknrz35KEE2sABIRxm8tVIBaZgHb61UQOYmXk7aFgQVJ6QWPCnLAriYAVILnpTxD7yh/9EZiIEE4m+y29uMkGy1nQ6i9wYFRB5PwKdYP/v1msmnUe89gn695bG0iqjdXeMiRu9599csvGKZ0jlu0Ac/7d2rxX9Q37HW6QfX/ZguAAAAAElFTkSuQmCC' - : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAvUlEQVQ4jbWT4Q3CIBCFP40DdANxg24gIzhKuwEjuIFxAkcwTtARGicoG+iPXlMCB8UfvoQc4e7ePV4A/ogWuMlqc0W7AsEo0QMNcPplugMmwMia5KwKWkNIuIkHq3wLXGQ/Sq4IC3wkLpOfmZyKeEpIEKsDYB8VN0Afkfpg30uNiycbdKcNqXEOxdBEWoEAoqta8uZ0iqqkxwGDUrSFAXAHZpOWd/+ubD5Kz335Cx1wZna4Bh54AddauVl8ARfCLO9Xq7xGAAAAAElFTkSuQmCC', + ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAABVklEQVRYheWX4U3DMBBGH4gBMoJHyAgeoSNkAxjBG5QNOkJHCGzQDcoGZQP4gY3Oqe1cEscS4pNOqs9Jvqvv6ZrCf9fDhnutD4A3H810Br4mcW5l7hLmIdze5mZi+OJD5syeBYzC6CjyR5Ef9zI/CJMb0Im9zufC/qG2eQdchcGQuGYQ+9dJgZvl0B2xbJGrZW6IIevFXp9YVwcyB540syJfFcgSeJb0cVcDcg68XAFQCUhH+ShLBcBGIA158LQFqIB8zBRwEp9fgctcxQld/L2pZxZVAk/KkucjaDGQmoknrz35KEE2sABIRxm8tVIBaZgHb61UQOYmXk7aFgQVJ6QWPCnLAriYAVILnpTxD7yh/9EZiIEE4m+y29uMkGy1nQ6i9wYFRB5PwKdYP/v1msmnUe89gn695bG0iqjdXeMiRu9599csvGKZ0jlu0Ac/7d2rxX9Q37HW6QfX/ZguAAAAAElFTkSuQmCC' + : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAvUlEQVQ4jbWT4Q3CIBCFP40DdANxg24gIzhKuwEjuIFxAkcwTtARGicoG+iPXlMCB8UfvoQc4e7ePV4A/ogWuMlqc0W7AsEo0QMNcPplugMmwMia5KwKWkNIuIkHq3wLXGQ/Sq4IC3wkLpOfmZyKeEpIEKsDYB8VN0Afkfpg30uNiycbdKcNqXEOxdBEWoEAoqta8uZ0iqqkxwGDUrSFAXAHZpOWd/+ubD5Kz335Cx1wZna4Bh54AddauVl8ARfCLO9Xq7xGAAAAAElFTkSuQmCC', check: scale > 2 ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAqElEQVRoge3YTQ7CIBRF4bPUu/8JS6gTSaqilh95vuR+CaO2cGgYNAUzMzOzFgHlPhRaMkDAcRoltKaTeIxPtQHxGn+Q5AgJx8cQjo8hHB9DOP76Yiu/RcTmN18WLiQCjs3zBkYXVGOeLWd+xcIr5pgyEzDz7FIjISPP/FRPUM+9W4nvYVfuCSXeB3669ldEOzRFfCUSx1cicXwlEsdXIvEPKDMzM7PMbtugw3XTpNA2AAAAAElFTkSuQmCC' : scale > 1 - ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAf0lEQVRYhe2UvQ2AIBQGL3EBR3AESkv3bxxFN8DmWUgwvkI+En1X0cBd+IMg+DuDyDMCs413kfMiX4EMbD3l8oCaPIU85B4mYLEF5XJscrYFPRGvb/sZ4IlocubJGdH0wj1FSG77XYT0qdUi5O+8jOjyyZQRUnkZ0UUeBMF3OQC/0VsyGlxligAAAABJRU5ErkJggg==' - : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAASElEQVQ4jWNgGJHAgIGBIYESze8ZGBjWU6L5PAMDgwBNNCdAFZJt83qoQmRDSHK2AFQhzBCy/IxsCNkBJsDAwLAfiknWPBIBAETPFeuA4fr6AAAAAElFTkSuQmCC', + ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAf0lEQVRYhe2UvQ2AIBQGL3EBR3AESkv3bxxFN8DmWUgwvkI+En1X0cBd+IMg+DuDyDMCs413kfMiX4EMbD3l8oCaPIU85B4mYLEF5XJscrYFPRGvb/sZ4IlocubJGdH0wj1FSG77XYT0qdUi5O+8jOjyyZQRUnkZ0UUeBMF3OQC/0VsyGlxligAAAABJRU5ErkJggg==' + : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAASElEQVQ4jWNgGJHAgIGBIYESze8ZGBjWU6L5PAMDgwBNNCdAFZJt83qoQmRDSHK2AFQhzBCy/IxsCNkBJsDAwLAfiknWPBIBAETPFeuA4fr6AAAAAElFTkSuQmCC', chevronLeft: scale > 2 ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAgElEQVRoge3YMQ6DQBAEwRYvnf8nPAECbAnkyATsrt0lXUyPdAE6kCRJ/yXA+jopLbkhwHY6a2nNl8I1ftSA8Bm/MeQKBeNrBONrBONrBONrhMHxcPwOlMUvT32oszD8CoEj+giO6CE4oofgiB7Cj44Y86zyFoYPgOFPi5Ik6WwHji+QVIOyhqgAAAAASUVORK5CYII=' : scale > 1 - ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACQAAAAkCAYAAADhAJiYAAAAaUlEQVRYhe3WsQ2AMAwAwRcs5LEYg3HpYANoQKKgcEEUI/6adM5LbgySfmZsNDeACdiApdEfaQGswH6+Xd1jugc9xYQxxhjz9RhaxwxvDuul3MrAqDyjsozKKnWgXUqdsJcAZgqsTFJ5B7gjUNw0n0HHAAAAAElFTkSuQmCC' - : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAARklEQVQ4jWNgGPKAmUh1AQwMDBIMDAwPyLEkgYGB4T/UELI1J9BdcwCxmpnIMZ1YkECsK+hmCNZoZCHCgAUMDAwfoHg4AgDJuQ/bcLyV+QAAAABJRU5ErkJggg==', + ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACQAAAAkCAYAAADhAJiYAAAAaUlEQVRYhe3WsQ2AMAwAwRcs5LEYg3HpYANoQKKgcEEUI/6adM5LbgySfmZsNDeACdiApdEfaQGswH6+Xd1jugc9xYQxxhjz9RhaxwxvDuul3MrAqDyjsozKKnWgXUqdsJcAZgqsTFJ5B7gjUNw0n0HHAAAAAElFTkSuQmCC' + : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAARklEQVQ4jWNgGPKAmUh1AQwMDBIMDAwPyLEkgYGB4T/UELI1J9BdcwCxmpnIMZ1YkECsK+hmCNZoZCHCgAUMDAwfoHg4AgDJuQ/bcLyV+QAAAABJRU5ErkJggg==', chevronRight: scale > 2 ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAeElEQVRoge3YMQ6AIBQE0Ykn3fs3HEEbC6MdFp+v8xJaspNQAZIkqbcA4zwpXTJpAPvlpHTNhHtAu4jwDDCiQjBiDcGINQQj1hCMWEN4Boy3l25vL/iL0PgJBcfXCI6vERxfIzi+Rmg8Hj7wrdL+Yys0/1qUJEmzDvSAkFQ8EOdJAAAAAElFTkSuQmCC' : scale > 1 - ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACQAAAAkCAYAAADhAJiYAAAAZElEQVRYhe3WsQmAQAxA0Y8ulLEcw3HtdANtBNvzCJjD/5pUgQ9pApJ+Zu7YCWABDmDLzemzA+c94+MW4AkqExUY1caoVka1GibqlSm7qJJSJzPGGGMylYqBgi9sACtFYiQN7wKC6VDcJ7tlpQAAAABJRU5ErkJggg==' - : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAANUlEQVQ4jWNgGLbAgYGBIYASAwIYGBj+MzAwJFBiSMLQMISJEpMptp2mmimORgcGChPSEAIAHGENPH8gqdYAAAAASUVORK5CYII=', + ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACQAAAAkCAYAAADhAJiYAAAAZElEQVRYhe3WsQmAQAxA0Y8ulLEcw3HtdANtBNvzCJjD/5pUgQ9pApJ+Zu7YCWABDmDLzemzA+c94+MW4AkqExUY1caoVka1GibqlSm7qJJSJzPGGGMylYqBgi9sACtFYiQN7wKC6VDcJ7tlpQAAAABJRU5ErkJggg==' + : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAANUlEQVQ4jWNgGLbAgYGBIYASAwIYGBj+MzAwJFBiSMLQMISJEpMptp2mmimORgcGChPSEAIAHGENPH8gqdYAAAAASUVORK5CYII=', loader: scale > 2 ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAABXElEQVRoge2a3W3DMAyEr+0CHkGjaISOcKN4k6zQETpCR+gGzgbpQ10kcamIpKQ6avQBBPxg3pHwL2UDg/8LASxrcNdKnCwATmssrUyeWgnju/DmXs8tRP+Sh2kgAJga1rFlWj2rcMD5YqQh77QJLbzIORjyRIJQCJW5ngYo5AVlrsgkCGqbsDbAhFfxqZsSZibP0oDXQ43HQPsg82i7sBoR+VcJq2YxKcPo0IoJLRZXmYGC6ezQmQUdVqhPBVH/CNBTSMkLVlzjA8Bbocb7GoPBoADi+umZilYzbrG/JrnljOvy734iu4To/BQaDB6Rl4LciPPF9Lmjhgvi+s7w6tCIGw3WKS0P8fvWNjt0ZkGHFeq7CQXTbkZKGg2JOxrqPUZ3s6ziNdju38IjS/dLi0EQpDLX2gDQYHEX6Hx5/YcA+6H0NgAYPnCMj3x7Mxq4wTGx3Q1E578aDDR8AX0mOGD6BEN/AAAAAElFTkSuQmCC' : scale > 1 - ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAABN0lEQVRYhe2WzU3EMBCFP34KyJEjJaQDXAIlJJ24BSow2wEdhHSwJSwd7JHbcmC0mOxMnDiWDIInWbHkN29exo4n8IvRAEFGU8OAA04yulyR60Jm7msbyIZloAMGwBfI4UWrWxM08LW/weC4iOMNTog4g0awKjBG827GxBwC3996NHizAifsSrTRmlsZm23CT9adktyXSq6ZUPdxgiXnZzW8CLcLuC3lvqA/gCt5NtjlPQL7TP0Wu1HtRRu4PO3T4TKTz2kG+AG9IN6CR/Su9iojBw69egfghWgL/pGCp+JFVPUqTjWjlsuqeAo1o6rt2C8QcNiV0UxoHPMieojmz0CfMKyhl1hN84xbI3gnz5Ftp7kH3iT5LsFdDUf6pzSJ6r2glIFDbuDNhqRH4I7Pvv4EvG/QqocP2Jh/xzzX/zUAAAAASUVORK5CYII=' - : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAsklEQVQ4jaWTYRHCMAyFP7gJmIQ6oChgEpBQKXMwC3MADpAAEiphDuBHC4QuDRu8u9ylyWtem7Rgw2X7GT1wsghb4beAVzhtsfYyJgs44AoEQzBkjrMId1HkKPwyZ6oMSnxYsnk1NqT7yMo34Fzhd9meGJvs7Hh3NhqCLXDI/rT0lKsR+KOJgc9RdaRRarkZvELogYsi8HqxjUhGYE+aQg1jzketwFTZXHbbEpjB8eU7PwAbLiJz46707gAAAABJRU5ErkJggg==', + ? 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAABN0lEQVRYhe2WzU3EMBCFP34KyJEjJaQDXAIlJJ24BSow2wEdhHSwJSwd7JHbcmC0mOxMnDiWDIInWbHkN29exo4n8IvRAEFGU8OAA04yulyR60Jm7msbyIZloAMGwBfI4UWrWxM08LW/weC4iOMNTog4g0awKjBG827GxBwC3996NHizAifsSrTRmlsZm23CT9adktyXSq6ZUPdxgiXnZzW8CLcLuC3lvqA/gCt5NtjlPQL7TP0Wu1HtRRu4PO3T4TKTz2kG+AG9IN6CR/Su9iojBw69egfghWgL/pGCp+JFVPUqTjWjlsuqeAo1o6rt2C8QcNiV0UxoHPMieojmz0CfMKyhl1hN84xbI3gnz5Ftp7kH3iT5LsFdDUf6pzSJ6r2glIFDbuDNhqRH4I7Pvv4EvG/QqocP2Jh/xzzX/zUAAAAASUVORK5CYII=' + : 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAsklEQVQ4jaWTYRHCMAyFP7gJmIQ6oChgEpBQKXMwC3MADpAAEiphDuBHC4QuDRu8u9ylyWtem7Rgw2X7GT1wsghb4beAVzhtsfYyJgs44AoEQzBkjrMId1HkKPwyZ6oMSnxYsnk1NqT7yMo34Fzhd9meGJvs7Hh3NhqCLXDI/rT0lKsR+KOJgc9RdaRRarkZvELogYsi8HqxjUhGYE+aQg1jzketwFTZXHbbEpjB8eU7PwAbLiJz46707gAAAABJRU5ErkJggg==', }; module.exports = YellowBoxImageSource; diff --git a/RNTester/js/AsyncStorageExample.js b/RNTester/js/AsyncStorageExample.js index 4c485ea17..a92c82861 100644 --- a/RNTester/js/AsyncStorageExample.js +++ b/RNTester/js/AsyncStorageExample.js @@ -61,7 +61,9 @@ class BasicStorageExample extends React.Component<{}, $FlowFixMeState> { Messages: - {this.state.messages.map(m => {m})} + {this.state.messages.map(m => ( + {m} + ))} ); } diff --git a/RNTester/js/InputAccessoryViewExample.js b/RNTester/js/InputAccessoryViewExample.js index 3cc2665d5..7337e3417 100644 --- a/RNTester/js/InputAccessoryViewExample.js +++ b/RNTester/js/InputAccessoryViewExample.js @@ -70,7 +70,9 @@ class InputAccessoryViewExample extends React.Component { {Array(15) .fill() - .map((_, i) => )} + .map((_, i) => ( + + ))} diff --git a/RNTester/js/LayoutExample.js b/RNTester/js/LayoutExample.js index d77e6c67d..7bdb48e79 100644 --- a/RNTester/js/LayoutExample.js +++ b/RNTester/js/LayoutExample.js @@ -174,7 +174,9 @@ class LayoutExample extends React.Component<$FlowFixMeProps> { - {'oooooooooooooooo'.split('').map((char, i) => )} + {'oooooooooooooooo'.split('').map((char, i) => ( + + ))} diff --git a/RNTester/js/NetInfoExample.js b/RNTester/js/NetInfoExample.js index ae8f0976d..a0e22be39 100644 --- a/RNTester/js/NetInfoExample.js +++ b/RNTester/js/NetInfoExample.js @@ -133,8 +133,8 @@ class IsConnectionExpensive extends React.Component<{}, $FlowFixMeState> { {this.state.isConnectionExpensive === true ? 'Expensive' : this.state.isConnectionExpensive === false - ? 'Not expensive' - : 'Unknown'} + ? 'Not expensive' + : 'Unknown'} diff --git a/RNTester/js/PointerEventsExample.js b/RNTester/js/PointerEventsExample.js index 4c9d8fa15..2830c3e9c 100644 --- a/RNTester/js/PointerEventsExample.js +++ b/RNTester/js/PointerEventsExample.js @@ -42,8 +42,8 @@ class ExampleBox extends React.Component<$FlowFixMeProps, $FlowFixMeState> { onTouchEndCapture={this.handleTouchCapture} onTouchStart={this.flushReactChanges}> {/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This - * comment suppresses an error when upgrading Flow's support for - * React. To see the error delete this comment and run Flow. */} + * comment suppresses an error when upgrading Flow's support for + * React. To see the error delete this comment and run Flow. */} diff --git a/RNTester/js/ProgressBarAndroidExample.android.js b/RNTester/js/ProgressBarAndroidExample.android.js index 02761819c..f88567d8f 100644 --- a/RNTester/js/ProgressBarAndroidExample.android.js +++ b/RNTester/js/ProgressBarAndroidExample.android.js @@ -62,7 +62,7 @@ class ProgressBarAndroidExample extends React.Component<{}> { {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} @@ -72,7 +72,7 @@ class ProgressBarAndroidExample extends React.Component<{}> { {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} diff --git a/RNTester/js/StatusBarExample.js b/RNTester/js/StatusBarExample.js index 258215c83..0e3b06f34 100644 --- a/RNTester/js/StatusBarExample.js +++ b/RNTester/js/StatusBarExample.js @@ -87,10 +87,8 @@ class StatusBarHiddenExample extends React.Component<{}, $FlowFixMeState> { onPress={this._onChangeTransition}> - showHideTransition (ios only): '{getValue( - showHideTransitions, - this._showHideTransitionIndex, - )}' + showHideTransition (ios only): ' + {getValue(showHideTransitions, this._showHideTransitionIndex)}' diff --git a/RNTester/js/TextExample.android.js b/RNTester/js/TextExample.android.js index 1eeeda49c..6198077bd 100644 --- a/RNTester/js/TextExample.android.js +++ b/RNTester/js/TextExample.android.js @@ -477,9 +477,8 @@ class TextExample extends React.Component<{}> { app. - You can disable scaling for your Text component by passing {'"'}allowFontScaling={ - '{' - }false{'}"'} prop. + You can disable scaling for your Text component by passing {'"'} + allowFontScaling={'{'}false{'}"'} prop. This text will not scale.{' '} @@ -642,7 +641,6 @@ const styles = StyleSheet.create({ alignSelf: 'center', }, }); - exports.title = ''; exports.description = 'Base component for rendering styled text.'; exports.examples = [ diff --git a/RNTester/js/TextExample.ios.js b/RNTester/js/TextExample.ios.js index 320854f88..c5a8c0aa9 100644 --- a/RNTester/js/TextExample.ios.js +++ b/RNTester/js/TextExample.ios.js @@ -882,9 +882,8 @@ exports.examples = [ - You can disable scaling for your Text component by passing {'"'}allowFontScaling={ - '{' - }false{'}"'} prop. + You can disable scaling for your Text component by passing {'"'} + allowFontScaling={'{'}false{'}"'} prop. This text will not scale.{' '} diff --git a/RNTester/js/TextInputExample.android.js b/RNTester/js/TextInputExample.android.js index 3f67bb6c3..aaee6d9fb 100644 --- a/RNTester/js/TextInputExample.android.js +++ b/RNTester/js/TextInputExample.android.js @@ -104,7 +104,7 @@ class RewriteExample extends React.Component<$FlowFixMeProps, $FlowFixMeState> { value={this.state.text} /> {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} {remainder} @@ -408,10 +408,10 @@ class AutogrowingTextInputExample extends React.Component<{}> { /> Plain text value representation: {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} {this.state.text} {/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was - * found when making Flow check .android.js files. */} + * found when making Flow check .android.js files. */} Content Size: {JSON.stringify(this.state.contentSize)} ); diff --git a/RNTester/js/TouchableExample.js b/RNTester/js/TouchableExample.js index 8ec4aa3f9..4eaa52f62 100644 --- a/RNTester/js/TouchableExample.js +++ b/RNTester/js/TouchableExample.js @@ -178,7 +178,9 @@ class TouchableFeedbackEvents extends React.Component<{}, $FlowFixMeState> { - {this.state.eventLog.map((e, ii) => {e})} + {this.state.eventLog.map((e, ii) => ( + {e} + ))} ); @@ -217,7 +219,9 @@ class TouchableDelayEvents extends React.Component<{}, $FlowFixMeState> { - {this.state.eventLog.map((e, ii) => {e})} + {this.state.eventLog.map((e, ii) => ( + {e} + ))} ); diff --git a/RNTester/js/XHRExampleDownload.js b/RNTester/js/XHRExampleDownload.js index 4adac0d12..5555bd900 100644 --- a/RNTester/js/XHRExampleDownload.js +++ b/RNTester/js/XHRExampleDownload.js @@ -165,8 +165,8 @@ class XHRExampleDownload extends React.Component<{}, Object> { readystate = ( - responseText: {roundKilo(responseLength)}/{roundKilo(contentLength)}k - chars + responseText: {roundKilo(responseLength)}/{roundKilo(contentLength)} + k chars diff --git a/RNTester/js/XHRExampleFormData.js b/RNTester/js/XHRExampleFormData.js index 7d2d1ec0e..9c2874f59 100644 --- a/RNTester/js/XHRExampleFormData.js +++ b/RNTester/js/XHRExampleFormData.js @@ -52,25 +52,28 @@ class XHRExampleFormData extends React.Component { first: PAGE_SIZE, groupTypes: 'All', assetType: 'All', - }).then(data => { - if (!this._isMounted) { - return; - } - const edges = data.edges; - const edge = edges[Math.floor(Math.random() * edges.length)]; - const randomPhoto = edge && edge.node && edge.node.image; - if (randomPhoto) { - let {width, height} = randomPhoto; - width *= 0.25; - height *= 0.25; - ImageEditor.cropImage( - randomPhoto.uri, - {offset: {x: 0, y: 0}, size: {width, height}}, - uri => this.setState({randomPhoto: {uri}}), - error => undefined, - ); - } - }, error => undefined); + }).then( + data => { + if (!this._isMounted) { + return; + } + const edges = data.edges; + const edge = edges[Math.floor(Math.random() * edges.length)]; + const randomPhoto = edge && edge.node && edge.node.image; + if (randomPhoto) { + let {width, height} = randomPhoto; + width *= 0.25; + height *= 0.25; + ImageEditor.cropImage( + randomPhoto.uri, + {offset: {x: 0, y: 0}, size: {width, height}}, + uri => this.setState({randomPhoto: {uri}}), + error => undefined, + ); + } + }, + error => undefined, + ); }; _addTextParam = () => { @@ -166,11 +169,11 @@ class XHRExampleFormData extends React.Component { - Random photo from your library ( + Random photo from your library ( + update - ) + + ) {image} diff --git a/ReactAndroid/src/androidTest/js/MultitouchHandlingTestAppModule.js b/ReactAndroid/src/androidTest/js/MultitouchHandlingTestAppModule.js index 1eeebc78a..133161767 100644 --- a/ReactAndroid/src/androidTest/js/MultitouchHandlingTestAppModule.js +++ b/ReactAndroid/src/androidTest/js/MultitouchHandlingTestAppModule.js @@ -23,8 +23,8 @@ const extractSingleTouch = nativeEvent => { return !hasTouches && hasChangedTouches ? changedTouches[0] : hasTouches - ? touches[0] - : nativeEvent; + ? touches[0] + : nativeEvent; }; class TouchTestApp extends React.Component { diff --git a/ReactAndroid/src/androidTest/js/UIManagerTestModule.js b/ReactAndroid/src/androidTest/js/UIManagerTestModule.js index 5e0613c0d..4b75deb37 100644 --- a/ReactAndroid/src/androidTest/js/UIManagerTestModule.js +++ b/ReactAndroid/src/androidTest/js/UIManagerTestModule.js @@ -90,9 +90,7 @@ const FlexWithTextStyles = StyleSheet.create({ }); type AbsolutePositionTestAppProps = $ReadOnly<{||}>; -class AbsolutePositionTestApp extends React.Component< - AbsolutePositionTestAppProps, -> { +class AbsolutePositionTestApp extends React.Component { render() { return ( ; -class AbsolutePositionBottomRightTestApp extends React.Component< - AbsolutePositionBottomRightTestAppProps, -> { +class AbsolutePositionBottomRightTestApp extends React.Component { render() { return ( */ = plugins.haste.providesModuleNodeModules.map( +const pluginRoots /*: Array */ = plugins.haste.providesModuleNodeModules.map( name => path.resolve(__dirname, '../../', name) + path.sep, ); diff --git a/package.json b/package.json index 9092a0c38..97150122d 100644 --- a/package.json +++ b/package.json @@ -130,7 +130,7 @@ "jest": "24.1.0", "jest-junit": "6.3.0", "jscodeshift": "^0.6.2", - "prettier": "1.13.6", + "prettier": "1.16.4", "react": "16.8.3", "react-native-dummy": "0.2.0", "react-test-renderer": "16.8.3", diff --git a/packages/eslint-config-react-native-community/package.json b/packages/eslint-config-react-native-community/package.json index f190bec1f..a3c4e4601 100644 --- a/packages/eslint-config-react-native-community/package.json +++ b/packages/eslint-config-react-native-community/package.json @@ -16,7 +16,7 @@ "eslint-plugin-react": "7.8.2", "eslint-plugin-react-hooks": "^1.0.1", "eslint-plugin-react-native": "3.5.0", - "prettier": "1.13.6" + "prettier": "1.16.4" }, "peerDependencies": { "eslint": ">=5" diff --git a/packages/eslint-config-react-native-community/yarn.lock b/packages/eslint-config-react-native-community/yarn.lock index 7da6303f5..99983b2aa 100644 --- a/packages/eslint-config-react-native-community/yarn.lock +++ b/packages/eslint-config-react-native-community/yarn.lock @@ -840,10 +840,10 @@ prelude-ls@~1.1.2: resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54" integrity sha1-IZMqVJ9eUv/ZqCf1cOBL5iqX2lQ= -prettier@1.13.6: - version "1.13.6" - resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.13.6.tgz#00ae0b777ad92f81a9e7a1df2f0470b6dab0cb44" - integrity sha512-p5eqCNiohWZN++7aJXUVj0JgLqHCPLf9GLIcLBHGNWs4Y9FJOPs6+KNO2WT0udJIQJTbeZFrJkjzjcb8fkAYYQ== +prettier@1.16.4: + version "1.16.4" + resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.16.4.tgz#73e37e73e018ad2db9c76742e2647e21790c9717" + integrity sha512-ZzWuos7TI5CKUeQAtFd6Zhm2s6EpAD/ZLApIhsF9pRvRtM1RFo61dM/4MSRUA0SuLugA/zgrZD8m0BaY46Og7g== progress@^2.0.0: version "2.0.3" diff --git a/scripts/circleci/code-analysis-bot.js b/scripts/circleci/code-analysis-bot.js index 32c726b7c..1a791933c 100644 --- a/scripts/circleci/code-analysis-bot.js +++ b/scripts/circleci/code-analysis-bot.js @@ -235,24 +235,26 @@ function main(messages, owner, repo, number) { getFilesFromPullRequest(owner, repo, number, files => { let comments = []; let convertersUsed = []; - files.filter(file => messages[file.filename]).forEach(file => { - // github api sometimes does not return a patch on large commits - if (!file.patch) { - return; - } - const lineMap = getLineMapFromPatch(file.patch); - messages[file.filename].forEach(message => { - if (lineMap[message.line]) { - const comment = { - path: file.filename, - position: lineMap[message.line], - body: message.message, - }; - convertersUsed.push(message.converter); - comments.push(comment); + files + .filter(file => messages[file.filename]) + .forEach(file => { + // github api sometimes does not return a patch on large commits + if (!file.patch) { + return; } - }); // forEach - }); // filter + const lineMap = getLineMapFromPatch(file.patch); + messages[file.filename].forEach(message => { + if (lineMap[message.line]) { + const comment = { + path: file.filename, + position: lineMap[message.line], + body: message.message, + }; + convertersUsed.push(message.converter); + comments.push(comment); + } + }); // forEach + }); // filter let body = '**Code analysis results:**\n\n'; const uniqueconvertersUsed = [...new Set(convertersUsed)]; diff --git a/yarn.lock b/yarn.lock index 0d5d4b6b6..b9d5a79cb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5566,10 +5566,10 @@ preserve@^0.2.0: resolved "https://registry.yarnpkg.com/preserve/-/preserve-0.2.0.tgz#815ed1f6ebc65926f865b310c0713bcb3315ce4b" integrity sha1-gV7R9uvGWSb4ZbMQwHE7yzMVzks= -prettier@1.13.6: - version "1.13.6" - resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.13.6.tgz#00ae0b777ad92f81a9e7a1df2f0470b6dab0cb44" - integrity sha512-p5eqCNiohWZN++7aJXUVj0JgLqHCPLf9GLIcLBHGNWs4Y9FJOPs6+KNO2WT0udJIQJTbeZFrJkjzjcb8fkAYYQ== +prettier@1.16.4: + version "1.16.4" + resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.16.4.tgz#73e37e73e018ad2db9c76742e2647e21790c9717" + integrity sha512-ZzWuos7TI5CKUeQAtFd6Zhm2s6EpAD/ZLApIhsF9pRvRtM1RFo61dM/4MSRUA0SuLugA/zgrZD8m0BaY46Og7g== pretty-format@24.0.0-alpha.6: version "24.0.0-alpha.6"