From dbe60440747867272fcdfbb9f0ac4f258e508cc8 Mon Sep 17 00:00:00 2001 From: Gustavo Gard Date: Mon, 9 Oct 2017 22:15:45 -0700 Subject: [PATCH] Correct propTypes for placeholder Summary: Proptype mistake, placeholder is a "string" not a "node". https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Text/RCTBackedTextInputViewProtocol.h#L18 https://github.com/facebook/react-native/blob/4d54b48167c99d0f3a8917e7637ffe3304c6bed6/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L300 Closes https://github.com/facebook/react-native/pull/16237 Differential Revision: D6017909 Pulled By: shergin fbshipit-source-id: 75046080a0f33196832f5d4ab58f8b1f4aabad1f --- Libraries/Components/TextInput/TextInput.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js index df27defa6..4cce22b23 100644 --- a/Libraries/Components/TextInput/TextInput.js +++ b/Libraries/Components/TextInput/TextInput.js @@ -430,7 +430,7 @@ const TextInput = createReactClass({ /** * The string that will be rendered before text input has been entered. */ - placeholder: PropTypes.node, + placeholder: PropTypes.string, /** * The text color of the placeholder string. */