kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-01 06:22:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change the signature of onDropViewInstance. issue #5053

Browse Source 
Summary:
https://github.com/facebook/react-native/issues/5053
Closes https://github.com/facebook/react-native/pull/5125

Reviewed By: svcscm

Differential Revision: D2807202

Pulled By: foghina

fb-gh-sync-id: 1e268c940a08aa7bf243971ba91d4595973f12af
This commit is contained in:
SangYeob Bono Yu
2016-01-06 06:56:49 -08:00
committed by facebook-github-bot-9
parent 1bfd267acb
commit daa93a6222
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ReactAndroid/src/main/java/com/facebook/react/views/webview/ReactWebViewManager.java
View File

@@ -323,9 +323,9 @@ public class ReactWebViewManager extends SimpleViewManager<WebView> {
}
@Override
public void onDropViewInstance(ThemedReactContext reactContext, WebView webView) {
super.onDropViewInstance(reactContext, webView);
reactContext.removeLifecycleEventListener((ReactWebView) webView);
public void onDropViewInstance(WebView webView) {
super.onDropViewInstance(webView);
((ThemedReactContext) webView.getContext()).removeLifecycleEventListener((ReactWebView) webView);
((ReactWebView) webView).cleanupCallbacksAndDestroy();
}
}