diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java index 4f895abf3..b4431c0d6 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java @@ -14,10 +14,6 @@ import com.facebook.soloader.SoLoader; @DoNotStrip public class JSCJavaScriptExecutor extends JavaScriptExecutor { - static { - ReactBridge.staticInit(); - } - public static class Factory implements JavaScriptExecutor.Factory { @Override public JavaScriptExecutor create(WritableNativeMap jscConfig) throws Exception { @@ -25,6 +21,10 @@ public class JSCJavaScriptExecutor extends JavaScriptExecutor { } } + static { + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); + } + public JSCJavaScriptExecutor(WritableNativeMap jscConfig) { initialize(jscConfig); } diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeArray.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeArray.java index d4c46f723..2045a4b23 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeArray.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeArray.java @@ -19,7 +19,7 @@ import com.facebook.soloader.SoLoader; @DoNotStrip public abstract class NativeArray { static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } protected NativeArray(HybridData hybridData) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeMap.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeMap.java index 9e192dc4e..2c683f945 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeMap.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeMap.java @@ -19,7 +19,7 @@ import com.facebook.soloader.SoLoader; @DoNotStrip public abstract class NativeMap { static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } public NativeMap(HybridData hybridData) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java index 6ebf4dc0d..37d83b338 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java @@ -24,10 +24,6 @@ import com.facebook.proguard.annotations.DoNotStrip; */ @DoNotStrip public class ProxyJavaScriptExecutor extends JavaScriptExecutor { - static { - ReactBridge.staticInit(); - } - public static class Factory implements JavaScriptExecutor.Factory { private final JavaJSExecutor.Factory mJavaJSExecutorFactory; @@ -41,6 +37,10 @@ public class ProxyJavaScriptExecutor extends JavaScriptExecutor { } } + static { + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); + } + private @Nullable JavaJSExecutor mJavaJSExecutor; /** diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java index 6cf4170d4..e4d43f90b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java @@ -24,22 +24,16 @@ import com.facebook.soloader.SoLoader; @DoNotStrip public class ReactBridge extends Countable { - private static final String REACT_NATIVE_LIB = "reactnativejni"; - private static final String XREACT_NATIVE_LIB = "reactnativejnifb"; + /* package */ static final String REACT_NATIVE_LIB = "reactnativejni"; static { SoLoader.loadLibrary(REACT_NATIVE_LIB); - SoLoader.loadLibrary(XREACT_NATIVE_LIB); } private final ReactCallback mCallback; private final JavaScriptExecutor mJSExecutor; private final MessageQueueThread mNativeModulesQueueThread; - public static void staticInit() { - // This is just called to ensure that ReactBridge's static initialization has taken place. - } - /** * @param jsExecutor the JS executor to use to run JS * @param callback the callback class used to invoke native modules diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java index 2f81d301b..4cd1b7581 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java @@ -21,8 +21,9 @@ import java.util.ArrayList; */ @DoNotStrip public class ReadableNativeArray extends NativeArray implements ReadableArray { + static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } protected ReadableNativeArray(HybridData hybridData) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeMap.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeMap.java index ea289ac66..f3782ca08 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeMap.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeMap.java @@ -22,8 +22,9 @@ import java.util.HashMap; */ @DoNotStrip public class ReadableNativeMap extends NativeMap implements ReadableMap { + static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } protected ReadableNativeMap(HybridData hybridData) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeArray.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeArray.java index e6c343264..26fe2dd11 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeArray.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeArray.java @@ -21,8 +21,9 @@ import com.facebook.soloader.SoLoader; */ @DoNotStrip public class WritableNativeArray extends ReadableNativeArray implements WritableArray { + static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } public WritableNativeArray() { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeMap.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeMap.java index 6b6c639d2..d30827ade 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeMap.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeMap.java @@ -22,7 +22,7 @@ import com.facebook.soloader.SoLoader; @DoNotStrip public class WritableNativeMap extends ReadableNativeMap implements WritableMap { static { - ReactBridge.staticInit(); + SoLoader.loadLibrary(ReactBridge.REACT_NATIVE_LIB); } @Override diff --git a/ReactAndroid/src/main/jni/react/jni/Android.mk b/ReactAndroid/src/main/jni/react/jni/Android.mk index 06266de37..742e2161d 100644 --- a/ReactAndroid/src/main/jni/react/jni/Android.mk +++ b/ReactAndroid/src/main/jni/react/jni/Android.mk @@ -11,8 +11,15 @@ LOCAL_SRC_FILES := \ JSLoader.cpp \ JSLogging.cpp \ JniJSModulesUnbundle.cpp \ + NativeArray.cpp \ + NativeCommon.cpp \ + NativeMap.cpp \ OnLoad.cpp \ ProxyExecutor.cpp \ + ReadableNativeArray.cpp \ + ReadableNativeMap.cpp \ + WritableNativeArray.cpp \ + WritableNativeMap.cpp \ LOCAL_C_INCLUDES := $(LOCAL_PATH) LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../.. $(LOCAL_PATH)/.. @@ -23,7 +30,7 @@ LOCAL_CFLAGS += $(CXX11_FLAGS) LOCAL_EXPORT_CPPFLAGS := $(CXX11_FLAGS) LOCAL_LDLIBS += -landroid -LOCAL_SHARED_LIBRARIES := libfolly_json libfb libjsc libglog_init libreactnativejnifb +LOCAL_SHARED_LIBRARIES := libfolly_json libfb libjsc libglog_init LOCAL_STATIC_LIBRARIES := libreactnative include $(BUILD_SHARED_LIBRARY) @@ -34,4 +41,3 @@ $(call import-module,folly) $(call import-module,fbgloginit) $(call import-module,fb) $(call import-module,jsc) -$(call import-module,xreact/jni) diff --git a/ReactAndroid/src/main/jni/react/jni/BUCK b/ReactAndroid/src/main/jni/react/jni/BUCK index e210b9dd9..9bd754fb7 100644 --- a/ReactAndroid/src/main/jni/react/jni/BUCK +++ b/ReactAndroid/src/main/jni/react/jni/BUCK @@ -18,7 +18,6 @@ def jni_library(**kwargs): ], deps = DEPS + JSC_DEPS + [ react_native_target('jni/react:react'), - react_native_target('jni/xreact/jni:jni'), ], **kwargs ) @@ -34,8 +33,15 @@ jni_library( 'JSLoader.cpp', 'JSLogging.cpp', 'JniJSModulesUnbundle.cpp', + 'NativeArray.cpp', + 'NativeCommon.cpp', + 'NativeMap.cpp', 'OnLoad.cpp', 'ProxyExecutor.cpp', + 'ReadableNativeArray.cpp', + 'ReadableNativeMap.cpp', + 'WritableNativeArray.cpp', + 'WritableNativeMap.cpp', ], headers = [ 'JSLoader.h', @@ -50,6 +56,13 @@ jni_library( 'WebWorkers.h', ], exported_headers = [ + 'NativeCommon.h', + 'NativeArray.h', + 'NativeMap.h', + 'ReadableNativeArray.h', + 'ReadableNativeMap.h', + 'WritableNativeArray.h', + 'WritableNativeMap.h', ], preprocessor_flags = [ '-DLOG_TAG="ReactNativeJNI"', diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/NativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeArray.h b/ReactAndroid/src/main/jni/react/jni/NativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeArray.h rename to ReactAndroid/src/main/jni/react/jni/NativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeCommon.cpp b/ReactAndroid/src/main/jni/react/jni/NativeCommon.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeCommon.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeCommon.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeCommon.h b/ReactAndroid/src/main/jni/react/jni/NativeCommon.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeCommon.h rename to ReactAndroid/src/main/jni/react/jni/NativeCommon.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/NativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeMap.h b/ReactAndroid/src/main/jni/react/jni/NativeMap.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeMap.h rename to ReactAndroid/src/main/jni/react/jni/NativeMap.h diff --git a/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp b/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp index 63fee9557..8d60719c4 100644 --- a/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp +++ b/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp @@ -22,6 +22,8 @@ #include "JExecutorTokenFactory.h" #include "JNativeRunnable.h" #include "JSLoader.h" +#include "NativeCommon.h" +#include "ReadableNativeArray.h" #include "ProxyExecutor.h" #include "OnLoad.h" #include "JMessageQueueThread.h" @@ -29,9 +31,7 @@ #include "JSLogging.h" #include "JSCPerfLogging.h" #include "WebWorkers.h" - -#include -#include +#include "WritableNativeMap.h" #include #ifdef WITH_FBSYSTRACE @@ -456,9 +456,17 @@ extern "C" JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { PerfLogging::installNativeHooks = addNativePerfLoggingHooks; JSLogging::nativeHook = nativeLoggingHook; + NativeArray::registerNatives(); + ReadableNativeArray::registerNatives(); + WritableNativeArray::registerNatives(); JNativeRunnable::registerNatives(); registerJSLoaderNatives(); + NativeMap::registerNatives(); + ReadableNativeMap::registerNatives(); + WritableNativeMap::registerNatives(); + ReadableNativeMapKeySetIterator::registerNatives(); + registerNatives("com/facebook/react/bridge/JSCJavaScriptExecutor", { makeNativeMethod("initialize", executors::createJSCExecutor), }); diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.h b/ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.h rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.h b/ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.h rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/WritableNativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.h b/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.h rename to ReactAndroid/src/main/jni/react/jni/WritableNativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/WritableNativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/WritableNativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.h b/ReactAndroid/src/main/jni/react/jni/WritableNativeMap.h similarity index 96% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.h rename to ReactAndroid/src/main/jni/react/jni/WritableNativeMap.h index 1fc942a02..cf9cd95a0 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.h +++ b/ReactAndroid/src/main/jni/react/jni/WritableNativeMap.h @@ -20,7 +20,6 @@ struct WritableNativeMap : jni::HybridClass initHybrid(jni::alias_ref); - __attribute__((visibility("default"))) folly::dynamic consume(); void putNull(std::string key); diff --git a/ReactAndroid/src/main/jni/xreact/jni/Android.mk b/ReactAndroid/src/main/jni/xreact/jni/Android.mk index 4eb04b448..c0078c36a 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/Android.mk +++ b/ReactAndroid/src/main/jni/xreact/jni/Android.mk @@ -9,21 +9,14 @@ LOCAL_SRC_FILES := \ CxxModuleWrapper.cpp \ JExecutorToken.cpp \ JMessageQueueThread.cpp \ + JniJSModulesUnbundle.cpp \ JSCPerfLogging.cpp \ JSLoader.cpp \ JSLogging.cpp \ - JniJSModulesUnbundle.cpp \ MethodInvoker.cpp \ ModuleRegistryHolder.cpp \ - NativeArray.cpp \ - NativeCommon.cpp \ - NativeMap.cpp \ OnLoad.cpp \ ProxyExecutor.cpp \ - ReadableNativeArray.cpp \ - ReadableNativeMap.cpp \ - WritableNativeArray.cpp \ - WritableNativeMap.cpp \ LOCAL_C_INCLUDES := $(LOCAL_PATH) LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../.. @@ -34,7 +27,7 @@ LOCAL_CFLAGS += $(CXX11_FLAGS) LOCAL_EXPORT_CPPFLAGS := $(CXX11_FLAGS) LOCAL_LDLIBS += -landroid -LOCAL_SHARED_LIBRARIES := libfolly_json libfbjni libjsc libglog_init +LOCAL_SHARED_LIBRARIES := libfolly_json libfbjni libjsc libglog_init libreactnativejni LOCAL_STATIC_LIBRARIES := libreactnativefb include $(BUILD_SHARED_LIBRARY) @@ -44,3 +37,4 @@ $(call import-module,jsc) $(call import-module,folly) $(call import-module,fbgloginit) $(call import-module,jsc) +$(call import-module,react/jni) diff --git a/ReactAndroid/src/main/jni/xreact/jni/BUCK b/ReactAndroid/src/main/jni/xreact/jni/BUCK index cb47fa436..ea88102d0 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/BUCK +++ b/ReactAndroid/src/main/jni/xreact/jni/BUCK @@ -5,25 +5,19 @@ SUPPORTED_PLATFORMS = '^android-(armv7|x86)$' EXPORTED_HEADERS = [ 'CxxModuleWrapper.h', - 'NativeArray.h', - 'NativeCommon.h', - 'NativeMap.h', - 'ReadableNativeArray.h', - 'ReadableNativeMap.h', - 'WritableNativeArray.h', - 'WritableNativeMap.h', ] cxx_library( name='jni', soname = 'libreactnativejnifb.so', - header_namespace = 'xreact/jni', + header_namespace = 'react/jni', supported_platforms_regex = SUPPORTED_PLATFORMS, deps = JSC_DEPS + [ '//native/fb:fb', '//native/third-party/android-ndk:android', '//xplat/folly:molly', '//xplat/fbsystrace:fbsystrace', + react_native_target('jni/react/jni:jni'), react_native_xplat_target('cxxreact:bridge'), react_native_xplat_target('cxxreact:module'), ], diff --git a/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp b/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp index 64fa80f98..c4c6faa74 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp @@ -13,6 +13,8 @@ #include #include +#include + #include #include #include @@ -21,7 +23,6 @@ #include "JavaScriptExecutorHolder.h" #include "JniJSModulesUnbundle.h" #include "ModuleRegistryHolder.h" -#include "NativeArray.h" #include "JNativeRunnable.h" using namespace facebook::jni; diff --git a/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp b/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp index 9267d876e..d1532fd10 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp @@ -2,11 +2,16 @@ #include "CxxModuleWrapper.h" +#include + #include #include #include #include +#include +#include + #include #include @@ -15,12 +20,6 @@ #include #include -#include -#include - -#include "ReadableNativeArray.h" - - using namespace facebook::jni; using namespace facebook::xplat::module; using namespace facebook::react; diff --git a/ReactAndroid/src/main/jni/xreact/jni/JCallback.h b/ReactAndroid/src/main/jni/xreact/jni/JCallback.h index 1d1393eb9..539273104 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/JCallback.h +++ b/ReactAndroid/src/main/jni/xreact/jni/JCallback.h @@ -7,7 +7,7 @@ #include #include -#include "NativeArray.h" +#include namespace facebook { namespace react { diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp b/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp index 1dd837db8..1b7b5e688 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp @@ -2,10 +2,9 @@ #include "JSCPerfLogging.h" -#include - #include #include +#include using namespace facebook::jni; diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp b/ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp index a27d3f5d3..7690a5656 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp @@ -4,10 +4,9 @@ #include #include +#include #include -#include - namespace facebook { namespace react { diff --git a/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp b/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp index e7d3d2c2d..218f6c9d0 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp @@ -2,6 +2,7 @@ #include "MethodInvoker.h" +#include #ifdef WITH_FBSYSTRACE #include #endif @@ -9,7 +10,6 @@ #include "ModuleRegistryHolder.h" #include "JCallback.h" #include "JExecutorToken.h" -#include "ReadableNativeArray.h" namespace facebook { namespace react { diff --git a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.cpp b/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.cpp index eebed41df..29349f741 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.cpp @@ -10,10 +10,11 @@ #include #include #include +#include + +#include "MethodInvoker.h" #include "CatalystInstanceImpl.h" -#include "MethodInvoker.h" -#include "ReadableNativeArray.h" using facebook::xplat::module::CxxModule; diff --git a/ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp b/ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp index 952a6b46c..3242c59ca 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp +++ b/ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp @@ -7,6 +7,7 @@ #include #include #include +#include #include "CatalystInstanceImpl.h" #include "JavaScriptExecutorHolder.h" #include "JSCPerfLogging.h" @@ -16,9 +17,6 @@ #include "WebWorkers.h" #include "JCallback.h" -#include "WritableNativeMap.h" -#include "WritableNativeArray.h" - #include using namespace facebook::jni; @@ -182,14 +180,6 @@ extern "C" JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { CxxModuleWrapper::registerNatives(); JCallbackImpl::registerNatives(); registerJSLoaderNatives(); - - NativeArray::registerNatives(); - ReadableNativeArray::registerNatives(); - WritableNativeArray::registerNatives(); - NativeMap::registerNatives(); - ReadableNativeMap::registerNatives(); - WritableNativeMap::registerNatives(); - ReadableNativeMapKeySetIterator::registerNatives(); }); }