kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-23 03:50:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

JSBigString: Explicitly include unistd.h (#22330)

Browse Source 
Summary:
`JSBigString` is using functions from `unistd.h`, like `getpagesize`, `dup`, `open`, etc. but was not directly including it.

It was being included from inside the glog `logging.h` header, which in turn was getting included by the Folly headers `JSBigString` was using.

This was discovered while building CxxReact with a custom shimmed Glog.
Pull Request resolved: https://github.com/facebook/react-native/pull/22330

Differential Revision: D13115346

Pulled By: shergin

fbshipit-source-id: 9fe4e3b28f74c0ca351ac6308484e375eace4db4
This commit is contained in:
empyrical
2018-11-28 16:40:16 -08:00
committed by Facebook Github Bot
parent c293f29f57
commit d6d31a4b66
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ReactCommon/cxxreact/JSBigString.h
View File

@@ -7,6 +7,7 @@
#include <fcntl.h>
#include <sys/mman.h>
#include <unistd.h>
#include <folly/Exception.h>