mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-04-24 12:25:59 +08:00
BREAKING [react_native] Move to new C-based implementation of css-layout in RN Android
Summary: Moves from CSSNodeDEPRECATED to CSSNode. This has shown to be a huge performance win for layout time within FB. This is BREAKING because CSSNode contains bug fixes that were not migrated to CSSNodeDEPRECATED which may change the way your layout appears. The most common of these by far involves `flex: 1`. Previously, developers had to put `flex: 1` in many places it didn't belong in order to work around a bug in css-layout. Now `flex: 1` is treated properly and, unfortunately, this means that your layout may no longer look correct. Specifically, you may see that your layout looks collapsed, or children don't render. The fix is to simply remove `flex: 1` from those containers. Reviewed By: emilsjolander Differential Revision: D3992787 fbshipit-source-id: 7a3a2a34a8941c0524e6ba3c5379e434d3e03247
This commit is contained in:
committed by
Facebook Github Bot
parent
27817bed0e
commit
d63ba47b59
18
ReactCommon/CSSLayout/BUCK
Normal file
18
ReactCommon/CSSLayout/BUCK
Normal file
@@ -0,0 +1,18 @@
|
||||
cxx_library(
|
||||
name = 'CSSLayout',
|
||||
force_static = True,
|
||||
srcs = glob(['CSSLayout/*.c']),
|
||||
header_namespace = '',
|
||||
compiler_flags = [
|
||||
'-fno-omit-frame-pointer',
|
||||
'-fexceptions',
|
||||
'-Wall',
|
||||
'-Werror',
|
||||
'-std=c99',
|
||||
'-O3',
|
||||
],
|
||||
exported_headers = glob(['CSSLayout/*.h']),
|
||||
deps = [
|
||||
],
|
||||
visibility = ['PUBLIC'],
|
||||
)
|
||||
Reference in New Issue
Block a user