From d1622176094300c2426607ddf951506e5cb62f72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Mon, 17 Dec 2018 15:40:41 -0800 Subject: [PATCH] Rearrange PR Template (#22683) Summary: This ensures the changelog is captured as part of the commit description, and not the test plan, when the PR is imported into Phabricator Pull Request resolved: https://github.com/facebook/react-native/pull/22683 Differential Revision: D13498624 Pulled By: hramos fbshipit-source-id: 59a7e7e8c6f76973d3cfb97dea0e56af43673a9b --- .github/PULL_REQUEST_TEMPLATE.md | 41 +++++--------------------------- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8f8446dfe..f6e97493a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,45 +1,16 @@ Thank you for sending the PR! We appreciate you spending the time to work on these changes. -Help us understand your motivation by explaining why you decided to make this change. +Help us understand your motivation by explaining why you decided to make this change: -If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. - -_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ - -Test Plan: ----------- -Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! Changelog: ---------- -Help reviewers and the release process by writing your own changelog entry. When the change doesn't impact React Native developers, it may be ommitted from the changelog for brevity. See below for an example. + +Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [CATEGORY] [TYPE] - Message - \ No newline at end of file +Write your test plan here (**REQUIRED**). If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! Increase test coverage whenever possible.