kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-30 18:24:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Danger, be nice to PRs. (#23334)

Browse Source 
Summary:
Changed Danger's config so that it provides advice whenever it finds an issue with the pull request template, instead of posting a warning.

Updated Danger several major versions, from 2 to 7. I worked through any breaking changes, which were minimal (change `yarn danger` to `yarn danger ci`).

Added a flag to have Danger post these messages as GitHub Checks instead of as a comment. This slightly buries Danger's output, as it's no longer posted as a comment, but I believe it integrates more nicely into the GitHub interface.

[GENERAL] [Changed] - GitHub-only change: updated Danger config to be nicer to PRs
Pull Request resolved: https://github.com/facebook/react-native/pull/23334

Differential Revision: D14002313

Pulled By: cpojer

fbshipit-source-id: b97ca7b7bd164646b249b7c64b1134306e0f38a8
This commit is contained in:
Héctor Ramos
2019-02-08 03:33:33 -08:00
committed by Facebook Github Bot
parent af41a53500
commit d002d30325
4 changed files with 961 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bots/package.json
View File

@@ -4,7 +4,7 @@
"danger": "node ./node_modules/.bin/danger"
},
"devDependencies": {
"danger": "^2.1.6",
"danger": "^7.0.8",
"lodash.includes": "^4.3.0",
"minimatch": "^3.0.4"
}