From cf22111cee481ed436d4e0bca478b74ce24567a7 Mon Sep 17 00:00:00 2001 From: Tadeu Zagallo Date: Thu, 30 Jul 2015 03:02:57 -0700 Subject: [PATCH] [ReactNative] Prevent RCTDevLoadingView from creating UIWindow on unit tests Summary: `RCTDevLoadingView` was being created from a constructor function and creating a `UIWindow` when the bridge started loading. The `UIWindow` was crashing on the unit tests since there's no host app. --- React/Base/RCTDevLoadingView.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/React/Base/RCTDevLoadingView.m b/React/Base/RCTDevLoadingView.m index 1bb832412..4a2260adb 100644 --- a/React/Base/RCTDevLoadingView.m +++ b/React/Base/RCTDevLoadingView.m @@ -12,6 +12,7 @@ #import "RCTBridge.h" #import "RCTDevLoadingView.h" #import "RCTDefines.h" +#import "RCTUtils.h" #if RCT_DEV @@ -40,7 +41,7 @@ static void RCTDevLoadingViewSetup() - (instancetype)init { - if (self = [super init]) { + if ((self = [super init]) && !RCTRunningInTestEnvironment()) { [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(willStartLoading:) name:RCTJavaScriptWillStartLoadingNotification