From cd06228f7a2d9ed4a9a9e57917ba0c748ef5deb7 Mon Sep 17 00:00:00 2001 From: Emil Sjolander Date: Mon, 11 Apr 2016 14:54:55 -0700 Subject: [PATCH] backout update of css-layout. breaks ios <9 Summary: Backed out changeset 29fa5aef3dbcc12d63c01d211b32bb598caadd0d and 56cc13ffbc4805aa0789df62a04e19f23a438bd3. Reviewed By: javache Differential Revision: D3164127 --- .../main/java/com/facebook/react/flat/RCTText.java | 12 +++--------- .../java/com/facebook/react/flat/RCTTextInput.java | 9 +-------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java index 6564f284a..c7c8025ef 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java @@ -18,7 +18,6 @@ import android.text.StaticLayout; import android.text.TextPaint; import android.text.TextUtils; -import com.facebook.csslayout.CSSMeasureMode; import com.facebook.csslayout.CSSNode; import com.facebook.csslayout.MeasureOutput; import com.facebook.csslayout.Spacing; @@ -68,13 +67,7 @@ import com.facebook.react.uimanager.annotations.ReactProp; } @Override - public void measure( - CSSNode node, - float width, - CSSMeasureMode widthMode, - float height, - CSSMeasureMode heightMode, - MeasureOutput measureOutput) { + public void measure(CSSNode node, float width, float height, MeasureOutput measureOutput) { CharSequence text = getText(); if (TextUtils.isEmpty(text)) { // to indicate that we don't have anything to display @@ -87,7 +80,8 @@ import com.facebook.react.uimanager.annotations.ReactProp; mText = text; // technically, width should never be negative, but there is currently a bug in - boolean unconstrainedWidth = widthMode == CSSMeasureMode.UNDEFINED || width < 0; + // LayoutEngine where a negative value can be passed. + boolean unconstrainedWidth = Float.isNaN(width) || width < 0; BoringLayout.Metrics metrics = BoringLayout.isBoring(text, PAINT, sBoringLayoutMetrics); if (metrics != null) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java index 375329ac1..076d4d61c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java @@ -16,7 +16,6 @@ import android.util.TypedValue; import android.view.ViewGroup; import android.widget.EditText; -import com.facebook.csslayout.CSSMeasureMode; import com.facebook.csslayout.CSSNode; import com.facebook.csslayout.MeasureOutput; import com.facebook.csslayout.Spacing; @@ -71,13 +70,7 @@ public class RCTTextInput extends RCTVirtualText implements AndroidView, CSSNode } @Override - public void measure( - CSSNode node, - float width, - CSSMeasureMode widthMode, - float height, - CSSMeasureMode heightMode, - MeasureOutput measureOutput) { + public void measure(CSSNode node, float width, float height, MeasureOutput measureOutput) { // measure() should never be called before setThemedContext() EditText editText = Assertions.assertNotNull(mEditText);