kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-29 04:35:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove accessibilityTraits prop (accessibility) (#24643)

Browse Source 
Summary:
`accessibilityTraits` and `accessibilityComponentType` were removed on #24344. This PR removes `accessibilityTraits` prop from Fabric as well.

[General] [Removed] - Remove `accessibilityTraits` prop from Fabric.
Pull Request resolved: https://github.com/facebook/react-native/pull/24643

Differential Revision: D15120193

Pulled By: cpojer

fbshipit-source-id: 98440ac447569c26205fc38b93ce2591ccf1a3cf
This commit is contained in:
Estevão Lucas
2019-04-29 03:14:32 -07:00
committed by Facebook Github Bot
parent bb6f316c87
commit ca9a55e28b
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View File

@@ -221,12 +221,6 @@ using namespace facebook::react;
self.accessibilityElement.accessibilityHint = RCTNSStringFromStringNilIfEmpty(newViewProps.accessibilityHint); self.accessibilityElement.accessibilityHint = RCTNSStringFromStringNilIfEmpty(newViewProps.accessibilityHint);
} }
// `accessibilityTraits`
if (oldViewProps.accessibilityTraits != newViewProps.accessibilityTraits) {
self.accessibilityElement.accessibilityTraits =
RCTUIAccessibilityTraitsFromAccessibilityTraits(newViewProps.accessibilityTraits);
}
// `accessibilityViewIsModal` // `accessibilityViewIsModal`
if (oldViewProps.accessibilityViewIsModal != newViewProps.accessibilityViewIsModal) { if (oldViewProps.accessibilityViewIsModal != newViewProps.accessibilityViewIsModal) {
self.accessibilityElement.accessibilityViewIsModal = newViewProps.accessibilityViewIsModal; self.accessibilityElement.accessibilityViewIsModal = newViewProps.accessibilityViewIsModal;

4
ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp
View File

@@ -20,10 +20,6 @@ AccessibilityProps::AccessibilityProps(
const RawProps &rawProps) const RawProps &rawProps)
: accessible( : accessible(
convertRawProp(rawProps, "accessible", sourceProps.accessible)), convertRawProp(rawProps, "accessible", sourceProps.accessible)),
accessibilityTraits(convertRawProp(
rawProps,
"accessibilityTraits",
sourceProps.accessibilityTraits)),
accessibilityLabel(convertRawProp( accessibilityLabel(convertRawProp(
rawProps, rawProps,
"accessibilityLabel", "accessibilityLabel",