Fix Text incorrect line height

Summary:
Setting the line height with the help of Android-provided StaticLayout is incorrect. A
simple example app will display the following when `setLineSpacing(50.f, 0.f)`
is set: {F62987699}. You'll notice that the height of the first line is a few
pixels shorter than the other lines.
So we use a custom LineHeightSpan instead, which needs to be applied to the text
itself, and no height-related attributes need to be set on the TextView itself.

Reviewed By: lexs

Differential Revision: D3841658

fbshipit-source-id: 7257df4f1b2ce037554c7a7a5ca8f547a2056939
This commit is contained in:
Andrei Coman
2016-09-12 05:03:27 -07:00
committed by Facebook Github Bot 1
parent 16bdbee165
commit c79f617742
5 changed files with 66 additions and 35 deletions

View File

@@ -129,7 +129,6 @@ public class ReactTextInputShadowNode extends ReactTextShadowNode implements
mJsEventCount,
mContainsImages,
getPadding(),
getEffectiveLineHeight(),
mTextAlign
);
uiViewOperationQueue.enqueueUpdateExtraData(getReactTag(), reactTextUpdate);