kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-01 14:25:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Convert modules to use @ReactModule instead of getName()

Browse Source 
Reviewed By: astreet

Differential Revision: D3334273

fbshipit-source-id: a33bf72c5c184844885ef3ef610a05d9c102c8ea
This commit is contained in:
Aaron Chiu
2016-08-11 15:43:35 -07:00
committed by Facebook Github Bot 2
parent 9965642ebc
commit c64213653e
40 changed files with 103 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/modules/camera/CameraRollManager.java
View File

@@ -50,6 +50,7 @@ import com.facebook.react.bridge.WritableArray;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.bridge.WritableNativeArray;
import com.facebook.react.bridge.WritableNativeMap;
import com.facebook.react.bridge.annotations.ReactModule;
import com.facebook.react.common.ReactConstants;
// TODO #6015104: rename to something less iOSish
@@ -57,6 +58,7 @@ import com.facebook.react.common.ReactConstants;
* {@link NativeModule} that allows JS to interact with the photos on the device (i.e.
* {@link MediaStore.Images}).
*/
@ReactModule(name = "RKCameraRollManager")
public class CameraRollManager extends ReactContextBaseJavaModule {
private static final String ERROR_UNABLE_TO_LOAD = "E_UNABLE_TO_LOAD";
@@ -98,11 +100,6 @@ public class CameraRollManager extends ReactContextBaseJavaModule {
super(reactContext);
}
@Override
public String getName() {
return "RKCameraRollManager";
}
@Override
public Map<String, Object> getConstants() {
return Collections.emptyMap();
@@ -440,5 +437,4 @@ public class CameraRollManager extends ReactContextBaseJavaModule {
node.putMap("location", location);
}
}
}

9
ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageEditingManager.java
View File

@@ -46,11 +46,13 @@ import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.infer.annotation.Assertions;
import com.facebook.react.bridge.annotations.ReactModule;
import com.facebook.react.common.ReactConstants;
/**
* Native module that provides image cropping functionality.
*/
@ReactModule(name = "RKImageEditingManager")
public class ImageEditingManager extends ReactContextBaseJavaModule {
private static final List<String> LOCAL_URI_PREFIXES = Arrays.asList(
@@ -89,17 +91,11 @@ public class ImageEditingManager extends ReactContextBaseJavaModule {
ExifInterface.TAG_WHITE_BALANCE
};
public ImageEditingManager(ReactApplicationContext reactContext) {
super(reactContext);
new CleanTask(getReactApplicationContext()).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}
@Override
public String getName() {
return "RKImageEditingManager";
}
@Override
public Map<String, Object> getConstants() {
return Collections.emptyMap();
@@ -282,7 +278,6 @@ public class ImageEditingManager extends ReactContextBaseJavaModule {
}
mSuccess.invoke(Uri.fromFile(tempFile).toString());
} catch (Exception e) {
mError.invoke(e.getMessage());
}

7
ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageStoreManager.java
View File

@@ -27,7 +27,9 @@ import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.annotations.ReactModule;
@ReactModule(name = "ImageStoreManager")
public class ImageStoreManager extends ReactContextBaseJavaModule {
private static final int BUFFER_SIZE = 8192;
@@ -36,11 +38,6 @@ public class ImageStoreManager extends ReactContextBaseJavaModule {
super(reactContext);
}
@Override
public String getName() {
return "ImageStoreManager";
}
/**
* Calculate the base64 representation for an image. The "tag" comes from iOS naming.
*