From c60d9f8c1598ea48840ff72e0f75ab3088229b0a Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Thu, 9 May 2019 10:46:03 -0700 Subject: [PATCH] Fabric: Fixed memory leak happened between RCTSurfacePresenter and RCTBridge Summary: RCTBridge does not need to retain RCTSurfacePresenter, so we enforce that using `OBJC_ASSOCIATION_ASSIGN`. Reviewed By: mdvacca Differential Revision: D15273325 fbshipit-source-id: f223192ff5f781d9e905b004907739a36882bb63 --- React/Fabric/RCTSurfacePresenter.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/Fabric/RCTSurfacePresenter.mm b/React/Fabric/RCTSurfacePresenter.mm index ef6821ac0..4a7df3026 100644 --- a/React/Fabric/RCTSurfacePresenter.mm +++ b/React/Fabric/RCTSurfacePresenter.mm @@ -410,7 +410,7 @@ using namespace facebook::react; - (void)setSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter { - objc_setAssociatedObject(self, @selector(surfacePresenter), surfacePresenter, OBJC_ASSOCIATION_RETAIN_NONATOMIC); + objc_setAssociatedObject(self, @selector(surfacePresenter), surfacePresenter, OBJC_ASSOCIATION_ASSIGN); } - (RCTSurfacePresenter *)surfacePresenter