kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-09 09:12:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't throw runtime exception if WebSocket is already closed

Browse Source 
Summary: Refer #3364
Closes https://github.com/facebook/react-native/pull/3706

Reviewed By: svcscm

Differential Revision: D2585455

Pulled By: mkonicek

fb-gh-sync-id: fecd5e46c59a79a109aad97a49c9ea016e82d669
This commit is contained in:
Satyajit Sahoo
2015-10-27 08:33:38 -07:00
committed by facebook-github-bot-0
parent b28ff0451d
commit c45bb3e9c9
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java
View File

@@ -131,8 +131,13 @@ public class WebSocketModule extends ReactContextBaseJavaModule {
public void close(int code, String reason, int id) {
WebSocket client = mWebSocketConnections.get(id);
if (client == null) {
// This is a programmer error
throw new RuntimeException("Cannot close WebSocket. Unknown WebSocket id " + id);
// WebSocket is already closed
// Don't do anything, mirror the behaviour on web
FLog.w(
ReactConstants.TAG,
"Cannot close WebSocket. Unknown WebSocket id " + id);
return;
}
try {
client.close(code, reason);