From c399d697166301a823c7f7250b37ba5112e7bcc7 Mon Sep 17 00:00:00 2001
From: Valentin Shergin <shergin@fb.com>
Date: Mon, 16 Apr 2018 07:43:23 -0700
Subject: [PATCH] Fabric: More restrictive types (const &) for ShadowNode
 constuctors' arguments

Summary: Should be more performant theoretically.

Reviewed By: mdvacca

Differential Revision: D7591713

fbshipit-source-id: 74141053f2b91cb621cc0d573f89f3454512c585
---
 .../fabric/core/shadownode/ShadowNode.cpp        | 16 ++++++++--------
 ReactCommon/fabric/core/shadownode/ShadowNode.h  | 16 ++++++++--------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/ReactCommon/fabric/core/shadownode/ShadowNode.cpp b/ReactCommon/fabric/core/shadownode/ShadowNode.cpp
index 3c9fa034b..e7c6b68f2 100644
--- a/ReactCommon/fabric/core/shadownode/ShadowNode.cpp
+++ b/ReactCommon/fabric/core/shadownode/ShadowNode.cpp
@@ -21,11 +21,11 @@ SharedShadowNodeSharedList ShadowNode::emptySharedShadowNodeSharedList() {
 #pragma mark - Constructors
 
 ShadowNode::ShadowNode(
-  Tag tag,
-  Tag rootTag,
-  InstanceHandle instanceHandle,
-  SharedProps props,
-  SharedShadowNodeSharedList children
+  const Tag &tag,
+  const Tag &rootTag,
+  const InstanceHandle &instanceHandle,
+  const SharedProps &props,
+  const SharedShadowNodeSharedList &children
 ):
   tag_(tag),
   rootTag_(rootTag),
@@ -35,9 +35,9 @@ ShadowNode::ShadowNode(
   revision_(1) {}
 
 ShadowNode::ShadowNode(
-  SharedShadowNode shadowNode,
-  SharedProps props,
-  SharedShadowNodeSharedList children
+  const SharedShadowNode &shadowNode,
+  const SharedProps &props,
+  const SharedShadowNodeSharedList &children
 ):
   tag_(shadowNode->tag_),
   rootTag_(shadowNode->rootTag_),
diff --git a/ReactCommon/fabric/core/shadownode/ShadowNode.h b/ReactCommon/fabric/core/shadownode/ShadowNode.h
index 48e840fd6..a5b8a2ff9 100644
--- a/ReactCommon/fabric/core/shadownode/ShadowNode.h
+++ b/ReactCommon/fabric/core/shadownode/ShadowNode.h
@@ -35,17 +35,17 @@ public:
 #pragma mark - Constructors
 
   ShadowNode(
-    Tag tag,
-    Tag rootTag,
-    InstanceHandle instanceHandle,
-    SharedProps props = SharedProps(),
-    SharedShadowNodeSharedList children = SharedShadowNodeSharedList()
+    const Tag &tag,
+    const Tag &rootTag,
+    const InstanceHandle &instanceHandle,
+    const SharedProps &props = SharedProps(),
+    const SharedShadowNodeSharedList &children = SharedShadowNodeSharedList()
   );
 
   ShadowNode(
-    SharedShadowNode shadowNode,
-    SharedProps props = nullptr,
-    SharedShadowNodeSharedList children = nullptr
+    const SharedShadowNode &shadowNode,
+    const SharedProps &props = nullptr,
+    const SharedShadowNodeSharedList &children = nullptr
   );
 
 #pragma mark - Getters