kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-03-06 17:34:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove BatchedExecutionTime from Fabric metrics

Browse Source 
Summary: This diff removes BatchedExecutionTime from the metrics that are measured in Fabric. This does not add much value and it is not easy to compare against current version of RN

Reviewed By: shergin

Differential Revision: D14541976

fbshipit-source-id: c488e0951815306a978dd7a4246ec8a16d663218
This commit is contained in:
David Vacca
2019-03-23 00:35:47 -07:00
committed by Facebook Github Bot
parent 8618a5824f
commit bd7df8bdaa
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
View File

@@ -114,7 +114,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
private long mRunStartTime = 0l;
private long mBatchedExecutionTime = 0l;
private long mNonBatchedExecutionTime = 0l;
private long mDispatchViewUpdatesTime = 0l;
private long mCommitStartTime = 0l;
private long mLayoutTime = 0l;
@@ -348,7 +347,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
@UiThread
private void dispatchPreMountItems(long frameTimeNanos) {
long nonBatchedExecutionStartTime = SystemClock.uptimeMillis();
Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManager::premountViews");
while (true) {
@@ -367,7 +365,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
preMountItemsToDispatch.execute(mMountingManager);
}
mNonBatchedExecutionTime = SystemClock.uptimeMillis() - nonBatchedExecutionStartTime;
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
}
@@ -447,7 +444,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
performanceCounters.put("DispatchViewUpdatesTime", mDispatchViewUpdatesTime);
performanceCounters.put("RunStartTime", mRunStartTime);
performanceCounters.put("BatchedExecutionTime", mBatchedExecutionTime);
performanceCounters.put("NonBatchedExecutionTime", mNonBatchedExecutionTime);
performanceCounters.put("FinishFabricTransactionTime", mFinishTransactionTime);
performanceCounters.put("FinishFabricTransactionCPPTime", mFinishTransactionCPPTime);
return performanceCounters;