diff --git a/ReactAndroid/build.gradle b/ReactAndroid/build.gradle index c1917d380..e1adee3d7 100644 --- a/ReactAndroid/build.gradle +++ b/ReactAndroid/build.gradle @@ -195,7 +195,7 @@ def getNdkBuildFullPath() { } task buildReactNdkLib(dependsOn: [prepareJSC, prepareBoost, prepareDoubleConversion, prepareFolly, prepareGlog], type: Exec) { - inputs.file('src/main/jni/xreact') + inputs.file('src/main/jni/react') outputs.dir("$buildDir/react-ndk/all") commandLine getNdkBuildFullPath(), 'NDK_PROJECT_PATH=null', diff --git a/ReactAndroid/src/main/java/com/facebook/react/BUCK b/ReactAndroid/src/main/java/com/facebook/react/BUCK index 6f9688993..53b36ee37 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/BUCK @@ -1,35 +1,33 @@ include_defs("//ReactAndroid/DEFS") -DEPS = [ - react_native_dep("java/com/facebook/systrace:systrace"), - react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"), - react_native_dep("libraries/soloader/java/com/facebook/soloader:soloader"), - react_native_dep("third-party/android/support/v4:lib-support-v4"), - react_native_dep("third-party/java/infer-annotations:infer-annotations"), - react_native_dep("third-party/java/jsr-305:jsr-305"), - react_native_target("java/com/facebook/react/bridge:bridge"), - react_native_target("java/com/facebook/react/common:common"), - react_native_target("java/com/facebook/react/devsupport:devsupport"), - react_native_target("java/com/facebook/react/devsupport:interfaces"), - react_native_target("java/com/facebook/react/jstasks:jstasks"), - react_native_target("java/com/facebook/react/module/annotations:annotations"), - react_native_target("java/com/facebook/react/module/model:model"), - react_native_target("java/com/facebook/react/modules/appregistry:appregistry"), - react_native_target("java/com/facebook/react/modules/core:core"), - react_native_target("java/com/facebook/react/modules/debug:debug"), - react_native_target("java/com/facebook/react/modules/debug:interfaces"), - react_native_target("java/com/facebook/react/modules/deviceinfo:deviceinfo"), - react_native_target("java/com/facebook/react/modules/systeminfo:systeminfo"), - react_native_target("java/com/facebook/react/modules/toast:toast"), - react_native_target("java/com/facebook/react/uimanager:uimanager"), - react_native_target("java/com/facebook/react/views/imagehelper:imagehelper"), -] - android_library( name = "react", srcs = glob(["*.java"]), visibility = [ "PUBLIC", ], - deps = DEPS, + deps = [ + react_native_dep("java/com/facebook/systrace:systrace"), + react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"), + react_native_dep("libraries/soloader/java/com/facebook/soloader:soloader"), + react_native_dep("third-party/android/support/v4:lib-support-v4"), + react_native_dep("third-party/java/infer-annotations:infer-annotations"), + react_native_dep("third-party/java/jsr-305:jsr-305"), + react_native_target("java/com/facebook/react/bridge:bridge"), + react_native_target("java/com/facebook/react/common:common"), + react_native_target("java/com/facebook/react/devsupport:devsupport"), + react_native_target("java/com/facebook/react/devsupport:interfaces"), + react_native_target("java/com/facebook/react/jstasks:jstasks"), + react_native_target("java/com/facebook/react/module/annotations:annotations"), + react_native_target("java/com/facebook/react/module/model:model"), + react_native_target("java/com/facebook/react/modules/appregistry:appregistry"), + react_native_target("java/com/facebook/react/modules/core:core"), + react_native_target("java/com/facebook/react/modules/debug:debug"), + react_native_target("java/com/facebook/react/modules/debug:interfaces"), + react_native_target("java/com/facebook/react/modules/deviceinfo:deviceinfo"), + react_native_target("java/com/facebook/react/modules/systeminfo:systeminfo"), + react_native_target("java/com/facebook/react/modules/toast:toast"), + react_native_target("java/com/facebook/react/uimanager:uimanager"), + react_native_target("java/com/facebook/react/views/imagehelper:imagehelper"), + ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK b/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK index b2a5d5d72..20166eac0 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK @@ -34,5 +34,6 @@ android_library( react_native_dep("third-party/java/jsr-305:jsr-305"), react_native_target("java/com/facebook/react/common:common"), react_native_target("java/com/facebook/react/module/model:model"), + react_native_target("jni/react/jni:jni"), ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java index ee8bfc50b..f2777dca9 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java @@ -40,11 +40,8 @@ import com.facebook.systrace.TraceListener; */ @DoNotStrip public class CatalystInstanceImpl implements CatalystInstance { - - /* package */ static final String REACT_NATIVE_LIB = "reactnativejnifb"; - static { - SoLoader.loadLibrary(REACT_NATIVE_LIB); + ReactBridge.staticInit(); } private static final AtomicInteger sNextInstanceIdForTrace = new AtomicInteger(1); diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.java index 0198029d5..61a8ffc4e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.java @@ -16,7 +16,7 @@ import com.facebook.soloader.SoLoader; public class CxxModuleWrapperBase implements NativeModule { static { - SoLoader.loadLibrary(CatalystInstanceImpl.REACT_NATIVE_LIB); + ReactBridge.staticInit(); } @DoNotStrip diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java index a0515dbed..cefa0de59 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java @@ -32,7 +32,7 @@ public class JSCJavaScriptExecutor extends JavaScriptExecutor { } static { - SoLoader.loadLibrary(CatalystInstanceImpl.REACT_NATIVE_LIB); + ReactBridge.staticInit(); } public JSCJavaScriptExecutor(ReadableNativeArray jscConfig) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java index e5d3307e4..59e30eaa6 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ProxyJavaScriptExecutor.java @@ -39,7 +39,7 @@ public class ProxyJavaScriptExecutor extends JavaScriptExecutor { } static { - SoLoader.loadLibrary(CatalystInstanceImpl.REACT_NATIVE_LIB); + ReactBridge.staticInit(); } private @Nullable JavaJSExecutor mJavaJSExecutor; diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java index 3758b7e88..3f7aa5a6f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java @@ -12,16 +12,11 @@ package com.facebook.react.bridge; import com.facebook.soloader.SoLoader; public class ReactBridge { - - private static final String REACT_NATIVE_LIB = "reactnativejni"; - private static final String XREACT_NATIVE_LIB = "reactnativejnifb"; - static { - staticInit(); + SoLoader.loadLibrary("reactnativejni"); } public static void staticInit() { - SoLoader.loadLibrary(REACT_NATIVE_LIB); - SoLoader.loadLibrary(XREACT_NATIVE_LIB); + // This method only exists to trigger the static initializer above } } diff --git a/ReactAndroid/src/main/jni/react/jni/Android.mk b/ReactAndroid/src/main/jni/react/jni/Android.mk index 25b44eab7..a0fd71aaf 100644 --- a/ReactAndroid/src/main/jni/react/jni/Android.mk +++ b/ReactAndroid/src/main/jni/react/jni/Android.mk @@ -2,13 +2,31 @@ LOCAL_PATH := $(call my-dir) include $(CLEAR_VARS) -LOCAL_MODULE := libreactnativejni +LOCAL_MODULE := reactnativejni LOCAL_SRC_FILES := \ - Dummy.cpp \ + CatalystInstanceImpl.cpp \ + CxxModuleWrapper.cpp \ + JavaModuleWrapper.cpp \ + JMessageQueueThread.cpp \ + JSCPerfLogging.cpp \ + JSLoader.cpp \ + JSLogging.cpp \ + JniJSModulesUnbundle.cpp \ + MethodInvoker.cpp \ + ModuleRegistryBuilder.cpp \ + NativeArray.cpp \ + NativeCommon.cpp \ + NativeMap.cpp \ + OnLoad.cpp \ + ProxyExecutor.cpp \ + ReadableNativeArray.cpp \ + ReadableNativeMap.cpp \ + WritableNativeArray.cpp \ + WritableNativeMap.cpp \ LOCAL_C_INCLUDES := $(LOCAL_PATH) -LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../.. $(LOCAL_PATH)/.. +LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../.. LOCAL_CFLAGS += -Wall -Werror -fvisibility=hidden -fexceptions -frtti CXX11_FLAGS := -std=c++11 @@ -16,9 +34,14 @@ LOCAL_CFLAGS += $(CXX11_FLAGS) LOCAL_EXPORT_CPPFLAGS := $(CXX11_FLAGS) LOCAL_LDLIBS += -landroid -LOCAL_SHARED_LIBRARIES := libreactnativejnifb -LOCAL_STATIC_LIBRARIES := +LOCAL_SHARED_LIBRARIES := libfolly_json libfbjni libjsc libglog_init libyoga +LOCAL_STATIC_LIBRARIES := libreactnative include $(BUILD_SHARED_LIBRARY) -$(call import-module,xreact/jni) +$(call import-module,cxxreact) +$(call import-module,fb) +$(call import-module,fbgloginit) +$(call import-module,folly) +$(call import-module,jsc) +$(call import-module,yogajni) diff --git a/ReactAndroid/src/main/jni/react/jni/BUCK b/ReactAndroid/src/main/jni/react/jni/BUCK index 3d1e28fb5..8d408f8c1 100644 --- a/ReactAndroid/src/main/jni/react/jni/BUCK +++ b/ReactAndroid/src/main/jni/react/jni/BUCK @@ -1,17 +1,57 @@ include_defs("//ReactAndroid/DEFS") -# TODO(cjhopman): Remove this target (or move the xreact target to this directory). +EXPORTED_HEADERS = [ + "CxxModuleWrapper.h", + "CxxModuleWrapperBase.h", + "CxxSharedModuleWrapper.h", + "JavaModuleWrapper.h", + "JSLoader.h", + "MethodInvoker.h", + "ModuleRegistryBuilder.h", + "NativeArray.h", + "NativeCommon.h", + "NativeMap.h", + "ReadableNativeArray.h", + "ReadableNativeMap.h", + "WritableNativeArray.h", + "WritableNativeMap.h", +] + cxx_library( name = "jni", - srcs = [ - "Dummy.cpp", + srcs = glob(["*.cpp"]), + compiler_flags = [ + "-Wall", + "-Werror", + "-fexceptions", + "-std=c++1y", + "-frtti", + "-Wno-pessimizing-move", + "-Wno-inconsistent-missing-override", ], + exported_headers = EXPORTED_HEADERS, header_namespace = "react/jni", + headers = glob( + ["*.h"], + excludes = EXPORTED_HEADERS, + ), + preprocessor_flags = [ + "-DLOG_TAG=\"ReactNativeJNI\"", + "-DWITH_FBSYSTRACE=1", + "-DWITH_INSPECTOR=1", + ], soname = "libreactnativejni.$(ext)", visibility = [ "PUBLIC", ], - deps = [ - react_native_target("jni/xreact/jni:jni"), + xcode_public_headers_symlinks = True, + deps = JSC_DEPS + [ + "//native/third-party/android-ndk:android", + "//xplat/folly:molly", + "//xplat/fbgloginit:fbgloginit", + "//xplat/fbsystrace:fbsystrace", + react_native_xplat_target("cxxreact:bridge"), + react_native_xplat_target("cxxreact:module"), + FBJNI_TARGET, ], ) diff --git a/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp b/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.cpp rename to ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.h b/ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CatalystInstanceImpl.h rename to ReactAndroid/src/main/jni/react/jni/CatalystInstanceImpl.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp b/ReactAndroid/src/main/jni/react/jni/CxxModuleWrapper.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.cpp rename to ReactAndroid/src/main/jni/react/jni/CxxModuleWrapper.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.h b/ReactAndroid/src/main/jni/react/jni/CxxModuleWrapper.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapper.h rename to ReactAndroid/src/main/jni/react/jni/CxxModuleWrapper.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapperBase.h b/ReactAndroid/src/main/jni/react/jni/CxxModuleWrapperBase.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CxxModuleWrapperBase.h rename to ReactAndroid/src/main/jni/react/jni/CxxModuleWrapperBase.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/CxxSharedModuleWrapper.h b/ReactAndroid/src/main/jni/react/jni/CxxSharedModuleWrapper.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/CxxSharedModuleWrapper.h rename to ReactAndroid/src/main/jni/react/jni/CxxSharedModuleWrapper.h diff --git a/ReactAndroid/src/main/jni/react/jni/Dummy.cpp b/ReactAndroid/src/main/jni/react/jni/Dummy.cpp deleted file mode 100644 index f51f98f1c..000000000 --- a/ReactAndroid/src/main/jni/react/jni/Dummy.cpp +++ /dev/null @@ -1,7 +0,0 @@ -// Copyright 2004-present Facebook. All Rights Reserved. -namespace facebook { -namespace react { - void ThisWhatsLeftOfTheOldBridge() { - } -} -} diff --git a/ReactAndroid/src/main/jni/xreact/jni/JCallback.h b/ReactAndroid/src/main/jni/react/jni/JCallback.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JCallback.h rename to ReactAndroid/src/main/jni/react/jni/JCallback.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JInspector.cpp b/ReactAndroid/src/main/jni/react/jni/JInspector.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JInspector.cpp rename to ReactAndroid/src/main/jni/react/jni/JInspector.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JInspector.h b/ReactAndroid/src/main/jni/react/jni/JInspector.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JInspector.h rename to ReactAndroid/src/main/jni/react/jni/JInspector.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JMessageQueueThread.cpp b/ReactAndroid/src/main/jni/react/jni/JMessageQueueThread.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JMessageQueueThread.cpp rename to ReactAndroid/src/main/jni/react/jni/JMessageQueueThread.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JMessageQueueThread.h b/ReactAndroid/src/main/jni/react/jni/JMessageQueueThread.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JMessageQueueThread.h rename to ReactAndroid/src/main/jni/react/jni/JMessageQueueThread.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JNativeRunnable.h b/ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JNativeRunnable.h rename to ReactAndroid/src/main/jni/react/jni/JNativeRunnable.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp b/ReactAndroid/src/main/jni/react/jni/JSCPerfLogging.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp rename to ReactAndroid/src/main/jni/react/jni/JSCPerfLogging.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.h b/ReactAndroid/src/main/jni/react/jni/JSCPerfLogging.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.h rename to ReactAndroid/src/main/jni/react/jni/JSCPerfLogging.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSLoader.cpp b/ReactAndroid/src/main/jni/react/jni/JSLoader.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSLoader.cpp rename to ReactAndroid/src/main/jni/react/jni/JSLoader.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSLoader.h b/ReactAndroid/src/main/jni/react/jni/JSLoader.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSLoader.h rename to ReactAndroid/src/main/jni/react/jni/JSLoader.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp b/ReactAndroid/src/main/jni/react/jni/JSLogging.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSLogging.cpp rename to ReactAndroid/src/main/jni/react/jni/JSLogging.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JSLogging.h b/ReactAndroid/src/main/jni/react/jni/JSLogging.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JSLogging.h rename to ReactAndroid/src/main/jni/react/jni/JSLogging.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JavaModuleWrapper.cpp b/ReactAndroid/src/main/jni/react/jni/JavaModuleWrapper.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JavaModuleWrapper.cpp rename to ReactAndroid/src/main/jni/react/jni/JavaModuleWrapper.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JavaModuleWrapper.h b/ReactAndroid/src/main/jni/react/jni/JavaModuleWrapper.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JavaModuleWrapper.h rename to ReactAndroid/src/main/jni/react/jni/JavaModuleWrapper.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JavaScriptExecutorHolder.h b/ReactAndroid/src/main/jni/react/jni/JavaScriptExecutorHolder.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JavaScriptExecutorHolder.h rename to ReactAndroid/src/main/jni/react/jni/JavaScriptExecutorHolder.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/JniJSModulesUnbundle.cpp b/ReactAndroid/src/main/jni/react/jni/JniJSModulesUnbundle.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JniJSModulesUnbundle.cpp rename to ReactAndroid/src/main/jni/react/jni/JniJSModulesUnbundle.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/JniJSModulesUnbundle.h b/ReactAndroid/src/main/jni/react/jni/JniJSModulesUnbundle.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/JniJSModulesUnbundle.h rename to ReactAndroid/src/main/jni/react/jni/JniJSModulesUnbundle.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp b/ReactAndroid/src/main/jni/react/jni/MethodInvoker.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.cpp rename to ReactAndroid/src/main/jni/react/jni/MethodInvoker.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.h b/ReactAndroid/src/main/jni/react/jni/MethodInvoker.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/MethodInvoker.h rename to ReactAndroid/src/main/jni/react/jni/MethodInvoker.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryBuilder.cpp b/ReactAndroid/src/main/jni/react/jni/ModuleRegistryBuilder.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryBuilder.cpp rename to ReactAndroid/src/main/jni/react/jni/ModuleRegistryBuilder.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryBuilder.h b/ReactAndroid/src/main/jni/react/jni/ModuleRegistryBuilder.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryBuilder.h rename to ReactAndroid/src/main/jni/react/jni/ModuleRegistryBuilder.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/NativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeArray.h b/ReactAndroid/src/main/jni/react/jni/NativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeArray.h rename to ReactAndroid/src/main/jni/react/jni/NativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeCommon.cpp b/ReactAndroid/src/main/jni/react/jni/NativeCommon.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeCommon.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeCommon.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeCommon.h b/ReactAndroid/src/main/jni/react/jni/NativeCommon.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeCommon.h rename to ReactAndroid/src/main/jni/react/jni/NativeCommon.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/NativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/NativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/NativeMap.h b/ReactAndroid/src/main/jni/react/jni/NativeMap.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/NativeMap.h rename to ReactAndroid/src/main/jni/react/jni/NativeMap.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp b/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/OnLoad.cpp rename to ReactAndroid/src/main/jni/react/jni/OnLoad.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/OnLoad.h b/ReactAndroid/src/main/jni/react/jni/OnLoad.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/OnLoad.h rename to ReactAndroid/src/main/jni/react/jni/OnLoad.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/ProxyExecutor.cpp b/ReactAndroid/src/main/jni/react/jni/ProxyExecutor.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ProxyExecutor.cpp rename to ReactAndroid/src/main/jni/react/jni/ProxyExecutor.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ProxyExecutor.h b/ReactAndroid/src/main/jni/react/jni/ProxyExecutor.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ProxyExecutor.h rename to ReactAndroid/src/main/jni/react/jni/ProxyExecutor.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.h b/ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeArray.h rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.h b/ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/ReadableNativeMap.h rename to ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.cpp b/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.cpp rename to ReactAndroid/src/main/jni/react/jni/WritableNativeArray.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.h b/ReactAndroid/src/main/jni/react/jni/WritableNativeArray.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeArray.h rename to ReactAndroid/src/main/jni/react/jni/WritableNativeArray.h diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.cpp b/ReactAndroid/src/main/jni/react/jni/WritableNativeMap.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.cpp rename to ReactAndroid/src/main/jni/react/jni/WritableNativeMap.cpp diff --git a/ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.h b/ReactAndroid/src/main/jni/react/jni/WritableNativeMap.h similarity index 100% rename from ReactAndroid/src/main/jni/xreact/jni/WritableNativeMap.h rename to ReactAndroid/src/main/jni/react/jni/WritableNativeMap.h diff --git a/ReactAndroid/src/main/jni/xreact/perftests/BUCK b/ReactAndroid/src/main/jni/react/perftests/BUCK similarity index 100% rename from ReactAndroid/src/main/jni/xreact/perftests/BUCK rename to ReactAndroid/src/main/jni/react/perftests/BUCK diff --git a/ReactAndroid/src/main/jni/xreact/perftests/OnLoad.cpp b/ReactAndroid/src/main/jni/react/perftests/OnLoad.cpp similarity index 100% rename from ReactAndroid/src/main/jni/xreact/perftests/OnLoad.cpp rename to ReactAndroid/src/main/jni/react/perftests/OnLoad.cpp diff --git a/ReactAndroid/src/main/jni/xreact/Android.mk b/ReactAndroid/src/main/jni/xreact/Android.mk deleted file mode 100644 index 2d6fafdc9..000000000 --- a/ReactAndroid/src/main/jni/xreact/Android.mk +++ /dev/null @@ -1,39 +0,0 @@ -LOCAL_PATH := $(call my-dir) - -include $(CLEAR_VARS) - -LOCAL_MODULE := reactnativejnifb - -LOCAL_SRC_FILES := \ - CatalystInstanceImpl.cpp \ - CxxModuleWrapper.cpp \ - JavaModuleWrapper.cpp \ - JMessageQueueThread.cpp \ - JniJSModulesUnbundle.cpp \ - JSCPerfLogging.cpp \ - JSLoader.cpp \ - JSLogging.cpp \ - MethodInvoker.cpp \ - OnLoad.cpp \ - ProxyExecutor.cpp \ - -LOCAL_C_INCLUDES := $(LOCAL_PATH) -LOCAL_C_INCLUDES := $(LOCAL_PATH)/../../ - -LOCAL_CFLAGS += -Wall -Werror -fvisibility=hidden -fexceptions -frtti -CXX11_FLAGS := -std=c++11 -LOCAL_CFLAGS += $(CXX11_FLAGS) -LOCAL_EXPORT_CPPFLAGS := $(CXX11_FLAGS) - -LOCAL_LDLIBS += -landroid -LOCAL_SHARED_LIBRARIES := libfolly_json libfbjni libjsc libglog_init libreactnativejni -LOCAL_STATIC_LIBRARIES := libreactnative libreactnativefb - -include $(BUILD_SHARED_LIBRARY) - -$(call import-module,cxxreact) -$(call import-module,jsc) -$(call import-module,folly) -$(call import-module,fbgloginit) -$(call import-module,jni) -$(call import-module,react) diff --git a/ReactAndroid/src/main/jni/xreact/jni/Android.mk b/ReactAndroid/src/main/jni/xreact/jni/Android.mk deleted file mode 100644 index 0bbb59aee..000000000 --- a/ReactAndroid/src/main/jni/xreact/jni/Android.mk +++ /dev/null @@ -1,47 +0,0 @@ -LOCAL_PATH := $(call my-dir) - -include $(CLEAR_VARS) - -LOCAL_MODULE := libreactnativejnifb - -LOCAL_SRC_FILES := \ - CatalystInstanceImpl.cpp \ - CxxModuleWrapper.cpp \ - JavaModuleWrapper.cpp \ - JMessageQueueThread.cpp \ - JSCPerfLogging.cpp \ - JSLoader.cpp \ - JSLogging.cpp \ - JniJSModulesUnbundle.cpp \ - MethodInvoker.cpp \ - ModuleRegistryBuilder.cpp \ - NativeArray.cpp \ - NativeCommon.cpp \ - NativeMap.cpp \ - OnLoad.cpp \ - ProxyExecutor.cpp \ - ReadableNativeArray.cpp \ - ReadableNativeMap.cpp \ - WritableNativeArray.cpp \ - WritableNativeMap.cpp \ - -LOCAL_C_INCLUDES := $(LOCAL_PATH) -LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../.. - -LOCAL_CFLAGS += -Wall -Werror -fvisibility=hidden -fexceptions -frtti -CXX11_FLAGS := -std=c++11 -LOCAL_CFLAGS += $(CXX11_FLAGS) -LOCAL_EXPORT_CPPFLAGS := $(CXX11_FLAGS) - -LOCAL_LDLIBS += -landroid -LOCAL_SHARED_LIBRARIES := libfolly_json libfbjni libjsc libglog_init libyoga -LOCAL_STATIC_LIBRARIES := libreactnativefb - -include $(BUILD_SHARED_LIBRARY) - -$(call import-module,cxxreact) -$(call import-module,jsc) -$(call import-module,folly) -$(call import-module,fbgloginit) -$(call import-module,jsc) -$(call import-module,yogajni) diff --git a/ReactAndroid/src/main/jni/xreact/jni/BUCK b/ReactAndroid/src/main/jni/xreact/jni/BUCK deleted file mode 100644 index c2109fa9f..000000000 --- a/ReactAndroid/src/main/jni/xreact/jni/BUCK +++ /dev/null @@ -1,57 +0,0 @@ -include_defs("//ReactAndroid/DEFS") - -EXPORTED_HEADERS = [ - "CxxModuleWrapper.h", - "CxxModuleWrapperBase.h", - "CxxSharedModuleWrapper.h", - "JavaModuleWrapper.h", - "JSLoader.h", - "MethodInvoker.h", - "ModuleRegistryBuilder.h", - "NativeArray.h", - "NativeCommon.h", - "NativeMap.h", - "ReadableNativeArray.h", - "ReadableNativeMap.h", - "WritableNativeArray.h", - "WritableNativeMap.h", -] - -cxx_library( - name = "jni", - srcs = glob(["*.cpp"]), - compiler_flags = [ - "-Wall", - "-Werror", - "-fexceptions", - "-std=c++1y", - "-frtti", - "-Wno-pessimizing-move", - "-Wno-inconsistent-missing-override", - ], - exported_headers = EXPORTED_HEADERS, - header_namespace = "xreact/jni", - headers = glob( - ["*.h"], - excludes = EXPORTED_HEADERS, - ), - preprocessor_flags = [ - "-DLOG_TAG=\"ReactNativeJNI\"", - "-DWITH_FBSYSTRACE=1", - "-DWITH_INSPECTOR=1", - ], - soname = "libreactnativejnifb.$(ext)", - visibility = [ - "PUBLIC", - ], - xcode_public_headers_symlinks = True, - deps = JSC_DEPS + [ - "//native/third-party/android-ndk:android", - "//xplat/folly:molly", - "//xplat/fbgloginit:fbgloginit", - "//xplat/fbsystrace:fbsystrace", - react_native_xplat_target("cxxreact:bridge"), - react_native_xplat_target("cxxreact:module"), - FBJNI_TARGET, - ], -) diff --git a/ReactCommon/cxxreact/Android.mk b/ReactCommon/cxxreact/Android.mk index 984a1638d..70b7cb98b 100644 --- a/ReactCommon/cxxreact/Android.mk +++ b/ReactCommon/cxxreact/Android.mk @@ -2,7 +2,7 @@ LOCAL_PATH := $(call my-dir) include $(CLEAR_VARS) -LOCAL_MODULE := libreactnativefb +LOCAL_MODULE := reactnative LOCAL_SRC_FILES := \ CxxNativeModule.cpp \ diff --git a/ReactCommon/cxxreact/BUCK b/ReactCommon/cxxreact/BUCK index 01062c5ed..a59063975 100644 --- a/ReactCommon/cxxreact/BUCK +++ b/ReactCommon/cxxreact/BUCK @@ -134,7 +134,7 @@ rn_xplat_cxx_library( # `initOnJSVMThread` to be called before the platform-specific hooks # have been properly initialised. Bad Times(TM). # -- @ashokmenon (2017/01/03) - react_native_target("jni/xreact/jni:jni"), + react_native_target("jni/react/jni:jni"), react_native_xplat_target("cxxreact/..."), ], fbobjc_frameworks = [