From bb6a69075b908ea5e0eca9a0ed8ca49dd26f4230 Mon Sep 17 00:00:00 2001 From: nd-02110114 Date: Tue, 16 Oct 2018 16:17:00 -0700 Subject: [PATCH] remove createrReactClass from SizeFlexibilityUpdateTest (#21715) Summary: Related to #21581 . Removed createReactClass from the IntegrationTests/SizeFlexibilityUpdateTest.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [IntegrationTests/SizeFlexibilityUpdateTest.js] - remove createReactClass dependency Pull Request resolved: https://github.com/facebook/react-native/pull/21715 Reviewed By: TheSavior Differential Revision: D10341543 Pulled By: RSNara fbshipit-source-id: 748f9a0176b6cd865d956df774f6dec1ead21562 --- IntegrationTests/SizeFlexibilityUpdateTest.js | 38 +++++++++++-------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/IntegrationTests/SizeFlexibilityUpdateTest.js b/IntegrationTests/SizeFlexibilityUpdateTest.js index 9220a479a..42ce5bf5f 100644 --- a/IntegrationTests/SizeFlexibilityUpdateTest.js +++ b/IntegrationTests/SizeFlexibilityUpdateTest.js @@ -11,7 +11,6 @@ 'use strict'; const React = require('react'); -const createReactClass = require('create-react-class'); const ReactNative = require('react-native'); const RCTNativeAppEventEmitter = require('RCTNativeAppEventEmitter'); const {View} = ReactNative; @@ -24,29 +23,38 @@ const reactViewHeight = 222; let finalState = false; -const SizeFlexibilityUpdateTest = createReactClass({ - displayName: 'SizeFlexibilityUpdateTest', - _subscription: (null: ?EmitterSubscription), +type Props = $ReadOnly<{| + width: boolean, + height: boolean, + both: boolean, + none: boolean, +|}>; - UNSAFE_componentWillMount: function() { +class SizeFlexibilityUpdateTest extends React.Component { + _subscription: ?EmitterSubscription = null; + + UNSAFE_componentWillMount() { this._subscription = RCTNativeAppEventEmitter.addListener( 'rootViewDidChangeIntrinsicSize', this.rootViewDidChangeIntrinsicSize, ); - }, + } - componentWillUnmount: function() { + componentWillUnmount() { if (this._subscription != null) { this._subscription.remove(); } - }, + } - markPassed: function() { + markPassed = () => { TestModule.markTestPassed(true); finalState = true; - }, + }; - rootViewDidChangeIntrinsicSize: function(intrinsicSize) { + rootViewDidChangeIntrinsicSize = (intrinsicSize: { + width: number, + height: number, + }) => { if (finalState) { // If a test reaches its final state, it is not expected to do anything more TestModule.markTestPassed(false); @@ -89,13 +97,11 @@ const SizeFlexibilityUpdateTest = createReactClass({ return; } } - }, + }; render() { return ; - }, -}); - -SizeFlexibilityUpdateTest.displayName = 'SizeFlexibilityUpdateTest'; + } +} module.exports = SizeFlexibilityUpdateTest;